Date:   Wed, 15 Feb 2023 09:52:27 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Frank Jungclaus <frank.jungclaus@esd.eu>
Cc:     linux-can@vger.kernel.org, Wolfgang Grandegger <wg@grandegger.com>,
        Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
        Stefan =?utf-8?B?TcOkdGpl?= <stefan.maetje@esd.eu>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] can: esd_usb: Some more preparation for
 supporting esd CAN-USB/3
Message-ID: <20230215085227.sqpqtzprsmpzdthu@pengutronix.de>
References: <20230214160223.1199464-1-frank.jungclaus@esd.eu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="4irvznxndggari5u"
Content-Disposition: inline
In-Reply-To: <20230214160223.1199464-1-frank.jungclaus@esd.eu>
Precedence: bulk


--4irvznxndggari5u
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 14.02.2023 17:02:20, Frank Jungclaus wrote:
> Another small batch of patches to be seen as preparation for adding
> support of the newly available esd CAN-USB/3 to esd_usb.c.
>=20
> Due to some unresolved questions adding support for
> CAN_CTRLMODE_BERR_REPORTING has been postponed to one of the future
> patches.
>=20
> *Resend of the whole series as v2 for easier handling.*

As Vincent pointed out in review of a completely different patch series,
bu this applies here, too:

| For the titles, please use imperative (e.g. add) instead of past tense
| (e.g. Added). This also applies to the description.

Further, the subject ob patches 1 and 2 can be improved a bit, e.g.
patch 1 could mention to move the SJA1000_ECC_SEG for a specific reason.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--4irvznxndggari5u
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEDs2BvajyNKlf9TJQvlAcSiqKBOgFAmPsnUgACgkQvlAcSiqK
BOjykgf9GgEzqesqTvurBmGYMYtYtRIf0caqQYhbycWjabYH4DmHYEgVo73nTjjV
52eSMJ29gikMy9bNO9WW2D1VEAdGdPAwHtCWCc4z4YP5VqC0T92zdDa2K7a3Eaqp
YV2b9aQqovOHhvV5tKk1AAlqgqkj8o16o5WRnu5ZKzCwpTonHumNgOyreUPXAtJj
KCHUACfZHVdbhL5JTGWiUvdPCTCD3WAk15i10kKoQkpYBZgKBR2wKeQKwVuEAQUK
mefWPYsDG2RL8Y/k9G9O+F/HY670A9+UAGD3RzXeygjx9vwES0OZ0QjJxfZkoJ/K
sHWxHfMH9AOGIjbTyYY8lpiSjpZNhg==
=9mVM
-----END PGP SIGNATURE-----

--4irvznxndggari5u--