Date:   Wed, 15 Feb 2023 12:16:52 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Sasha Finkelstein <fnkl.kernel@gmail.com>
Cc:     thierry.reding@gmail.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, marcan@marcan.st,
        sven@svenpeter.dev, alyssa@rosenzweig.io, asahi@lists.linux.dev,
        linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 3/5] arm64: dts: apple: t8103: Add PWM controller
Message-ID: <20230215111652.lyhebfntqlibtmex@pengutronix.de>
References: <20230114132508.96600-1-fnkl.kernel@gmail.com>
 <20230114132508.96600-4-fnkl.kernel@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="6p3sxojse4xv3o5l"
Content-Disposition: inline
In-Reply-To: <20230114132508.96600-4-fnkl.kernel@gmail.com>
Precedence: bulk


--6p3sxojse4xv3o5l
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jan 14, 2023 at 04:25:06PM +0300, Sasha Finkelstein wrote:
> Adds PWM controller and keyboard backlight bindings for M1 MacBooks
>=20
> Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
> Acked-by: Sven Peter <sven@svenpeter.dev>
> ---
>  arch/arm64/boot/dts/apple/t8103-j293.dts | 17 +++++++++++++++++
>  arch/arm64/boot/dts/apple/t8103-j313.dts | 17 +++++++++++++++++
>  arch/arm64/boot/dts/apple/t8103.dtsi     |  9 +++++++++
>  3 files changed, 43 insertions(+)
>=20
> diff --git a/arch/arm64/boot/dts/apple/t8103-j293.dts b/arch/arm64/boot/d=
ts/apple/t8103-j293.dts
> index 151074109a11..7381dccc1613 100644
> --- a/arch/arm64/boot/dts/apple/t8103-j293.dts
> +++ b/arch/arm64/boot/dts/apple/t8103-j293.dts
> @@ -11,10 +11,23 @@
> =20
>  #include "t8103.dtsi"
>  #include "t8103-jxxx.dtsi"
> +#include <dt-bindings/leds/common.h>
> =20
>  / {
>  	compatible =3D "apple,j293", "apple,t8103", "apple,arm-platform";
>  	model =3D "Apple MacBook Pro (13-inch, M1, 2020)";
> +
> +	led-controller {
> +		compatible =3D "pwm-leds";
> +		led-0 {
> +			pwms =3D <&fpwm1 0 40000>;
> +			label =3D "kbd_backlight";
> +			function =3D LED_FUNCTION_KBD_BACKLIGHT;
> +			color =3D <LED_COLOR_ID_WHITE>;
> +			max-brightness =3D <255>;
> +			default-state =3D "keep";
> +		};
> +	};
>  };
> =20
>  &bluetooth0 {
> @@ -47,3 +60,7 @@ &i2c2 {
>  &i2c4 {
>  	status =3D "okay";
>  };
> +
> +&fpwm1 {
> +	status =3D "okay";
> +};
> \ No newline at end of file

This missing newline looks wrong.

Otherwise the patch looks fine to me.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--6p3sxojse4xv3o5l
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmPsvyEACgkQwfwUeK3K
7AkOlwf/U3bq2lMyN/O90iDAvjsqHfCLHm3TVOgn4ERdvjgeJ2DxZT1OoblzvJSL
u+asOEpsEjWrC0+vObmNUdRrZhMzlsLNd64rQyaKVVa6coBE9Ku2LUymxZdEj54N
HJjfEvXWtKwWEWVOxyVFx3IlcI5tlMVQ+mR+cdP0rg7G7wnBNbv968QY9q3Y6o4w
PWI+KqYQkgcROrKlkn3Bh9q0WfeKVALU+gOauRW4A9l25zPNed86MqeUUQVNcbDW
PAmMOnmrpMpzbPJZUXgaGUGsbf/copkFDvg8F53gIBx/r3D5gfYKT4b6CMHRQiPR
VDTyV6oFsFGcIPBMZeejjj+juTXEjg==
=Wc+G
-----END PGP SIGNATURE-----

--6p3sxojse4xv3o5l--