Date:   Wed, 15 Feb 2023 13:31:31 +0200
From:   Leon Romanovsky <leon@kernel.org>
To:     Jason Gunthorpe <jgg@ziepe.ca>
Cc:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-rdma@vger.kernel.org
Subject: Re: [PATCH] RDMA/restrack: Reorder fields in 'struct
 rdma_restrack_entry'
Message-ID: <Y+zCkwTgevj0zDFK@unreal>
References: <d47800d9fd5ac7c33d01af04b12b6d43ad23c96e.1676379187.git.christophe.jaillet@wanadoo.fr>
 <Y+uH0k0OBzPip1P8@ziepe.ca>
 <75480cf9-8d06-7a7d-4624-6ddbb7d6053a@wanadoo.fr>
 <Y+uiLCB7H2xVvQZW@ziepe.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <Y+uiLCB7H2xVvQZW@ziepe.ca>
Precedence: bulk

On Tue, Feb 14, 2023 at 11:01:00AM -0400, Jason Gunthorpe wrote:
> On Tue, Feb 14, 2023 at 03:34:21PM +0100, Christophe JAILLET wrote:
> > Le 14/02/2023 ? 14:08, Jason Gunthorpe a ?crit?:
> > > On Tue, Feb 14, 2023 at 01:53:52PM +0100, Christophe JAILLET wrote:
> > > > diff --git a/include/rdma/restrack.h b/include/rdma/restrack.h
> > > > index 8b7c46daeb07..da53fefe6f9e 100644
> > > > --- a/include/rdma/restrack.h
> > > > +++ b/include/rdma/restrack.h
> > > > @@ -80,6 +80,10 @@ struct rdma_restrack_entry {
> > > >   	 * query stage.
> > > >   	 */
> > > >   	u8			no_track : 1;
> > > > +	/**
> > > > +	 * @user: user resource
> > > > +	 */
> > > > +	bool			user;
> > > 
> > > Can we combine this into the bitfield above?
> > > 
> > > Jason
> > > 
> > Hi,
> > 
> > and even above, we have
> > 	bool	valid;
> > 
> > I wanted to keep the changes as minimal as possible, but I can change them
> > all in a single bitfield.
> 
> IIRC it needs to be checked, I vaugely remember valid can't be a
> bitfield because it is an atomic

I don't remember anything like this.

Thanks