Message-ID: <TY3P286MB26111053410F3F96C9C71D2798A39@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM>
Date:   Wed, 15 Feb 2023 19:59:01 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
To:     William Qiu <william.qiu@starfivetech.com>,
        linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
        linux-mmc@vger.kernel.org
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jaehoon Chung <jh80.chung@samsung.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        linux-kernel@vger.kernel.org
References: <20230215113249.47727-1-william.qiu@starfivetech.com>
 <20230215113249.47727-2-william.qiu@starfivetech.com>
From:   Shengyu Qu <wiagn233@outlook.com>
Subject: Re: [PATCH v4 1/4] dt-bindings: mmc: Add StarFive MMC module
In-Reply-To: <20230215113249.47727-2-william.qiu@starfivetech.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: TY3P286MB2611:EE_|TYYP286MB1620:EE_
X-MS-Office365-Filtering-Correlation-Id: 67be4b3d-c5e2-4ef7-9ef7-08db0f4c0b86
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: wHoOVsd3eHVL61NTZ1h4rsKqVmDdEKaUxa+Iu9Yw9Q1TP6vpxnwS/ndgX+njNe+36C0f6+mJNztdMpavs8NJL96tJ3MWFiqRMJfpzmHNC7HRZS4vmzDTu5Nf2wQOTbDVmcHh9wuBaLtrAI4LZSfPrUWz3U40rRvJA7COEYUovhyAuD01qEsmArs6M4arN6Degx2VQS3BPlv+8LoQjHSWn/AmcBd9ZG+QNdJ/JHUnAudf8fJuxxZK/E+EWdZm6nJ3YpmwGN4F9S8m7t3kZIoa3/NKNcuha6dv6jOQvin7PhFqyqDYSK1w3CJNQXOebNdoxKczbSzI5AM9b2SqrWywSNgWywwhngibIm62IbjEnYeq1HJwucPTUfaJz1netFPQpod++P+e+ueLvGA1CmBIRCsOjmGcwRgldUvxIx9nJ4ngOtSWF9ltsxdmNFawNFJLwL0shKVezR0GkTYEjKQFHIEombmtDO5OYy20VsAaGyaKFBH+meL9JxGa76onkWoMgIFD3u/R/bCG2BrbGsDay80UqF/HCRcIvBESXHOOQVs5N3bdrxSb7mOi2mZwo5HZvvaRTN3NN6T2pYRvQ2btJSggIt5pLrayAq2Anbu4K/RGJx8qFsADF9bPdAki6JlR
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0l3YzlDdk1LTFE4OWdzZWZKclNkbmFPWGhKVWNHdUYwRFphL1h5YzJ2MVBO?=
 =?utf-8?B?UHJPSHFvT0YzQjlnTFhiTTIyMEtxOVl3ZjFOWDYxOFJYVlk3YWpsZW56VnZy?=
 =?utf-8?B?Y2FGSGYrajdSRHRkQlJtL203T1YyV2xhcERTTnRlY05aTHhCTTU1QWR0elZI?=
 =?utf-8?B?V1lqRTM5YjVYQ0QzYlAzb3FwdE9RSzUvVDBHdXNHYWFZcEVPZkxETnpwb3E5?=
 =?utf-8?B?QlVRc3lKVHd2QU5tZ085WlRBRXB4aUF3TDlwT3huZ2lXWlNLVW55OFloQStS?=
 =?utf-8?B?NXJWQm4za1ZpMHdpSSt2QXZyWVRGZTdDTFNGUFZsM1NyZm5nRFB4ZHBuYnR5?=
 =?utf-8?B?K01EVm5qdkxSSVJ2L2tTdXRnUGxTNDcxb2RLNWFJL1d6SExHSVp1cXVRamdh?=
 =?utf-8?B?eUpXQThrL3J5TFlyYjlTdzRqd25SeVNpQTZCaWRlS2hlUWRVTlA0YkJFM090?=
 =?utf-8?B?M0VHR1dya1YvdVByeDJ6WnA1WnNjT1FwNWZOdmM0RUdjZFpZZ2Y1S251d2J6?=
 =?utf-8?B?RUx3WHlvdUVCNE9DOC82QnZHdlFocDdXazlJeXVrSEhDd0ZObENTVzFBcU9J?=
 =?utf-8?B?QVhucE1WdHF2bG9HbTByQTFLMUpZME1PbXBMNCtOWEE2L1dpMnVMTjF0OFMv?=
 =?utf-8?B?TTArNjVvKzJyemZWa2VQZDlwb3Z6Z3dodUlncGppakhDalRCNU40RlpHZlow?=
 =?utf-8?B?czJDQmhtTWdyUWZBUWowQndzeitiN24xS0U0ZVY2Ny9XMy9MUUVHb2ZxSmd4?=
 =?utf-8?B?TzV0dncyREo3QnFJNGU2cU9pdUJpVHpxUFd0R1ZoUnFDRmx4UktEUW5PU2Yx?=
 =?utf-8?B?NVNMM1N3NDVDa09ORU9nc3Vrd1RXTDk1NVc2Z3Jra3Z3SG92SWVKSnFEMlFw?=
 =?utf-8?B?Z3NKWjkzWUR5OTNtSENMQk5taG5CeDVUVG9wd3BRRXZPbm1XcjE2SGpmcEFr?=
 =?utf-8?B?RGVNbVZzR0pZWSsraElIcDNHYTBidzBJYWVTalBKTitBMFFxbFVMbFRLb0JW?=
 =?utf-8?B?alZNOExuYldVWkVGMFZoc2F5SlVXcVkvYjF1WmVUY1hYQ3EzY3ZRZFFveDdI?=
 =?utf-8?B?S21rcGFnUlVoU0ViNmJkenNGRk81R3U2TVlVcE82MjRpbk1mQ0dnS3A4NW43?=
 =?utf-8?B?V01PVTNhejdkUWtsYWV3akpiUTllaU5IRjF4V2VLU29CTCtSUDZsV1YwazJP?=
 =?utf-8?B?S2tSb2t5WkJXb01MbmNQVVZqSGZLRWVUVTZRdWMyTGZkaE5MWkUwSjhYbkx6?=
 =?utf-8?B?RzBoQVlHeXZvcTRpRnlmeUlIN2dEcTNhNklBNWJPQThjeU5hK3JzN0ExUVZh?=
 =?utf-8?B?WVRlWVV0QkhMUE8zR210dUxOdDJ2N205SkpOZElCajdlUXhtMFhNd3VXMnBM?=
 =?utf-8?B?b2JEL0VmR3RKOXN3d3dITEt1RThNbUhIWWNOc2Nqby9hV2VaMlBtV29FQVgw?=
 =?utf-8?B?UUhCUThSN1FQSldteDNjL1FhTG9rYW9YYURta3RvSDRKS2VTNnFDdTJGT3Mw?=
 =?utf-8?B?VmdOY3Q1UHFxSU0yQjY3eFhCam4zZWp2ZGlwb2pYSUlQdzIxZm5nOGxBWjRs?=
 =?utf-8?B?VTVKSTdvK0VrVzA5U0h2bjVkRG1uV3JpQTRucThSNHY0amFZVExLMnplWTVk?=
 =?utf-8?B?WXhZNnZkMWErODBhNnE2Mks3NUYvR1dLMllad2Y5OWR2YkVjZWxjYkYxdFBh?=
 =?utf-8?B?MEs1bUloSFJzVGpteTNONmJZRVhCT2w1d2RCMGpSRm82U29EZHZlbjZNWG5X?=
 =?utf-8?B?a0VLUHZ5empVaHg3aFFjRlpvNHZIOGtqVkhaVkdHUnVlTUxSZFRoYncvbmE1?=
 =?utf-8?B?SkQ2L0ppZVJxV1NsbEo0Zz09?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 67be4b3d-c5e2-4ef7-9ef7-08db0f4c0b86
X-MS-Exchange-CrossTenant-AuthSource: TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 11:59:09.1484
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYYP286MB1620
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello William,

Are you sure changing driver is better than changing yaml bindings? All

previous version sent was syscon and sysreg seems not consistent with

other codes.

Best regards,

Shengyu

> Add documentation to describe StarFive designware mobile storage
> host controller driver.
>
> Signed-off-by: William Qiu <william.qiu@starfivetech.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>   .../bindings/mmc/starfive,jh7110-mmc.yaml     | 77 +++++++++++++++++++
>   1 file changed, 77 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/mmc/starfive,jh7110-mmc.yaml
>
> diff --git a/Documentation/devicetree/bindings/mmc/starfive,jh7110-mmc.yaml b/Documentation/devicetree/bindings/mmc/starfive,jh7110-mmc.yaml
> new file mode 100644
> index 000000000000..51e1b04e799f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/starfive,jh7110-mmc.yaml
> @@ -0,0 +1,77 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mmc/starfive,jh7110-mmc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: StarFive Designware Mobile Storage Host Controller
> +
> +description:
> +  StarFive uses the Synopsys designware mobile storage host controller
> +  to interface a SoC with storage medium such as eMMC or SD/MMC cards.
> +
> +allOf:
> +  - $ref: synopsys-dw-mshc-common.yaml#
> +
> +maintainers:
> +  - William Qiu <william.qiu@starfivetech.com>
> +
> +properties:
> +  compatible:
> +    const: starfive,jh7110-mmc
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    items:
> +      - description: biu clock
> +      - description: ciu clock
> +
> +  clock-names:
> +    items:
> +      - const: biu
> +      - const: ciu
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  starfive,sysreg:
> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> +    items:
> +      - items:
> +          - description: phandle to System Register Controller syscon node
> +          - description: offset of SYS_SYSCONSAIF__SYSCFG register for MMC controller
> +          - description: shift of SYS_SYSCONSAIF__SYSCFG register for MMC controller
> +          - description: mask of SYS_SYSCONSAIF__SYSCFG register for MMC controller
> +    description:
> +      Should be four parameters, the phandle to System Register Controller
> +      syscon node and the offset/shift/mask of SYS_SYSCONSAIF__SYSCFG register
> +      for MMC controller.
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - interrupts
> +  - starfive,sysreg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    mmc@16010000 {
> +        compatible = "starfive,jh7110-mmc";
> +        reg = <0x16010000 0x10000>;
> +        clocks = <&syscrg 91>,
> +                 <&syscrg 93>;
> +        clock-names = "biu","ciu";
> +        resets = <&syscrg 64>;
> +        reset-names = "reset";
> +        interrupts = <74>;
> +        fifo-depth = <32>;
> +        fifo-watermark-aligned;
> +        data-addr = <0>;
> +        starfive,sysreg = <&sys_syscon 0x14 0x1a 0x7c000000>;
> +    };