Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9950DC636CC for ; Wed, 15 Feb 2023 12:43:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233441AbjBOMnJ (ORCPT ); Wed, 15 Feb 2023 07:43:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229625AbjBOMnH (ORCPT ); Wed, 15 Feb 2023 07:43:07 -0500 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E3DD311CD; Wed, 15 Feb 2023 04:43:06 -0800 (PST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4PGyRD1rvYz4x4r; Wed, 15 Feb 2023 23:43:04 +1100 (AEDT) From: Michael Ellerman To: linuxppc-dev@lists.ozlabs.org, Andrew Donnellan , linux-integrity@vger.kernel.org Cc: bgray@linux.ibm.com, sudhakar@linux.ibm.com, gcwilson@linux.ibm.com, gregkh@linuxfoundation.org, stefanb@linux.ibm.com, npiggin@gmail.com, brking@linux.ibm.com, ruscur@russell.cc, joel@jms.id.au, linux-kernel@vger.kernel.org, zohar@linux.ibm.com, erichte@linux.ibm.com, gjoyce@linux.ibm.com, nayna@linux.ibm.com In-Reply-To: <20230210080401.345462-1-ajd@linux.ibm.com> References: <20230210080401.345462-1-ajd@linux.ibm.com> Subject: Re: [PATCH v6 00/26] pSeries dynamic secure boot secvar interface + platform keyring loading Message-Id: <167646488832.1421441.10975279847345153357.b4-ty@ellerman.id.au> Date: Wed, 15 Feb 2023 23:41:28 +1100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Feb 2023 19:03:35 +1100, Andrew Donnellan wrote: > This series exposes an interface to userspace for reading and writing > secure variables contained within the PowerVM LPAR Platform KeyStore > (PLPKS) for the purpose of configuring dynamic secure boot, and adds > the glue required to load keys from the PLPKS into the platform keyring. > > This series builds on past work by Nayna Jain[0] in exposing PLPKS > variables to userspace. Rather than being a generic interface for > interacting with the keystore, however, we use the existing powerpc > secvar infrastructure to only expose objects in the keystore used > for dynamic secure boot. This has the benefit of leveraging an > existing interface and making the implementation relatively minimal. > > [...] Applied to powerpc/next. [01/26] powerpc/pseries: Fix handling of PLPKS object flushing timeout https://git.kernel.org/powerpc/c/f74dcbfd27c647af9b7b83f3711c63712c677abd [02/26] powerpc/pseries: Fix alignment of PLPKS structures and buffers https://git.kernel.org/powerpc/c/fcf63d6b8ab9b12c2ce1b4bde12a3c391029c998 [03/26] powerpc/secvar: Fix incorrect return in secvar_sysfs_load() https://git.kernel.org/powerpc/c/c9fd2952754a03b2c14433c0318f4b46e9c0f2ef [04/26] powerpc/secvar: Use u64 in secvar_operations https://git.kernel.org/powerpc/c/53cea34b0a0a03568e189f8dfe2eb06f938986c8 [05/26] powerpc/secvar: Warn and error if multiple secvar ops are set https://git.kernel.org/powerpc/c/26149b02021158248b13e323f06372d87f076883 [06/26] powerpc/secvar: Use sysfs_emit() instead of sprintf() https://git.kernel.org/powerpc/c/16943a2faf94ef671e60c7577511c0d119fbdfc8 [07/26] powerpc/secvar: Handle format string in the consumer https://git.kernel.org/powerpc/c/ec2f40bd004b4b9142469282d4a6ce9afa22f9c0 [08/26] powerpc/secvar: Handle max object size in the consumer https://git.kernel.org/powerpc/c/e02407944052554c1685e11e56175147d1ac56b6 [09/26] powerpc/secvar: Clean up init error messages https://git.kernel.org/powerpc/c/caefd3b77450e330845755ea57add2315fd5e4d9 [10/26] powerpc/secvar: Extend sysfs to include config vars https://git.kernel.org/powerpc/c/86b6c0ae2caee9cadee1256d31b204ea54cb55c0 [11/26] powerpc/secvar: Allow backend to populate static list of variable names https://git.kernel.org/powerpc/c/50a466bf3e6f6f177dc0aeefa46a2f8927075a1d [12/26] powerpc/secvar: Warn when PAGE_SIZE is smaller than max object size https://git.kernel.org/powerpc/c/6d64c497a31bd888110785def44529ebb96bce49 [13/26] powerpc/secvar: Don't print error on ENOENT when reading variables https://git.kernel.org/powerpc/c/c96db155ebc6be868d5dde1b5caf6879c181cda4 [14/26] powerpc/pseries: Move plpks.h to include directory https://git.kernel.org/powerpc/c/90b74e305d6b5a444b1283dd7ad1caf6acaa0340 [15/26] powerpc/pseries: Move PLPKS constants to header file https://git.kernel.org/powerpc/c/3def7a3e7c2ce2ab5e5c54561da7125206851be4 [16/26] powerpc/pseries: Expose PLPKS config values, support additional fields https://git.kernel.org/powerpc/c/119da30d037dced29118fb90afe683ff50313386 [17/26] powerpc/pseries: Implement signed update for PLPKS objects https://git.kernel.org/powerpc/c/899d9b8fee66da820eadc60b2a70090eb83db761 [18/26] powerpc/pseries: Log hcall return codes for PLPKS debug https://git.kernel.org/powerpc/c/ebdcd42347157647ffe6c4d2808e4e5c146475d3 [19/26] powerpc/pseries: Make caller pass buffer to plpks_read_var() https://git.kernel.org/powerpc/c/0cf2cc1fe4e2e7a37da077cdd3fba5cfd9a6a36c [20/26] powerpc/pseries: Turn PSERIES_PLPKS into a hidden option https://git.kernel.org/powerpc/c/46b2cbebac1e862e4c8317aa26e7d7d632242c2f [21/26] powerpc/pseries: Clarify warning when PLPKS password already set https://git.kernel.org/powerpc/c/ca4f1d221c84fe364517b15af65f3f0e4ce9719a [22/26] powerpc/pseries: Add helper to get PLPKS password length https://git.kernel.org/powerpc/c/9ee76bd5c7e39b622660cc14833ead1967f2038d [23/26] powerpc/pseries: Pass PLPKS password on kexec https://git.kernel.org/powerpc/c/91361b5175d2b3704f7e436d0071893c839e1199 [24/26] powerpc/pseries: Implement secvars for dynamic secure boot https://git.kernel.org/powerpc/c/ccadf154cb00b9ee9618d209aa3efc54b35a34b4 [25/26] integrity/powerpc: Improve error handling & reporting when loading certs https://git.kernel.org/powerpc/c/3c8069b0c3832674abd80a5cf019c913e62de9a5 [26/26] integrity/powerpc: Support loading keys from PLPKS https://git.kernel.org/powerpc/c/4b3e71e9a34c48f370b6281e9477515d588e7b26 cheers