Date:   Wed, 15 Feb 2023 12:58:41 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Lucas Tanure <lucas.tanure@collabora.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Charles Keepax <ckeepax@opensource.cirrus.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        kernel@collabora.com
Subject: Re: [PATCH] ASoC: soc-dapm.h: fixup warning struct snd_pcm_substream
 not declared
Message-ID: <Y+zXAQHHhkPtjXZB@sirena.org.uk>
References: <20230215094643.823156-1-lucas.tanure@collabora.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="H4pdYQ3rNz1gxtj+"
Content-Disposition: inline
In-Reply-To: <20230215094643.823156-1-lucas.tanure@collabora.com>
Precedence: bulk


--H4pdYQ3rNz1gxtj+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 15, 2023 at 09:46:43AM +0000, Lucas Tanure wrote:
> Add sound/pcm.h header to include struct snd_pcm_substream used in
> snd_soc_dapm_update_dai function.

> +#include <sound/pcm.h>
> =20
>  struct device;
>  struct snd_soc_pcm_runtime;

This should be a forward declaration of the struct like the
adjacent forward declarations that are already there, we only
pass a pointer to it we don't need the contents.

--H4pdYQ3rNz1gxtj+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmPs1v4ACgkQJNaLcl1U
h9BmuQf/XGMHuzkuHa6g7NfdPJiXEc/2CMdz9QaXMWzdXCKriEHeZwvEBNDb5vbT
OTfHFHZT6SA2/b1xjFJNizc/EhG5bAf9VpYPKHeY5QzoaoXnK/LmnGaSz9bd3avi
stM3whRCQDFAv2MswJna4r/+oRWOssZbhv/2TjTCLi5pWca1LTm24sooqKG+g11w
NG+ooCEE2IquycBT56spysa0ds+Ekxkx9lwu5rJXmj5rg9QiWMQG+JlBhxA2BUrD
V3atTKZEL5IdLpGazmQFe7V/9wM4jDtnhSHMonapfX2fQ/TprcqjvJUwjy/9eXU3
cjKvJsorSjFww1TPSV1piq+s5x0syg==
=g84M
-----END PGP SIGNATURE-----

--H4pdYQ3rNz1gxtj+--