Date:   Wed, 15 Feb 2023 13:03:31 +0000
From:   Mark Brown <broonie@kernel.org>
To:     cy_huang@richtek.com
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        lgirdwood@gmail.com, u0084500@gmail.com,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: regulator: Add bindings for Richtek
 RT5739
Message-ID: <Y+zYIyaWt1tQcUt7@sirena.org.uk>
References: <1676426457-1389-1-git-send-email-cy_huang@richtek.com>
 <1676426457-1389-2-git-send-email-cy_huang@richtek.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Hi4zuMaYk07hpsnT"
Content-Disposition: inline
In-Reply-To: <1676426457-1389-2-git-send-email-cy_huang@richtek.com>
Precedence: bulk


--Hi4zuMaYk07hpsnT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Feb 15, 2023 at 10:00:56AM +0800, cy_huang@richtek.com wrote:

> +  richtek,vsel-active-high:
> +    description: |
> +      If property is present, use the 'VSEL1' register group for buck control.
> +      Else, use the 'VSEL0' register group. This depends on external hardware
> +      'VSEL' pin connecton.
> +    type: boolean

I would expect this to be GPIO controlled rather than fixed in
the design, at least for some systems?  The name suggests it's
supposed to control the polarity of a GPIO too.  Sadly we don't
really have good infrastructure for fixed GPIOs AFAIK...  ideally
this would be a GPIO and then if we need to hold it high then
there would be some binding we could connect to the GPIO that
says that.  We don't have that though so for now a fixed property
might be OK.

--Hi4zuMaYk07hpsnT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmPs2CIACgkQJNaLcl1U
h9AtKgf/XlyM1GvFkjJurb2mJomJyyUrwIiPKnK3wPdVOiQRXoTqtOm2gtnzWpKd
bmzHNfC/j+wEk+IhBoH8V38NNU/qsTMdJuerHk/0MU7xmEu6hY1A1uzBPlszjCtj
VEeiA7Bl0CDyhDz35/MVokIMmfkfCD4XWnVUvIXLDIWu5YFESxdyiZwGKlM1IrNb
cWFhjHF9aQ28aZUfxyI8d6dGXaA2CbAAEPOyYT32Uzc1S81PLYbvxhQDOPYVvTqQ
5yohkR0PvhqreklJiVLB47LYptQq4StNasbINAgVwWN4ZyEAc1q459VR33qQAI8c
6UsDoyMRgDGnbE/q8wO50q1we0hwMw==
=QkTn
-----END PGP SIGNATURE-----

--Hi4zuMaYk07hpsnT--