Date:   Wed, 15 Feb 2023 14:15:03 +0100
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     ChiYuan Huang <cy_huang@richtek.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        ChiaEn Wu <chiaen_wu@richtek.com>, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        peterwu.pub@gmail.com
Subject: Re: [Patch][next] dt-bindings: power: supply: Revise Richtek RT9467
 compatible name
Message-ID: <20230215131503.lnk7onzpsnxq5atb@mercury.elektranox.org>
References: <dc8873c3125f7aa6f84dc7b33a44bf00907e0814.1675853673.git.chiaen_wu@richtek.com>
 <20230213205321.xrhvrdqy5ksiagbv@mercury.elektranox.org>
 <75d37ae7-3632-a195-b12b-44e8a940be4a@linaro.org>
 <20230215033440.GA6570@linuxcarl2.richtek.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="3k3pldcpjihsbnrs"
Content-Disposition: inline
In-Reply-To: <20230215033440.GA6570@linuxcarl2.richtek.com>
Precedence: bulk


--3k3pldcpjihsbnrs
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, Feb 15, 2023 at 11:34:40AM +0800, ChiYuan Huang wrote:
> H, Krzysztof/Sebastian:
> On Tue, Feb 14, 2023 at 09:14:37AM +0100, Krzysztof Kozlowski wrote:
> > On 13/02/2023 21:53, Sebastian Reichel wrote:
> > > Hi,
> > >=20
> > > On Wed, Feb 08, 2023 at 11:14:24AM +0800, ChiaEn Wu wrote:
> > >> Revise RT9467 compatible name from "richtek,rt9467-charger" to
> > >> "richtek,rt9467"
> > >>
> > >> Fixes: e1b4620fb503 ("dt-bindings: power: supply: Add Richtek RT9467=
 battery charger")
> > >> Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com>
> > >> ---
> > >=20
> > > Is there a new version of this fixing the issues pointed out by Krzys=
ztof?
> > > Also I think the filename and $id should be changed to richtek,rt9467=
=2Eyaml
> > > in addition to the compatible change.
> >=20
> > Yes, indeed.
> >=20
> From the current discussion, there're things to be fixed.
> 1. In bindings, change compatible property from 'richtek,rt9467-charger' =
to 'richtek,rt9467'.
> 2. Rename 'richtek,rt9467-charger.yaml' to 'richtek,rt9467.yaml'
>
> Anything else? like as changing source code filename from from 'rt9467-ch=
arger.c' to 'rt9467.c"?

No, the source code can remain unchanged. But you also need to change
the $id line (line 4) in 'richtek,rt9467-charger.yaml' after renaming
file.

-- Sebastian

--3k3pldcpjihsbnrs
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmPs2soACgkQ2O7X88g7
+prtfhAAnsfReDwggQ6kbCNeAll0Sfl4BVg8e5HP8cO+f9PcGHrZ2QGRVw2qd53j
nruU1+a10OYZp7rqCCnXXfR2JdQyXedNCY6KafJ8QhUnkVX4mRi66YziXcPeAdRm
5hpcA8eOTY0aBsx9CvQA1XdA1MNyjtnaqmkQ2ZtRaTeSQnBHxb+GPbSqXwnn65LE
TM2Zu8Y9SUYkamywW5bcHOE2QXmOlbDimostnI9R5eaW/jIJ8yP2f1fKbg76BaJz
i4z4DY2QKdRN3FDsUD2Ukt8PkqokUbLfKeCqZQWUe7vGnu+dlUXPZJ2KtFsvGcyN
qW15tbqKKpTsFQcLoqRw15Cv7//+g13vTz1tiFO8pPbuPsCgr9Y3pgE9qLJz/ODM
OmiC57nSG1QEpCWrld+45vA6j4CNYsTwf8wTqU/CLHMQWMTzpsARBRSHX9npXv+b
qWlF6m2mFZVhFwcdFE2ueI3p9vvDQ5J4A5epPUbXsumCBHVVWh2Y3WMWzLbRxQx5
+1t36bQ9G/s3XjT/i00GYl9KbCNCchySoMhHASlaG0dsB3X5kq1fNuzxlRyQiQcl
Bwxj3E8yI09zwbJQO19ayMlnVrh2jTDBjrtoSdkll04jFUOdVYDZZv/emX599gzN
hnCqTKL3pHy0Du+1g6mD+eD0o4yPE7WigBzSl7HGmbEfPHp5yBE=
=JKHO
-----END PGP SIGNATURE-----

--3k3pldcpjihsbnrs--