Date:   Wed, 15 Feb 2023 15:26:35 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Werner Sembach <wse@tuxedocomputers.com>
Cc:     mika.westerberg@linux.intel.com, linus.walleij@linaro.org,
        brgl@bgdev.pl, linux-gpio@vger.kernel.org,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        mario.limonciello@amd.com, alexander.deucher@amd.com
Subject: Re: [PATCH v3] gpiolib: acpi: Add a ignore wakeup quirk for Clevo
 NH5xAx
Message-ID: <Y+zdi5GTO6Mdhldn@smile.fi.intel.com>
References: <20230214125810.10715-1-wse@tuxedocomputers.com>
 <Y+y4ycHtPkABr/Ia@smile.fi.intel.com>
 <d08e2305-92ba-15e2-398b-b495ed294f1c@tuxedocomputers.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d08e2305-92ba-15e2-398b-b495ed294f1c@tuxedocomputers.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Feb 15, 2023 at 12:59:46PM +0100, Werner Sembach wrote:
> Am 15.02.23 um 11:49 schrieb Andy Shevchenko:
> > On Tue, Feb 14, 2023 at 01:58:10PM +0100, Werner Sembach wrote:
> > > commit 1796f808e4bb ("HID: i2c-hid: acpi: Stop setting wakeup_capable")
> > > changed the policy such that I2C touchpads may be able to wake up the
> > > system by default if the system is configured as such.
> > > 
> > > However for some devices there is a bug, that is causing the touchpad to
> > > instantly wake up the device again once it gets deactivated. The root cause
> > > is still under investigation:
> > > https://lore.kernel.org/linux-acpi/2d983050-f844-6c5e-8ae9-9f87ac68dfdd@tuxedocomputers.com/T/#mb2e738787f6b6208d17b92aa6e72d4de846d4e4d
> > Bart, I'm fine if it goes directly via your tree, or I can send it in usual
> > bundle of fixes after rc1 (however it seems this deserves to make v6.2).
> Just realized i did not add cc stable:
> 
> It is required for 6.1 also.

We have at least the following options:
- you can send specific request for stable after it becomes a part of upstream
- you can send a v4 with it

> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > 
> > > To workaround this problem for the time being, introduce a quirk for this
> > > model that will prevent the wakeup capability for being set for GPIO 16.

-- 
With Best Regards,
Andy Shevchenko