Date:   Wed, 15 Feb 2023 15:14:51 +0100
From:   Larysa Zaremba <larysa.zaremba@intel.com>
To:     Oleksij Rempel <o.rempel@pengutronix.de>
CC:     Andrew Lunn <andrew@lunn.ch>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "Paolo Abeni" <pabeni@redhat.com>, Wei Fang <wei.fang@nxp.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        <kernel@pengutronix.de>, <linux-kernel@vger.kernel.org>,
        <netdev@vger.kernel.org>, Shenwei Wang <shenwei.wang@nxp.com>,
        Clark Wang <xiaoning.wang@nxp.com>,
        NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [PATCH net-next v1 7/7] net: fec: add support for PHYs with
 SmartEEE support
Message-ID: <Y+zo2+oaFe9lvVA6@lincoln>
References: <20230214090314.2026067-1-o.rempel@pengutronix.de>
 <20230214090314.2026067-8-o.rempel@pengutronix.de>
 <Y+uMDEyWW15gerN0@lunn.ch>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y+uMDEyWW15gerN0@lunn.ch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ne2e1+yn3TQKDLfuI1/Opcl4vMgVALjDCbXsVquTiM3PQqHAH/EjP+7fNGny?=
 =?us-ascii?Q?C9tCqsJSJDzz58hRg4+U4PjGt/Ql6UwldWveeQKCzYFmC5//hlwQw3FPvjg7?=
 =?us-ascii?Q?p6rtZJ+u8UavwrnJsCO+GAQ99K58FpdkOPeJOO2G5rR/JR3LL9aW+ydsRFhm?=
 =?us-ascii?Q?rTa0GPJo3/dwXTrQ2hlwFQATY4fF9OVCT1zZHK/xz5r/s8Kx9EHBvY57BMVc?=
 =?us-ascii?Q?2MviVBbZp/ysFeuh46VwdeW8uwN2OJWh+qniWF2YuMjcR4d5nFsE/Vmv8d2f?=
 =?us-ascii?Q?YHcpKMVyz0izs2HblUiUAz6+/mU0pJ0uVWlZKwJwWIme2zrMZEcGXMqJD6YT?=
 =?us-ascii?Q?xSaiBI/G/RsiU28sfNSYLV+zXb+A4ScSP/jIXmoxUH+xyNgcUICrIxKJtvNB?=
 =?us-ascii?Q?QftcbG0/wKf6qf8NFAttTWgitMMglYosqIkW5JMgHDesDOHfkAebumpXJX70?=
 =?us-ascii?Q?3bLCul7ybSQdDa+Uha5WdRhAXbOb7YZznf/4zuJCQ7gY0xWgYquUD6SDIHat?=
 =?us-ascii?Q?4n6PbqYAxz84tzSx9wKarxyUk96xwDfbVqatJ2uasRt9M2Yw5i/MjOXJkR0r?=
 =?us-ascii?Q?zBXTA8pnpA0iXHEtRa9ji79aHpzHGKAb+W+kFuogVNTcfp+bSo4zFOO+pnUM?=
 =?us-ascii?Q?zECRDSEQWlg48IxXtxwDHxQ+ZaVvbj+ksAzbdgcJCxxKHu6IqGI7oGopK3p4?=
 =?us-ascii?Q?NZnX+wNFFnLaOGYUqvHbnL9OEttV4Xw8VYKctIjDDRfSPeCwR5N1XKsp5DEr?=
 =?us-ascii?Q?hdOKyl85Pq55TFTd2i+Q1Yz9pfaKwU3O+HVAHMfn8GmzTbARnCMfd8uSyYGM?=
 =?us-ascii?Q?0QbL1Y65q8viVqaGvUIVGByehDfO5h1MbQ7tKB7ShdmGnBIamNTYFKpEx7VO?=
 =?us-ascii?Q?GRwHz1uOTJvIB1LnukqYX+kv1zEz1+Rv0O5mrld6X0igpLLIT0YEVTFq/41v?=
 =?us-ascii?Q?uRpbX04WY/hw3spwNTBup48Zh5PL8d3whi8V4m4wzM5PDSCgONyPoRk62VSV?=
 =?us-ascii?Q?WWKxBXrl+Z0v49F3O8w9Z03/iPDnPVKnsjWjQPiZRm6eGt6D5deogKqHyd//?=
 =?us-ascii?Q?cTuWsMCJHg3JLa20HsRlikl2Y3zZY5qK79/TglsUsva7Q9k07hbx4KyugGDq?=
 =?us-ascii?Q?FRealzOJwn7UEzhSrLlUKU+yA0yChAxcQKa/sGmYB1jFiiVqrbkf8NEb5yNy?=
 =?us-ascii?Q?syrHsJ8zWGJfYE+s055T6orIKgIdcQ4OMhAC90zkkcHxt5LOu1N/6SFwFmC7?=
 =?us-ascii?Q?U1ek/1KVCBRee58FITea6NyjeHwR+wOIOvgpLEIQhq65hW8G2rJ1bxpuLxR5?=
 =?us-ascii?Q?uOLOwmYCDtbUUp3WiItaO1Pz10hLVmFc+A1XcT+t9LGsMfFRlyjW9OjmNb8N?=
 =?us-ascii?Q?300IiXSLiv9LegBPRBi7xN0Fx3fdLo6SCkFxspKQ6c5FVnoSFNcmlS7Pg9ZG?=
 =?us-ascii?Q?OVQUCsD4PF+qdmTEcquOW+KMLWTPAPfaF5Rzygt6omDl3MSUi31rE2miRWIM?=
 =?us-ascii?Q?YpsLQi+B6zT9WA5fGV1duTajE6BuETB3rsBwMaNnuAjzXNvopHlxOrG7QzGx?=
 =?us-ascii?Q?m6+BLQbd4lcagZgBMmCAid8LTtR+MlQresqNnHlIhvNoRhFoeaB63/dF8j9N?=
 =?us-ascii?Q?mw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d8d7007b-657e-411b-078c-08db0f618d9d
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5471.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 14:33:06.6898
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: p3ksK8pcUlZIVgxYkaqpfXkSXttlrLY6HBN1Jyb8KdKBukhpDGqyQbUNbqYs0qilTQU0t7qW/BjK0yK1slliEfa0HKZqBNZS1Gwbp3I8rbk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4574
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 14, 2023 at 02:26:36PM +0100, Andrew Lunn wrote:
> On Tue, Feb 14, 2023 at 10:03:14AM +0100, Oleksij Rempel wrote:
> > Ethernet controller in i.MX6*/i.MX7* series do not provide EEE support.
> > But this chips are used sometimes in combinations with SmartEEE capable
> > PHYs.
> > So, instead of aborting get/set_eee access on MACs without EEE support,
> > ask PHY if it is able to do the EEE job by using SmartEEE.
> > 
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> >  drivers/net/ethernet/freescale/fec_main.c | 22 ++++++++++++++++++----
> >  1 file changed, 18 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> > index c73e25f8995e..00f3703db69d 100644
> > --- a/drivers/net/ethernet/freescale/fec_main.c
> > +++ b/drivers/net/ethernet/freescale/fec_main.c
> > @@ -3102,8 +3102,15 @@ fec_enet_get_eee(struct net_device *ndev, struct ethtool_eee *edata)
> >  	struct fec_enet_private *fep = netdev_priv(ndev);
> >  	struct ethtool_eee *p = &fep->eee;
> >  
> > -	if (!(fep->quirks & FEC_QUIRK_HAS_EEE))
> > -		return -EOPNOTSUPP;
> > +	if (!(fep->quirks & FEC_QUIRK_HAS_EEE)) {
> > +		if (!netif_running(ndev))
> > +			return -ENETDOWN;
> > +
> > +		if (!phy_has_smarteee(ndev->phydev))
> > +			return -EOPNOTSUPP;
> > +
> > +		return phy_ethtool_get_eee(ndev->phydev, edata);
> > +	}
> 
> I can see two different ways we do this. As you have here, we modify
> every MAC driver which is paired to a SmartEEE PHY and have it call
> into phylib. Or we modify the ethtool core, if it gets -EOPNOTSUPP,
> and there is an ndev->phydev call directly into phylib. That should
> make all boards with SmartEEE supported. We do this for a few calls,
> TS Info, and SFP module info.
> 
> Either way, i don't think we need phy_has_smarteee() exposed outside
> of phylib. SmartEEE is supposed to be transparent to the MAC, so it
> should not need to care. Same as WOL, the MAC does not care if the PHY
> supports WoL, it should just call the APIs to get and set WoL and
> assume they do the right thing.
> 
> What is also unclear to me is how we negotiate between EEE and
> SmartEEE. I assume if the MAC is EEE capable, we prefer that over
> SmartEEE. But i don't think i've seen anything in these patches which
> addresses this. Maybe we want phy_init_eee() to disable SmartEEE?
> 
> 	  Andrew

I agree with the attitude that we shouldn't expect legacy MAC driver to handle 
fancy features of PHY, so modifying core code instead of driver code would be a 
much better solution.

Also, I too would like to see the case when both MAC EEE and SmartEEE are 
enabled, to be prevented or acknowledged, if it's actually useful for something.

Other than that, patchset look fine to me, so in v2, you can put my Reviewed-By 
(Larysa Zaremba <larysa.zaremba@intel.com>) under any of the previous patches 
which stay unchanged (except the 4th one, you have to correct 'specifica'
in the title).