Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69CD4C636D4 for ; Wed, 15 Feb 2023 14:37:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229760AbjBOOhY (ORCPT ); Wed, 15 Feb 2023 09:37:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229550AbjBOOhX (ORCPT ); Wed, 15 Feb 2023 09:37:23 -0500 Received: from srv6.fidu.org (srv6.fidu.org [IPv6:2a01:4f8:231:de0::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9926B27481; Wed, 15 Feb 2023 06:37:20 -0800 (PST) Received: from localhost (localhost.localdomain [127.0.0.1]) by srv6.fidu.org (Postfix) with ESMTP id 8840AC8009E; Wed, 15 Feb 2023 15:37:18 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at srv6.fidu.org Received: from srv6.fidu.org ([127.0.0.1]) by localhost (srv6.fidu.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Wn5GFcbnWkqU; Wed, 15 Feb 2023 15:37:18 +0100 (CET) Received: from [192.168.176.165] (host-88-217-226-44.customer.m-online.net [88.217.226.44]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: wse@tuxedocomputers.com) by srv6.fidu.org (Postfix) with ESMTPSA id B4607C8009A; Wed, 15 Feb 2023 15:37:17 +0100 (CET) Message-ID: Date: Wed, 15 Feb 2023 15:37:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3] gpiolib: acpi: Add a ignore wakeup quirk for Clevo NH5xAx Content-Language: en-US To: Andy Shevchenko Cc: mika.westerberg@linux.intel.com, linus.walleij@linaro.org, brgl@bgdev.pl, linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, mario.limonciello@amd.com, alexander.deucher@amd.com References: <20230214125810.10715-1-wse@tuxedocomputers.com> From: Werner Sembach In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 15.02.23 um 14:28 schrieb Andy Shevchenko: > On Wed, Feb 15, 2023 at 03:26:36PM +0200, Andy Shevchenko wrote: >> On Wed, Feb 15, 2023 at 12:59:46PM +0100, Werner Sembach wrote: >>> Am 15.02.23 um 11:49 schrieb Andy Shevchenko: >>>> On Tue, Feb 14, 2023 at 01:58:10PM +0100, Werner Sembach wrote: >>>>> commit 1796f808e4bb ("HID: i2c-hid: acpi: Stop setting wakeup_capable") >>>>> changed the policy such that I2C touchpads may be able to wake up the >>>>> system by default if the system is configured as such. >>>>> >>>>> However for some devices there is a bug, that is causing the touchpad to >>>>> instantly wake up the device again once it gets deactivated. The root cause >>>>> is still under investigation: >>>>> https://lore.kernel.org/linux-acpi/2d983050-f844-6c5e-8ae9-9f87ac68dfdd@tuxedocomputers.com/T/#mb2e738787f6b6208d17b92aa6e72d4de846d4e4d >>>> Bart, I'm fine if it goes directly via your tree, or I can send it in usual >>>> bundle of fixes after rc1 (however it seems this deserves to make v6.2). > Actually we have yet another little fix. So maybe I can create a tagged bundle. > Perhaps v4 will be the best option here. on it > >>> Just realized i did not add cc stable: >>> >>> It is required for 6.1 also. >> We have at least the following options: >> - you can send specific request for stable after it becomes a part of upstream >> - you can send a v4 with it >> >>>> Reviewed-by: Andy Shevchenko >>>> >>>>> To workaround this problem for the time being, introduce a quirk for this >>>>> model that will prevent the wakeup capability for being set for GPIO 16.