Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3552C636D4 for ; Wed, 15 Feb 2023 15:44:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229728AbjBOPoJ (ORCPT ); Wed, 15 Feb 2023 10:44:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbjBOPoG (ORCPT ); Wed, 15 Feb 2023 10:44:06 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31EAE39CEA for ; Wed, 15 Feb 2023 07:43:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676475792; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PMqJa7q0H8qVEbf7pymm/2XGZiQOArn54qlyx+FXazM=; b=ZTK/0vYqp+pu9hUDfNawifAT76mb5L0TJxbLQ++DQ8qv5o1CbMUd6cfdGfPMluGwx/Bi9E RbDSdILiXUx5VKLtRwldyxUfudtqvNQM3a/9K/rJ/+/VRxNSeYU86Sq7SoZvxkeA+DlrAh ikp78pkY2tLCXhq10q9DAVrPfttXs1E= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-147-AWjaTIU5MtiuWFLkfmFwMA-1; Wed, 15 Feb 2023 10:43:08 -0500 X-MC-Unique: AWjaTIU5MtiuWFLkfmFwMA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 81797100F911; Wed, 15 Feb 2023 15:43:06 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 486ED40CF8EA; Wed, 15 Feb 2023 15:43:04 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <867e1e3e-681b-843b-1704-effed736e13d@kernel.dk> <20230214171330.2722188-1-dhowells@redhat.com> <2877092.1676415412@warthog.procyon.org.uk> <2895995.1676448478@warthog.procyon.org.uk> To: Christoph Hellwig Cc: dhowells@redhat.com, Jens Axboe , smfrench@gmail.com, Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v14 00/17] iov_iter: Improve page extraction (pin or just list) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3370185.1676475783.1@warthog.procyon.org.uk> Date: Wed, 15 Feb 2023 15:43:03 +0000 Message-ID: <3370186.1676475783@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph Hellwig wrote: > And who is using filemap_splice_read directly anyway? I can't find a > modular user in any of the branches. Fair point. I have a subset of the patches on my iov-cifs branch that doesn't make the change to generic_file_read_splice(), but rather does that bit in cifs.ko - that does require access to filemap_splice_read(). David