Message-ID: <0a479141-7887-462a-b154-bcb8881b43c2@intel.com>
Date:   Wed, 15 Feb 2023 16:58:05 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH net] ipv6: Add lwtunnel encap size of all siblings in
 nexthop calculation
Content-Language: en-US
To:     David Ahern <dsahern@kernel.org>
CC:     Lu Wei <luwei32@huawei.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230214092933.3817533-1-luwei32@huawei.com>
 <d5f2c46c-cf68-3ec9-ec87-f6748ede1d1f@intel.com>
 <c5e3cf7c-1a94-4929-5691-9ccb4c7a194b@kernel.org>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <c5e3cf7c-1a94-4929-5691-9ccb4c7a194b@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VTBpYkU0TlRJdEtOb3dIODk5Ui9PYnNXOGJHZlV2Sjhsb2VvU3BrS2xXc3Mv?=
 =?utf-8?B?UlFZRjdUWVBtN045UHJMWmZ2Rm90dTlxZWdlL05veExIdDhNOU5rWkRiQTgy?=
 =?utf-8?B?MTI5dEtTNTVITlNwZlVCVjR3bFA2NEpUTlIzL2s2R0FYWlQ2T2VpMXZYamwr?=
 =?utf-8?B?NFM0YlBKb3ZPTjk0K01XQk4vNEkzRmZGU0hOa2MwaHRKaTMxUHAwV2pDRC91?=
 =?utf-8?B?QkI1alN6YXJHdEE2V3JKWW5xak5KRjJwK2JzRkduUm80d3VCSENOY1Niaklk?=
 =?utf-8?B?M3RjS2pqQnpWcGxtVkEwVWZXUWJNM0l3MnVRZWdsVklvUEpPRTd2RWxOY2Jz?=
 =?utf-8?B?Z2Jmb1FZbW44QXRaQWpoVS82YUI1Y2I2VGJLNmliRW9Fd3ZkS0JKNWdEQURy?=
 =?utf-8?B?M1YxNlJuLy9mandKay9YUHpSRzBERE1SYWZrNlNwQnAvQ05FaktIWllNc0FV?=
 =?utf-8?B?NFZ3N2szU2IvNGF5ZzZPTXZnWmpmakJJQmxTSmN1T0pkdFVtY1NDcTEyV0Z0?=
 =?utf-8?B?cGc3WXhhWk5YY3AyMWtDaGErRFI4b0xKOE5IYW9BU1ZjVGxkdXZ5SDNhQTJU?=
 =?utf-8?B?SC9URUs2dTlEOGtQU0dFNEt0eDQ0S2ZlS3NTWnlCK24rbmhCRUpQVUdCV1pI?=
 =?utf-8?B?ZWdBVmg0dkdOUWgxall3U3JvNHhvRVFVVytaRHFsdG03NzRXdGV3VEhoWVk4?=
 =?utf-8?B?dmRRVGtJYnRTMnVYaFM4K3hSRDY1eWNkU290c2hlMnJCd0VvbnczeGZEWEFG?=
 =?utf-8?B?TlcyU3NJdkpGRVNYWTVxSW1XQVBuaTcyY1J3bHh1U2pNTVgrMlVZR0FGMmd1?=
 =?utf-8?B?YS8yRUxIb3Zwd1BLNHNadW9vOVJLZHVWMmNVRVJQL2hSVGZ0cmVtTFJhT25K?=
 =?utf-8?B?WmxQWExDeTVPWDRja2JlRWVWOVYwS3hDZ1NTOTZ3UUJhM3ZRN2FHQjA0UWo1?=
 =?utf-8?B?VkZ6cDBTU2dGSnFncGVuYmEyaGlUbExxbWFqOTFCK0twQTBjam5zazFpbDY5?=
 =?utf-8?B?VjNoTVJFclJBajNMSnRZR0RpRmxIcXBjUGlmT2JxeG83bmwvdG1NTlZyM1pp?=
 =?utf-8?B?RnVZWm1xb3ZVS3o3ZEFHa3RkWGloeFB2amtSU0MxVkV3eUhrYXFObG9LVnp6?=
 =?utf-8?B?S3ZqaTJSK2JqOStNTWpJSk1EVC9LSmNKVEwxS25HZFp4dVpQNlVSMFFQdFV2?=
 =?utf-8?B?U1FzR1EvZFNpekgxSUhBYzlvUE5sb2ZId3NpQXRUbUpXRTZYSmJDLzJBV3Rq?=
 =?utf-8?B?WXRsalZ5SngxWGt0TEZZQXZWblA3TEJSdFZJSmVmMjB6cExXMEtMcFJSQmV6?=
 =?utf-8?B?OG1oZ1JlM204YTd4L1FzdHh3R21zV2NEbzNGYnI4T3FNZkN0dVB2azNSM1dR?=
 =?utf-8?B?cjRUaUhsSy8zRlJmK1JGMStHbzVFQmU2U3p0UDJjNG1oZEYvL3YwRzFrNWpV?=
 =?utf-8?B?NE9ra0Z1Z0lzQWRSazFKdFdKd1h4aHozRVBTV1VqVzc4QmFRM3lkK2c5MnA4?=
 =?utf-8?B?RTVnRCtyS3c3WDUydWplRURRd2RVdlo1WnlpL0tVeG1CTUM3Tmg0TEczenRZ?=
 =?utf-8?B?YWhTbFRaN2lzZm9ObEVsdTFQR0YvMkluYU1UR1U2NUFpRW5uYUhmU3NCUTZq?=
 =?utf-8?B?Y0hwYWtyVWQ4SWlNbjArdzRwdUVSWXd2dGY0UWxFcVQ3Tlg4eUdqNDhyTTdR?=
 =?utf-8?B?K3Jjb05HZzhjcFA5dU9mV2htTitrUjdLMnJyT09xZTFKcDZGQkR0alBtN1Ns?=
 =?utf-8?B?eTY4YWxhTTVQVmdFeURzYWRYQ3dGMWplbEN6SkVNbGl0Sk5XSTNwZ0duYVNR?=
 =?utf-8?B?YXBnUDB2WG5jNENoRXVVcXRMK1B1WWZEWHE4VEVxZFdFeDNoZkJIMmgxeUV1?=
 =?utf-8?B?NmFKaHE3UHBHOGZueFVsNjU5YXNFNU82elR0QWdMblZQQ0Q3bEV4dE1jWnh0?=
 =?utf-8?B?VmdUTFE2WWVna0VSWnRzMVdUS21lL29nWndXdEpnRUlzQ3lUMVVVaklNWVhL?=
 =?utf-8?B?OXFURTQyUVJhOCtOdXNrN0FmbVBtUVNRUEZNOVBGdDFlejJRYXRFcFhNU2pP?=
 =?utf-8?B?QkxhYzFmYWU5T2M4bVFucmttN2YwaktsOGUvdVJaczVOaE1IZWhaZGJlWDZP?=
 =?utf-8?B?K09yUDNnSGJteFhrdEpmWnA4TEsraFNBd25iUkE1ZjF0d3QvYUlEMUlwQW5i?=
 =?utf-8?Q?RbdVH4d9Bf0+BE19jd3H+e8=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b85e5aa-9487-4bbd-3be5-08db0f6d9cb6
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 15:59:26.0753
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Rs52fDxSCUyK8iCTihSqYZKcqqS8+4kf7NJe8awf2l5h4lNr4/0ufmMqDw8fQ3VdVH0ShqqK6klhdN1ZdAi56fQFvXbeYzrzLzUyV5vA/Q0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7216
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: David Ahern <dsahern@kernel.org>
Date: Tue, 14 Feb 2023 11:11:04 -0700

> On 2/14/23 10:39 AM, Alexander Lobakin wrote:
>>> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
>>> index e74e0361fd92..a6983a13dd20 100644
>>> --- a/net/ipv6/route.c
>>> +++ b/net/ipv6/route.c
>>> @@ -5540,16 +5540,17 @@ static size_t rt6_nlmsg_size(struct fib6_info *f6i)
>>>  		nexthop_for_each_fib6_nh(f6i->nh, rt6_nh_nlmsg_size,
>>>  					 &nexthop_len);
>>>  	} else {
>>> +		struct fib6_info *sibling, *next_sibling;
>>>  		struct fib6_nh *nh = f6i->fib6_nh;
>>>  
>>>  		nexthop_len = 0;
>>>  		if (f6i->fib6_nsiblings) {
>>> -			nexthop_len = nla_total_size(0)	 /* RTA_MULTIPATH */
>>> -				    + NLA_ALIGN(sizeof(struct rtnexthop))
>>> -				    + nla_total_size(16) /* RTA_GATEWAY */
>>> -				    + lwtunnel_get_encap_size(nh->fib_nh_lws);
>>> +			rt6_nh_nlmsg_size(nh, &nexthop_len);
>>>  
>>> -			nexthop_len *= f6i->fib6_nsiblings;
>>> +			list_for_each_entry_safe(sibling, next_sibling,
>>> +						 &f6i->fib6_siblings, fib6_siblings) {
>>> +				rt6_nh_nlmsg_size(sibling->fib6_nh, &nexthop_len);
>>> +			}
>>
>> Just a random nitpick that you shouldn't put braces {} around oneliners :D
>>
> 
> I believe there can be exceptions and braces make multiple lines like
> that more readable.

Hmm, you know, agree for this one, that for-loop line break changes
things a bit.

Thanks,
Olek