Date:   Wed, 15 Feb 2023 17:36:07 +0100
From:   Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To:     Veerasenareddy Burru <vburru@marvell.com>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <aayarekar@marvell.com>, <sedara@marvell.com>,
        <sburla@marvell.com>, <linux-doc@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next v3 5/7] octeon_ep: support asynchronous
 notifications
Message-ID: <Y+0J94sowllCe5Gs@boxer>
References: <20230214051422.13705-1-vburru@marvell.com>
 <20230214051422.13705-6-vburru@marvell.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230214051422.13705-6-vburru@marvell.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/HZnGOocOB2wSOgTis5AbzTHsZF6pAH95EaJIs+dyFc4KMP5vNVIuVCl0frO?=
 =?us-ascii?Q?djiUSdsFaD9NB3QU892r23VfIlYn0UhKM/6rNe8fXlwcHglQ23lHuEN2Jka1?=
 =?us-ascii?Q?SYvGL7c5g3Ib5Ed9s9pAx9Q+hhVPOu1/ddcTpb+T+mT/EaIsOPj1C9VBef6K?=
 =?us-ascii?Q?Od4cBEtwlENQpXra9gKJhpTlud3vZOP8d3j+k8lzwK2+ryaFIj5HbH3J4rL1?=
 =?us-ascii?Q?CLWFXPJCNouIEqlUesvqE/YoqP4sS6CNAhlBI7gGcXdoOTtoDxzH+5Yikb8B?=
 =?us-ascii?Q?jGckfOStNp9lWrhuDrtGXrf1vCvISfOo+gqGhJE1prDofma18YqESHjsnbVl?=
 =?us-ascii?Q?AYPw9dkWw+NbkxUfBCu7057MyLRxAa7mHeCvFd/OWrQgBkFIFK9L+gC+buVD?=
 =?us-ascii?Q?FtfRahLXvAtN9f918azLObn5jgw6IbyVUJil9o/SmlgZuPNU1SJJwUVm3nXY?=
 =?us-ascii?Q?3AiC/xSF9smN7xcQ/n73TnIqDzzE0LpUbQDKemFWsVRhI3a2zo6M26KZLuNy?=
 =?us-ascii?Q?i7eGVRpTs7UGAM+OGO7Q0xRJv84cT0baQvk3kn5vH86eB/p+u6wHZqWe9kxW?=
 =?us-ascii?Q?q819Sb3ErwQ3D7sunOyvTntjuupJWly/n2O9uIC15qP4zz8LgXoSTsVtnxdA?=
 =?us-ascii?Q?eZHdxPM4d1IfqRzO0lS1xy7LgVUJzZF4Bp7a2YEyM83Sg/xsV4jpN4/3m+q7?=
 =?us-ascii?Q?/LWnXBp92kMcUyH5fEp2n6gfelo34pPah08VmyZueZaUHM+buD2i0yVxKWZv?=
 =?us-ascii?Q?uowB1G8tYCWJR6DZ5vFvXZ2IVSwHcetM6CyVFB+DGkWQPcr+viR1uHr1eBJW?=
 =?us-ascii?Q?KFqIM17yuYOpd5JKZB1N696NjWDV54pz/PbSWdObqUWYM8npClQ7o2vF9aRo?=
 =?us-ascii?Q?rebEYKM56VUoObE4gR1OADVpCODAsYedi93htDCa06UirXUl4yRSalS5iaDq?=
 =?us-ascii?Q?0re5IbQrErjB+mQxJh35So0eJsiWiGTNFAjVlyhe7urIjijP9h1Sf4koYfgK?=
 =?us-ascii?Q?Asawda1t6WzT4XoNRlsOoYGxfbv+JgF46ip9MKrofG1Fs8Z7uVeP4N3D9A1o?=
 =?us-ascii?Q?DZlW+f2MyjpD6kTxRdRaHKBgh/yw+VStYvfdbSWARhAA/x2ogHXxTYS0yV1J?=
 =?us-ascii?Q?rTFOiB1h3ShRxV0jGxa9xWOI50OsmvtQF0Vrv/CKd17I2q9iYzd9qK/As3o6?=
 =?us-ascii?Q?2S66iKSDh+hpMLqbhf0bPrhxd3mQNNBHDjlA95aW5h4FLTQBpTX3byef/5/S?=
 =?us-ascii?Q?mSsH7rtdJ9kpJc5PM1BUHmrb4MVBmS2LxAvA3Ev4G39CdfrsPgkixak/4XJ/?=
 =?us-ascii?Q?c6E+7C1KecmZr4OE/AXaDltUICIqzkWCv2ba09LSe96M5EpNgn1AOHnozmRL?=
 =?us-ascii?Q?PNueh/VcQmc6cSJiLKq7Dp/SNplm46XVtcHQD+X5SO3Dx4gyCYXrk/rh7YyP?=
 =?us-ascii?Q?g6E+Dz3DgYiANeDWyEyEyoUzkwdv5AFDkkjIucYKyOE9lKuycoPIeMCUH/LT?=
 =?us-ascii?Q?LcrlkELV6i97mUrX4yzngOPKHYWFZF3wVkU1xELxfHI4chb+qRPXDjM+N2UN?=
 =?us-ascii?Q?BPRPh3c+cORZ7KWhpUmJk03NHrHJ9nbvuMeKN/cLbIWNxzLHeOI1N3r5hjF+?=
 =?us-ascii?Q?BNL/QGtuekLkId7MkwsKX04=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f17b406d-ef5b-4c72-eae0-08db0f72c8f8
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 16:36:27.7064
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lT56QruPjqo8GAY+wQpD5GdNcno+oRvwz2aW3ABlv9H0bmJzXGehGtuaoJ/5GzMc0hy92J6UrSzGC56JHe1lw65uLoPZkVLHCtTvvLjNAWA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5459
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 13, 2023 at 09:14:20PM -0800, Veerasenareddy Burru wrote:
> Add asynchronous notification support to the control mailbox.
> 
> Signed-off-by: Veerasenareddy Burru <vburru@marvell.com>
> Signed-off-by: Abhijit Ayarekar <aayarekar@marvell.com>
> ---
> v2 -> v3:
>  * no change
> 
> v1 -> v2:
>  * no change
> 
>  .../marvell/octeon_ep/octep_ctrl_net.c        | 29 +++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c b/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
> index 715af1891d0d..80bcd6cd4732 100644
> --- a/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
> +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
> @@ -279,6 +279,33 @@ static int process_mbox_resp(struct octep_device *oct,
>  	return 0;
>  }
>  
> +static int process_mbox_notify(struct octep_device *oct,

void

> +			       struct octep_ctrl_mbox_msg *msg)
> +{
> +	struct octep_ctrl_net_f2h_req *req;
> +	struct net_device *netdev = oct->netdev;

RCT

> +
> +	req = (struct octep_ctrl_net_f2h_req *)msg->sg_list[0].msg;
> +	switch (req->hdr.s.cmd) {
> +	case OCTEP_CTRL_NET_F2H_CMD_LINK_STATUS:
> +		if (netif_running(netdev)) {
> +			if (req->link.state) {
> +				dev_info(&oct->pdev->dev, "netif_carrier_on\n");
> +				netif_carrier_on(netdev);
> +			} else {
> +				dev_info(&oct->pdev->dev, "netif_carrier_off\n");
> +				netif_carrier_off(netdev);
> +			}
> +		}
> +		break;
> +	default:
> +		pr_info("Unknown mbox req : %u\n", req->hdr.s.cmd);
> +		break;
> +	}
> +
> +	return 0;
> +}
> +
>  int octep_ctrl_net_recv_fw_messages(struct octep_device *oct)
>  {
>  	static u16 msg_sz = sizeof(union octep_ctrl_net_max_data);
> @@ -303,6 +330,8 @@ int octep_ctrl_net_recv_fw_messages(struct octep_device *oct)
>  			process_mbox_req(oct, &msg);
>  		else if (msg.hdr.s.flags & OCTEP_CTRL_MBOX_MSG_HDR_FLAG_RESP)
>  			process_mbox_resp(oct, &msg);
> +		else if (msg.hdr.s.flags & OCTEP_CTRL_MBOX_MSG_HDR_FLAG_NOTIFY)
> +			process_mbox_notify(oct, &msg);
>  	}
>  
>  	return 0;
> -- 
> 2.36.0
>