Message-ID: <516993be-f33e-64cf-811b-cb8272b1d844@intel.com>
Date:   Wed, 15 Feb 2023 08:43:38 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.4.2
Subject: Re: [RFC PATCH 0/4] fpga: add initial KUnit test suite for the
 subsystem
Content-Language: en-US
To:     Marco Pagani <marpagan@redhat.com>
CC:     Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
        Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
        <linux-kernel@vger.kernel.org>, <linux-fpga@vger.kernel.org>
References: <20230203170653.414990-1-marpagan@redhat.com>
 <05f6238e-4ad8-f30c-38da-74c343e6abb5@intel.com>
 <01fd3850-af54-c0f0-ec2f-ae672420ce17@redhat.com>
From:   Russ Weight <russell.h.weight@intel.com>
In-Reply-To: <01fd3850-af54-c0f0-ec2f-ae672420ce17@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cjJEMVVueWJFVWdjQmt4S0dnT2RDYks0U0oyVlRMbnFRN1VMSm04K3E4RE5Q?=
 =?utf-8?B?TThTR0RYa05IVWxmVE9NL2hqUWlodlpmNGFrWnZ0bHhlelU3bGROeVJGVVpN?=
 =?utf-8?B?MFhmNjNraGJtZjRFcm1IVi90QkJzNXdlczZwcE1zZ1dodWYzSUdEL2ZJRDVF?=
 =?utf-8?B?NnVkQldzUTUrNytjK2IreThUSnNJeVd3clVBMjc2TmRSZHhLVGw1N0hFbEFi?=
 =?utf-8?B?ZlN0UXFKZkJhRUdHRWFFUDU4bk1HQkxycW91blgxek1hMzYzK0p5RDVNakFZ?=
 =?utf-8?B?dGRaUGNtb21NV1FkNWRXMURJSkFZeDZpUFFETW1iSXNhSEJqSVZWSk1Fc0NW?=
 =?utf-8?B?ekhTZ1FpT3o4R1E2Q3dtM3lIb3c5b2NSV2hWenU0MTFxWkwxV1VLK1dGZ3RO?=
 =?utf-8?B?S2YxaU5DemZiQ1NpZ1pBTVcvWjNjVEhYNElHMHI0WTg1eXk3MExZYUpaNFB0?=
 =?utf-8?B?NHFNK3JVa3lSK1FEVStVSm1HVUNaak91dGpMeU4zK1ZzM1ZIWjZ6UVJ0MllQ?=
 =?utf-8?B?OWVDVEVOVFZuUGhZeFdqR1FDc3ZGWUgxVXJSQXI4QjZaTjROUTNXNnRMcjUr?=
 =?utf-8?B?MzFzNGc0ODlXK0tkUnV4N0h4NU5IZnpzMFE3USsrcTY0Z2tmdDlNRm80TTV0?=
 =?utf-8?B?cmh5U0RpTWFBcWx1TlZiY1BuOWpncEg0cFk3Y2J4NzIzVEtnenhTNVhWVkli?=
 =?utf-8?B?RUx6bFZHVzBhWEgxb3hlQ2p0Q1RjcndSZTF5QlpHNi93SWs0KzVSd3p1bjl0?=
 =?utf-8?B?UWxTMzd3YjBMU1dYZUFydEZsVHJlRktTYVF6ZXBBUGdXOTVlc3lQOU53RHov?=
 =?utf-8?B?eWg5N21xMTQ1dDNqKzlrY1hhOExtaSt1UnVHZXNyQVVZL1czOEpDK0tWUWpD?=
 =?utf-8?B?UE1hMmRVQ29YM1JMMkZ5bXdpN3NJRW5LZXhWYU9obGc2Wng5WWxqRGkxckg4?=
 =?utf-8?B?ZkZ0SVRrb2xsK3FqRFBieVJPUWFKVlRwR2VnQUpoeHhTbzQ3cmdmTmtEYVQ5?=
 =?utf-8?B?a2locGRCb0ZGdllsVlZIUzZXMzRGY3BQL29LUU85T2RCN0FENWQrYi8yOEVS?=
 =?utf-8?B?YTNzZmMxQ293WFdOUmdIalMrZHhyQitpK1BzdXE1elVXYU1QMW80cmVKVjd4?=
 =?utf-8?B?TFI5cHFHamdkZ1NZL3g2UEM5YUlUb1VXWERGQUxwVVM4bnR1N2plZFNyVlpB?=
 =?utf-8?B?d1dCRS9CeGFZaXYybGE2Um5MVlFsR2tiTUVYUFVBQ3JFY0NPMlMzNGJRaXkv?=
 =?utf-8?B?dk8xTFdEbFQxUUx5UEVzRlpUOGNNWFZnVTJzNFlUTEtCNThFczUwVmVWTElB?=
 =?utf-8?B?bnhWSytUNE5kMG1QMVQxU3djR3NqUmZyTmU5S3BqVzBpeFJabXhVdFlMQ25Z?=
 =?utf-8?B?ZzZxaHI4ZXdoUFNGZFYwNkhoWHdNTHpWODgrMGtyY0dyRTFMbjBKK1gySWpY?=
 =?utf-8?B?MWc5MXhtOWM2dnczMlhvNS9LcThjWm9oaytKUkVXSko1OE5xR29zVGsrM1BM?=
 =?utf-8?B?bVgrMDh6WHd6OUk2OVNQanRSZWNmSEc3TEg3anl0a2plbXNsc1hDVi9iZElL?=
 =?utf-8?B?NkhhMjAwN2R1SnZrdDNSZHMwUFAwQXNlbXFXTzlBUHhFVjlYSWdDVkY1WXo2?=
 =?utf-8?B?RFdMMEo3WDRIM1dBenB2M09LY1hKejVwZUV2T1h2ZEFDUzVkOWxrR2VHOXFT?=
 =?utf-8?B?amFHZWZiNS9RVzJUcW1EMWJhS1Y5MUIrY1RYRkx4SUZxcXF6TXJKa0o2SkhX?=
 =?utf-8?B?NDE3ZWJiNlgvZXNidmVzcjEwMzFkY0d2YnBKNE5nUGFCMGxSVmRVVzRyZUVK?=
 =?utf-8?B?R1JjWWpGOVMyL01GWnRVVmVhTlNvdXZoNkQrOFhST2pwL09VTzMzMDRZcWIx?=
 =?utf-8?B?bDZzdmp6VkF1SXNwdktjNGswR01PMTF4Snozck9XVmJpMk1wYjFYUGlvS25S?=
 =?utf-8?B?elVxQ2JWcm5YbEFGSzNESmVFbHRSdFpQeGxaWXlNRnJFaXlCVUNuMDhWTWtk?=
 =?utf-8?B?VlQxS2hhUTdWa1NDNHA4dTlzaitGZWVFR29JMEdUeFY4Sm5ZbDk5VnJ1bVRm?=
 =?utf-8?B?S3owRzhkTkt2MnkvWkc0bE9aaGNFRm1FMEo2OG04anlsR21PSnc4RFFhZTln?=
 =?utf-8?B?ZWlWcVdzR25RWmt3czB3ZG5EaGNpRlVacDA3ZHpQNHVHKy81c29zNnZWZjVO?=
 =?utf-8?B?bVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 483411cd-a0db-438f-abad-08db0f73cc89
X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1899.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 16:43:44.7473
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AcUTG5L3IBWOUbbf1yGPfvWeCyy5RPPuk32qez/36EnKqrjs2v83NaXZli2SFIzJXIwR4DQllCAVVKYyK+G1iG0ebwpE8MSOA1Vqt8xH4yk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6850
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/15/23 03:19, Marco Pagani wrote:
>> When I tried running these tests, I got an error until I created this file:
>>
>> drivers/fpga/tests/.kunitconfig:
>> CONFIG_KUNIT=y
>> CONFIG_FPGA=y
>> CONFIG_FPGA_REGION=y
>> CONFIG_FPGA_BRIDGE=y
>> CONFIG_FPGA_KUNIT_TESTS=y
>>
>> I think this file needs to be included in your patchset?
>>
>> - Russ
>>
> Patch 1/4 includes a .kunitconfig file with these configs set =y
>
>> diff --git a/drivers/fpga/tests/.kunitconfig b/drivers/fpga/tests/.kunitconfig
>> new file mode 100644
>> index 000000000000..a1c2a2974c39
>> --- /dev/null
>> +++ b/drivers/fpga/tests/.kunitconfig
>> @@ -0,0 +1,5 @@
>> +CONFIG_KUNIT=y
>> +CONFIG_FPGA=y
>> +CONFIG_FPGA_REGION=y
>> +CONFIG_FPGA_BRIDGE=y
>> +CONFIG_FPGA_KUNIT_TESTS=y
> To double-check for any patch format errors, I downloaded the patch set
> from lore.kernel.org and applied it on a fresh tree with Git (version
> 2.39.1) using git am. In my case, Git created the .kunitconfig file and
> I was able to run the tests.
>
>
I can see the .kunitconfig file in the emailed patch. I had to resolve
some conflicts when I applied patch #1 - I must have missed this file
when I committed the changes.

Thanks,
- Russ