Message-ID: <9a8793de-df20-6248-2817-a7ba706aa0f3@intel.com>
Date:   Wed, 15 Feb 2023 17:53:47 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH net-next v1 3/3] net/mlx5e: TC, Add support for VxLAN GBP
 encap/decap flows offload
Content-Language: en-US
To:     Gavin Li <gavinl@nvidia.com>
CC:     <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <roopa@nvidia.com>,
        <eng.alaamohamedsoliman.am@gmail.com>, <bigeasy@linutronix.de>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Roi Dayan <roid@nvidia.com>, Maor Dickman <maord@nvidia.com>,
        Saeed Mahameed <saeedm@nvidia.com>
References: <20230214134137.225999-1-gavinl@nvidia.com>
 <20230214134137.225999-4-gavinl@nvidia.com>
 <711630a2-b810-f8b0-2dcf-1eb7056ecf1d@intel.com>
 <7537ee48-c92a-a7df-b876-9a14ce2d34c6@nvidia.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <7537ee48-c92a-a7df-b876-9a14ce2d34c6@nvidia.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MmNKTWZCTWo4YjRLT1kwZklWSVFuYllCRzRKUzJwb2FOYlNFL2Q0MkhhZTBq?=
 =?utf-8?B?ZnZCM0R3NEZFTGJqZExZOWdHNENwdGovcDlGVGFIdWk0Vk43YSs3bUpTbXRX?=
 =?utf-8?B?VGNrL2x2QlJ3TC9ITStDcE9qZHRIc24vYWZEMHlSVnJkOERsQWk0UFd3VFNk?=
 =?utf-8?B?TkVSZmhXejVnRU5lZnN6YU1GWE11V0Zhd3RxUEhlTE55NXc2VkFzZ3FLaGxY?=
 =?utf-8?B?Rk42TmFlQ2ZSazdDd0J0OXRsVFJrWkhVQ1JFMWpCUlZCNlI2OWNuK0RVU211?=
 =?utf-8?B?dVJZcFp0Q0gvL3BGZXRkWGYxVTFRZXhYeGpnSXZVU0FBakMzL0xReVdkS1dR?=
 =?utf-8?B?eTl0akhudHhab0NVQzBScUMxZkZNbTdUcEIwdlJOeCswRGt6MEV5SnJFRzlV?=
 =?utf-8?B?RUpwblZtU0N5N09MZzFmdG9SaTZMcHZub0JaSGZob2VwQjYxU1d5QjF0S2I0?=
 =?utf-8?B?a0prOWJ2L01UaUd0R05ZRDU3ckc0d3cxNUg4U0F1a2M0aXRyZkZ3RUZVUTNJ?=
 =?utf-8?B?a3VVaC9NVEFqWnVTSXpPVWZnQ011VVJMVVVocEtDMGtzMWJ6OGdnWDRhYVhs?=
 =?utf-8?B?SWZoVEpUa3pvbDVTMXNiRjJpVHRtVW1kNytiN0xOVHd6aStNekJsNHlCeDlF?=
 =?utf-8?B?TVBsZ1RNZDhLYWJQSUQ0TS9lYXRuenlvNDlkY3JzTWdmK1NjVHlBN0JDc3VX?=
 =?utf-8?B?RXVLaEVzb3N3bzBKNlgyYUwvSUVkM25heDdiTVRwOWNzT3ArcWRXWklCWWpt?=
 =?utf-8?B?QWxMeG1YbUVpNk9SY0tLTmFUb25hNlRWUVk4c3oyclJLQTNLSEwzVkNWcDc3?=
 =?utf-8?B?aXpIVHc5VTl5TmdXZE1ia0FkZWxHbUFwK1l2R2xoUTdEbFBmWGNsbGIwOXVZ?=
 =?utf-8?B?STJxRnpBc2RkWkZBYUs5Rkptd0g4WVR0dGx3K3RFOWRkY0hlMmx3em1rM0E1?=
 =?utf-8?B?eTlyQ3FPTmI3YWtNN1pzTlFmRGNUWWRYaGdvYWNnUWFNcGRUNzJUKzJPaUh5?=
 =?utf-8?B?QlN6VHh4b3NDb2NuYm1CenRWWXB5YTkzR010LzJVZmJvdVN5eHBaSG1qSXp6?=
 =?utf-8?B?VktVb25ZU3FDN3VtOVF1eThmaGlMK2pRblZRSEVRbEpnUVRvQU1GeHd2R25G?=
 =?utf-8?B?ZU1pd05wZGg4NDB4c2E0UGFNeVFXbjBVYno1Z251QlVxS2owSGdpWTd3Q3Rr?=
 =?utf-8?B?cHRCd1pZTjVVZjRBVC9NV0RPdjgwa0pQVDJPa2pFcFlqNVNPTTJGRGRMbERO?=
 =?utf-8?B?bWpPMUlYN3E1NWRXVnMvY1BkNldZQnBvVzAxZTVxOC9hSDJyQU00WnlEOXZJ?=
 =?utf-8?B?QURlTzZ1TWhIeitxOURtSkpxN3dMV244eDNqQTlUNlB0ckNHNHRsbVI5MDVL?=
 =?utf-8?B?Z0lZMmNONjhhUlNoT2k0UkNwNVNIN2doamV2VllrQ1FINys5S3N6YmxMZGpy?=
 =?utf-8?B?U2Fmd2cyUjFDMFNYYUtCL3Y2SHBOSUczbGh2dzJaWUFkQW4raHBJbTVDUEZ6?=
 =?utf-8?B?bjNCSnk1eWovbmdYREZJWWd3YnE1cmZiNHR3dmZNTmVnS1VRNUQzWFNlNUIw?=
 =?utf-8?B?VXRrbUtLaDh2OXRxS1J2YmlrdUFMOXlNdTM2RUVscXd4alNxdG83S21PeXVE?=
 =?utf-8?B?VGZ6STltUzd0OWJEbVZBekM4VW54V09DTHNZbEV1Z29CYnBOM0h4TDhZaFRM?=
 =?utf-8?B?ODFaMEZ6T0ZEaVFUL0FRQ0h2NXdCTFVPTTJpczR3dVZhZ1RZQmZFMTZFcVAr?=
 =?utf-8?B?WEo3Z3NqcDNUbUJUa1hJK3g4ZWl2MU42Q05LdGUwNjdYd3FQTmlCelZodEd3?=
 =?utf-8?B?eUJmQzBOc0tIU2tMdERHbDZxdG82VU1ZVUdHMUMvTWxDSENNbmhPUWZZTzN1?=
 =?utf-8?B?OHBqWlU3UERCNHhTbG9QdDV5WGs0VzdzeU1IZG1SSHMyNTFXamc2QUFYNUlD?=
 =?utf-8?B?dTdRaXkzWjhFTWQrUlVreEdRaS9icGVhL2dzUWlIdldGNHdNUWhlOEJwQU5T?=
 =?utf-8?B?eXdDYWFzZnRGQThBSHZ4OW9lRDRQVTRuU3d2YStyenF2WDdYN1NCTnRTRGFt?=
 =?utf-8?B?MEUzNEtaQ09SWDlTc3g0VlBscDVibVRlbTh5STdscUxPcHRrcHZnanpDNnBz?=
 =?utf-8?B?OFBxNVFBMjIzWGx6dy9mVUZ5bG52YUVsL1h4cStPbDlyVmRrMDhXWEk1Zk02?=
 =?utf-8?Q?AoHIBAH0zwj5G9BUbtquj9k=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f37c1b6-6528-41f1-c338-08db0f7564ca
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 16:55:08.2000
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lMuH0eJ5Xwz/G2pZuXOZAgZh4zG1rRTAULScsgEtyeoDPdd4ypamKBbN8LsrremuldpRnZDKFWAGWIBp0jmh/9c0zPaNurOdjrZ9dR1n9/8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6443
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Gavin Li <gavinl@nvidia.com>
Date: Wed, 15 Feb 2023 10:50:04 +0800

> 
> On 2/14/2023 11:26 PM, Alexander Lobakin wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> From: Gavin Li <gavinl@nvidia.com>
>> Date: Tue, 14 Feb 2023 15:41:37 +0200
>>
>>> Add HW offloading support for TC flows with VxLAN GBP encap/decap.

[...]

>>> @@ -96,6 +99,70 @@ static int mlx5e_gen_ip_tunnel_header_vxlan(char
>>> buf[],
>>>        udp->dest = tun_key->tp_dst;
>>>        vxh->vx_flags = VXLAN_HF_VNI;
>>>        vxh->vx_vni = vxlan_vni_field(tun_id);
>>> +     if (tun_key->tun_flags & TUNNEL_VXLAN_OPT) {
>>> +             md = ip_tunnel_info_opts((struct ip_tunnel_info
>>> *)e->tun_info);
>>> +             vxlan_build_gbp_hdr(vxh, tun_key->tun_flags,
>>> +                                 (struct vxlan_metadata *)md);
>> Maybe constify both ip_tunnel_info_opts() and vxlan_build_gbp_hdr()
>> arguments instead of working around by casting away?
> The reason to cast it is a WA to use ip_tunnel_info_opts which takes
> non-const arg while>
> e->tun_info here is a const one.

That's what I'm asking - why not make ip_tunnel_info_opts() and
vxlan_build_gbp_hdr() take const tun_info?

> 
>>
>>> +     }
>>> +
>>> +     return 0;
>>> +}
[...]

Thanks,
Olek