Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0B7FC64EC4 for ; Wed, 15 Feb 2023 17:15:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230014AbjBORPF (ORCPT ); Wed, 15 Feb 2023 12:15:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229545AbjBORPD (ORCPT ); Wed, 15 Feb 2023 12:15:03 -0500 Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA3A41A677; Wed, 15 Feb 2023 09:15:01 -0800 (PST) Received: from [192.168.1.103] (31.173.83.250) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.986.14; Wed, 15 Feb 2023 20:14:52 +0300 Subject: Re: [PATCH v2 0/18] pata_parport: protocol drivers fixes and cleanups To: Damien Le Moal , Ondrej Zary CC: Christoph Hellwig , Jens Axboe , Tim Waugh , , , , References: <20230214230010.20318-1-linux@zary.sk> <6ce57b8c-7f0c-f3d1-6938-c87fa4ab650d@opensource.wdc.com> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <8a0bd9fb-c667-8871-1955-3e4eb880f43d@omp.ru> Date: Wed, 15 Feb 2023 20:14:51 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <6ce57b8c-7f0c-f3d1-6938-c87fa4ab650d@opensource.wdc.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [31.173.83.250] X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 5.9.59, Database issued on: 02/15/2023 16:49:39 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 175554 [Feb 15 2023] X-KSE-AntiSpam-Info: Version: 5.9.59.0 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 504 504 dc137e1f9c062eb6c0671e7d509ab442ae395562 X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_arrow_text} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 31.173.83.250 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: {Found in DNSBL: 31.173.83.250 in (user) dbl.spamhaus.org} X-KSE-AntiSpam-Info: omp.ru:7.1.1;127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1 X-KSE-AntiSpam-Info: ApMailHostAddress: 31.173.83.250 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 02/15/2023 16:53:00 X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 2/15/2023 2:45:00 PM X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/15/23 2:50 AM, Damien Le Moal wrote: [...] >> This patch series fixes two bugs and cleans up pata_parport protocol drivers, >> making the code simpler with no changes in behavior (except logged messages). >> >> Signed-off-by: Ondrej Zary > > Sergey did send you some reviewed-by tags for some of the patches. But I > do not see any in this v2. Did you forget to add the tags to the reviewed > patches ? That is nice to do so that I do not have to keep track of > reviews across series versions... Yes, it would also simplify my further reviews (I have low bandwidth currently due to being somewhat overload at work)... >> --- >> Changes in v2: >> - added two bugfixes (first two patches) >> - addressed Sergey's comments (mostly split patches) Well, you're supposed to be more detailed about what you really did to the series, preferably listing the changes in each patch (usually after the --- tearline)... [...] MBR, Sergey