Date:   Wed, 15 Feb 2023 12:22:24 -0500
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Alexander Potapenko <glider@google.com>,
        Andrey Konovalov <andreyknvl@gmail.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        Vincenzo Frascino <vincenzo.frascino@arm.com>,
        kasan-dev@googlegroups.com,
        Andrew Morton <akpm@linux-foundation.org>,
        Vernon Yang <vernon2gm@gmail.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RFC] maple_tree: reduce stack usage with gcc-9 and
 earlier
Message-ID: <20230215172224.joi2edqzippydiet@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Arnd Bergmann <arnd@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Alexander Potapenko <glider@google.com>,
        Andrey Konovalov <andreyknvl@gmail.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        Vincenzo Frascino <vincenzo.frascino@arm.com>,
        kasan-dev@googlegroups.com,
        Andrew Morton <akpm@linux-foundation.org>,
        Vernon Yang <vernon2gm@gmail.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20230214103030.1051950-1-arnd@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230214103030.1051950-1-arnd@kernel.org>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?c5s3iJUXfviX8jg7DIt7PjLL26CVklehs/vBiBmHdJo4SW6EaKpaeWzasN6r?=
 =?us-ascii?Q?/BNC4JsJt6DwDHbt6DI5Vt474OyrBDPj7rAc8ZZRufY1uzNVZnD1C3CTTEVJ?=
 =?us-ascii?Q?8k5NgorUE8VccpPslk3d7FL/MIr86Q4GCdWQqqG+7xQR2SOYsdc430JEw+rz?=
 =?us-ascii?Q?sYM2mTnW044vjoANV3m1dxkRWpe2uBIST8FQHAyWHVTYyQKfB+Cc7mMmLLGA?=
 =?us-ascii?Q?taLHrhrvNo421ibrEBzXpX3VD+pD3H2UX/excSxetabys9wix2W6NyL6P9lP?=
 =?us-ascii?Q?JID1ekAmJPvmEWm8/nQgrpt0sX1PK0GYjxXAc3iuuQYnab6KOkcWVn75bLm0?=
 =?us-ascii?Q?JyR4A2YAr4ryMnuzb1Hl4TmufReiYxpxN5HfvQNA4GBG8aCGTGqjSbbZnd5J?=
 =?us-ascii?Q?PcFXVryvejPNzQwuMdKPD/02wvYPmxZDgVkfX9IYieihH4rh2ZBtO/wTvl0b?=
 =?us-ascii?Q?Z9VOyGvSm/qUDE0mWfVa4PgLKAvUmn3dCpHbjI41iYoz2Knxzj9tCWLbwINT?=
 =?us-ascii?Q?rrMSbOHlxmfgNw8hXw32V+TU2iifmr60/V5FzsaSD5Uc8+Z0krAMadK/4IPt?=
 =?us-ascii?Q?P4RIZ2RrxPHgfrImquCZAPTvJ0wsZmcI9vkv9jgYgt8SSOdCehTPFzuRByG2?=
 =?us-ascii?Q?WzqD1FA2K8XJhA7wqsiSCS8j71wAH5zmBYi1fdVA8INXzMzzM+JajmCLc0nz?=
 =?us-ascii?Q?fF0yHbSGPippoy1L8PHeK6uOrl1Z6w5TAaKGLhjFlKVhYSZ/BSZCRG0WutCd?=
 =?us-ascii?Q?oaVI3BY3FZCOJjEyj6gQEWaB8cRnl0RYGJ47/XZo9l/2nrChL4r6O5/kB3t1?=
 =?us-ascii?Q?eyQV06fZNgYNb/hwOR4fiOho/br+0jy9eVRwpWklbBwcxRqISkYxDZEsxBzA?=
 =?us-ascii?Q?ebSL4+8y7KPHFmK9kufrFbP1UOzvSmHaipWfKKyfnmrxP5NJASoIJlf6SOHo?=
 =?us-ascii?Q?txv9zbVvY1FsSjUWzKHKRNZ+U8aKIExZNjr5Z2dVZ8aXvFZMqWaKy/KAbfBh?=
 =?us-ascii?Q?js2/VafviQ2OroFmHPiv1dC1RzF+LF/Qhl/lLjQB/Z7JHwzDgcotoJN2vSHK?=
 =?us-ascii?Q?/QXYaAKVofFlsMMo5K9+qgDfm/s85nVmzont9U/xVfwg6k9TIqnGQfJXaIP6?=
 =?us-ascii?Q?0mmbysDDD3KwZ6ZJhizBi5WBftt9NlPum9L1DUzfRcRCFQm5ilQJwVBr+r3s?=
 =?us-ascii?Q?QpFHC8xVFUlcS9EG7afYVddhQoJeNwZm6OOuHf/V+xgdE/zDgviqlMr9WzB4?=
 =?us-ascii?Q?+6wwbuXQMtxWJYZOTHXG4w8vkTjzQR1j28S3KDIesOFVW9xTAAToGq6daC0K?=
 =?us-ascii?Q?Pa58oElPuhGeBeI9duBNBWlGKexKABqjUxSZkIRbe0XvQ3ecgNwVUmZwpB/z?=
 =?us-ascii?Q?OLz5fYnLgR26KY1mU9R3z633Dg0dRRxwtLs1hsOzdJ3ADPYq+nytLFHtrU0e?=
 =?us-ascii?Q?ZPkNoza2P36BlM27Ru/hYqmdTciXwxRJP/H7wo/JZFvC7yOrI0+DMUcDUqRp?=
 =?us-ascii?Q?9Rr7/UWfQSlRdvMawRJdC84b4oN+7PIZHW79avyR0TzafK3cgR9x4W+ao3DU?=
 =?us-ascii?Q?Vrhspuh4zfyYZXZgy0RyQpiJaSAcJTbdzO8S/2gF5cB0soD6HYHdzza8bAcq?=
 =?us-ascii?Q?rw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?w7q3qc7NadnF6ITpFrbFwaFYHZQ2sDMxDnzv4c52KrOAGsQWGpmvrocITiDZ?=
 =?us-ascii?Q?f+x9fObMSQ1zycwzcMtAcSPu6APK6y7FjqodJNq0PWLzwcq9Kfwm/TwQ5FjW?=
 =?us-ascii?Q?fwYjYVLJu9cczOhrPckE4IChBmABQBJkojWNQcG6YBDQSLn+E96cEA3SwodN?=
 =?us-ascii?Q?DqjdXIFM2Is25NgK/3EsUiHXsn2lkJt0AvGn0RW4UPZPSovARyEMMNbklTfb?=
 =?us-ascii?Q?OTPT5Mzix/wWnQ3KYrzxeQQQGxJEtGQ831+XkeAIIrKPDxZtJmYvVCd6kLN8?=
 =?us-ascii?Q?5o6PXkcMLesfCsoM8WPevog9j9oSK+mb2X2AUZBNpqZpjdpcIls0YSDcKmrb?=
 =?us-ascii?Q?AiXKiB6AxqSRVLp+vcCGmJPnbVFU9/iRKlhuusUSh1SkyyrEBlrSJetYf2DP?=
 =?us-ascii?Q?YR+/UsTrYxpkA5yVKM6zwC+zPw3VFjAw4Sc73/QPzn5wQ7F75DqbS1J1FhNC?=
 =?us-ascii?Q?NKEw5h2d4bRwT8uth75lmbiQM9x4uW9W6tj/vh9QJYjpmRCw4WLBZPqjPgdL?=
 =?us-ascii?Q?okgEdXl0sE1pX7ic19FkvdrNv0hikOev+R5EAUellgbwA5O6YAZA+zlKxFLB?=
 =?us-ascii?Q?2eCnXohZ2yHWIDvPRDiL4bCaJMjfGXL1I4dmt7HAE4+xWFHmp6VzGDKkv/9U?=
 =?us-ascii?Q?sHaRqJN4ZVjRIefly/b6jP0F+TQrwOCPV7rNEjBEbQgpKjDjJU9d2iDFntbH?=
 =?us-ascii?Q?vENGv52vgIV4VJUe2n5ANwa1423ejXT5j5iQhLYolsDiyKcqr0dxcegLKzV+?=
 =?us-ascii?Q?rCZ0rNXeFkWUWGWsK2pwRQHc4VYa53lfNiMYs1f5Q345VZhqlZLYpa4z5UHv?=
 =?us-ascii?Q?VaUwVY8aiaYmuAA2JUt64n7cFhNmCE8w3nW5h++qXay7vkHI0L7hJzVK3Cqc?=
 =?us-ascii?Q?igfkU+/Bd01iPPxNDhgbYKjr1qfbp1pKrN0t+RDY72Q0aLVLzhwVLOcYbVfv?=
 =?us-ascii?Q?xzq29IQLRhaX4yhMjJ+BsjAFpeORoeqsaF9xS4UOY4WlaJVS9W/Dv294xwlX?=
 =?us-ascii?Q?pOz7gD8PKFQxOQAIKjSaNHKKcg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2a62027-1e87-48fb-8b4f-08db0f793690
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 17:22:28.6458
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 71s4o2EnS1YHHZZV9nRNNBAEucbDyTOid2gYH7R3TdobeHNJY6qjMMM/abuSuU1LzDBgcnspVTTb0c4H2MDnmw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6363
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-15_08,2023-02-15_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0
 phishscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2302150155
X-Proofpoint-GUID: SFosIgNU2Sr1V3BfzGb5PVsM1FIxghMT
X-Proofpoint-ORIG-GUID: SFosIgNU2Sr1V3BfzGb5PVsM1FIxghMT
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Arnd Bergmann <arnd@kernel.org> [230214 05:30]:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> gcc-10 changed the way inlining works to be less aggressive, but
> older versions run into an oversized stack frame warning whenever
> CONFIG_KASAN_STACK is enabled, as that forces variables from
> inlined callees to be non-overlapping:
> 
> lib/maple_tree.c: In function 'mas_wr_bnode':
> lib/maple_tree.c:4320:1: error: the frame size of 1424 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
> 
> Change the annotations on mas_store_b_node() and mas_commit_b_node()
> to explicitly forbid inlining in this configuration, which is
> the same behavior that newer versions already have.
> 
> Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>
> Cc: Alexander Potapenko <glider@google.com>
> Cc: Andrey Konovalov <andreyknvl@gmail.com>
> Cc: Dmitry Vyukov <dvyukov@google.com>
> Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>
> Cc: kasan-dev@googlegroups.com
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  lib/maple_tree.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index 5e9703189259..646297cae5d1 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -146,6 +146,13 @@ struct maple_subtree_state {
>  	struct maple_big_node *bn;
>  };
>  
> +#ifdef CONFIG_KASAN_STACK
> +/* Prevent mas_wr_bnode() from exceeding the stack frame limit */

nit: Should there be more info in here?  You did add it to two functions
and it's a problem for frame-larger-than=1024

Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>


> +#define noinline_for_kasan noinline_for_stack
> +#else
> +#define noinline_for_kasan inline
> +#endif
> +
>  /* Functions */
>  static inline struct maple_node *mt_alloc_one(gfp_t gfp)
>  {
> @@ -2107,7 +2114,7 @@ static inline void mas_bulk_rebalance(struct ma_state *mas, unsigned char end,
>   *
>   * Return: The actual end of the data stored in @b_node
>   */
> -static inline void mas_store_b_node(struct ma_wr_state *wr_mas,
> +static noinline_for_kasan void mas_store_b_node(struct ma_wr_state *wr_mas,
>  		struct maple_big_node *b_node, unsigned char offset_end)
>  {
>  	unsigned char slot;
> @@ -3579,7 +3586,7 @@ static inline bool mas_reuse_node(struct ma_wr_state *wr_mas,
>   * @b_node: The maple big node
>   * @end: The end of the data.
>   */
> -static inline int mas_commit_b_node(struct ma_wr_state *wr_mas,
> +static noinline_for_kasan int mas_commit_b_node(struct ma_wr_state *wr_mas,
>  			    struct maple_big_node *b_node, unsigned char end)
>  {
>  	struct maple_node *node;
> -- 
> 2.39.1
>