Date:   Wed, 15 Feb 2023 17:23:14 +0000
From:   Chris Down <chris@chrisdown.name>
To:     Nathan Chancellor <nathan@kernel.org>
Cc:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, mcgrof@kernel.org,
        ndesaulniers@google.com, trix@redhat.com,
        linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
        bpf@vger.kernel.org, llvm@lists.linux.dev,
        Abaci Robot <abaci@linux.alibaba.com>,
        Song Liu <song@kernel.org>
Subject: Re: [PATCH] module: Remove the unused function within
Message-ID: <Y+0VAr21hlIdrxyp@chrisdown.name>
References: <20230210064243.116335-1-jiapeng.chong@linux.alibaba.com>
 <Y+0MsMomkcDBdjNI@chrisdown.name>
 <Y+0PzlA0LijhfD8R@dev-arch.thelio-3990X>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <Y+0PzlA0LijhfD8R@dev-arch.thelio-3990X>
User-Agent: Mutt/2.2.9 (2022-11-12)
Precedence: bulk

+Cc: Song

Nathan Chancellor writes:
>On Wed, Feb 15, 2023 at 04:47:44PM +0000, Chris Down wrote:
>> Jiapeng Chong writes:
>> > The function within is defined in the main.c file, but not called
>> > elsewhere, so remove this unused function.
>>
>> Huh? It's used by __module_text_address(), no?
>
>Not after commit 2ece476a2346 ("module: replace module_layout with
>module_memory") in -next. This patch should have a fixes tag, even if
>the warning is currently hidden behind W=1.

Huh, I thought I had checked out latest -next, but must have not done so 
somehow :-) Mea culpa.

If it's only in -next then no Fixes needed, since there's no stable rev yet.

Jiapeng, in future, please make sure to cc the author of related commits when 
reporting stuff like this :-) It helps people to update their patches.

Song, you probably want to update your patch.