From:   SeongJae Park <sj@kernel.org>
To:     David Hildenbrand <david@redhat.com>
Cc:     SeongJae Park <sj@kernel.org>, akpm@linux-foundation.org,
        osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/memory_hotplug: return zero from do_migrate_range() for only success
Date:   Wed, 15 Feb 2023 18:03:16 +0000
Message-Id: <20230215180316.75431-1-sj@kernel.org>
In-Reply-To: <388b9a93-423f-33f8-0495-2a4a290fd1aa@redhat.com>
References: 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 15 Feb 2023 14:16:05 +0100 David Hildenbrand <david@redhat.com> wrote:

> On 14.02.23 23:32, SeongJae Park wrote:
> > do_migrate_range() returns migrate_pages() return value, which zero
> > means perfect success, in usual cases.  If all pages are failed to be
> > isolated, however, it returns isolate_{lru,movalbe}_page() return
> > values, or zero if all pfn were invalid, were hugetlb or hwpoisoned.  So
> > do_migrate_range() returning zero means either perfect success, or
> > special cases of isolation total failure.
> > 
> > Actually, the return value is not checked by any caller, so it might be
> > better to simply make it a void function.  However, there is a TODO for
> > checking the return value.
> 
> I'd prefer to not add more dead code ;) Let's not return an error instead.

Makes sense, I will send next spin soon.

> 
> It's still unclear which kind of fatal migration issues we actually care 
> about and how to really detect them.

What do you think about treating the isolation/migration rate limit
(migrate_rs) hit in do_migrate_range() as fatal?  It warns for the event
already, so definitely a bad sign.

If that's not that bad enough to be treated as fatal, I think we could have yet
another rate limit to be considered fatal.


Thanks,
SJ

> 
> -- 
> Thanks,
> 
> David / dhildenb