Message-ID: <7629c295-fc74-41fe-fd2e-28fe3a6e0846@linux.dev>
Date:   Wed, 15 Feb 2023 10:04:51 -0800
MIME-Version: 1.0
Subject: Re: [PATCH v3 bpf] bpf, test_run: fix &xdp_frame misplacement for
 LIVE_FRAMES
Content-Language: en-US
To:     Alexander Lobakin <aleksander.lobakin@intel.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>
Cc:     =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= <toke@redhat.com>,
        Song Liu <song@kernel.org>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>, bpf@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230215152141.3753548-1-aleksander.lobakin@intel.com>
From:   Martin KaFai Lau <martin.lau@linux.dev>
In-Reply-To: <20230215152141.3753548-1-aleksander.lobakin@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/15/23 7:21 AM, Alexander Lobakin wrote:
>   /* The maximum permissible size is: PAGE_SIZE - sizeof(struct xdp_page_head) -
> - * sizeof(struct skb_shared_info) - XDP_PACKET_HEADROOM = 3368 bytes
> + * sizeof(struct skb_shared_info) - XDP_PACKET_HEADROOM = 3408 bytes
>    */
> -#define MAX_PKT_SIZE 3368
> +#define MAX_PKT_SIZE 3408

s390 has a different cache line size:

https://lore.kernel.org/all/20230128000650.1516334-11-iii@linux.ibm.com/

The above s390 fix is in bpf-next. It is better to target this patch for 
bpf-next also such that the CI can test it in s390.