Message-ID: <447ea90f-bd4c-6200-4c56-8eefec7050e2@intel.com>
Date:   Wed, 15 Feb 2023 19:11:20 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v3 bpf] bpf, test_run: fix &xdp_frame misplacement for
 LIVE_FRAMES
Content-Language: en-US
To:     Martin KaFai Lau <martin.lau@linux.dev>
CC:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= <toke@redhat.com>,
        Song Liu <song@kernel.org>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>, <bpf@vger.kernel.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230215152141.3753548-1-aleksander.lobakin@intel.com>
 <7629c295-fc74-41fe-fd2e-28fe3a6e0846@linux.dev>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <7629c295-fc74-41fe-fd2e-28fe3a6e0846@linux.dev>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzRwL1FHU0JJaUJmdjM3NVdyTGRQWEVzOWMzYVJnMGZKVkJqWHo4b2Q0bmth?=
 =?utf-8?B?eWJPai9ualFoYlloMlRUNXZnSUJibkptZkRrZ3ZWVWNwc08wbVJXb21NZ1ZO?=
 =?utf-8?B?MmtTQk1vQk1LaEczWGM3UmJEa1VwTGtlSmtJWkxNbXppVHN2YURRUGRWRm1Q?=
 =?utf-8?B?TGlsWFVOWThSQ1F3LytpOGJoanE5MnpWQjZWSzZ1eUcyMWsxN1d2MHFLMytr?=
 =?utf-8?B?VDk1bnJCUlRQS1hMQ01JaWlXMW9WMHo2ZFBES2F3ZEtISGdvaE4wTGpvY3Zi?=
 =?utf-8?B?STJvWHJyN0M1UDU3blA1SUJyL3ZrNk9NbVVqWGZCWmtrcHBQcEJwRW9rMlc1?=
 =?utf-8?B?TkJEaTBsNUk4R2o2S2VEQjlCN3puSlI2RFByalJLbFd1N0dyN1dkMEpiZmxj?=
 =?utf-8?B?WlV4WkJPT0FCaWZpWHRnKzJJdmZ3M0N5SnFNSjRKUmhMdXZudUtwRVF5b1hz?=
 =?utf-8?B?dThIeW1DRzhGWkJXR3FCOHFXTlNLQVNnWGtjNXN5ZzlJb3A3alptUFozTURH?=
 =?utf-8?B?U1FGdkJNc3FGa1lTMjlsZ3NuRUtUTFBkbXBOeVFLazRNeEZYWXMvejAvc0E4?=
 =?utf-8?B?RUNrZ09KVjFSWENGcklNbGZpSTI5eFB2UWh2bGg4b0RyUUhLUXpBR3lSTGpV?=
 =?utf-8?B?ZGlwZWl3VThZSWRJWjZxR1EyWEQwVDUwNjR3bEVPaEtjdXhnQXpZVDV6b1pT?=
 =?utf-8?B?ekwwY0loaGRnYjhPb2ZlQ0tnenNlSzFMVlRvQndpWGFCdklTbytrbUpCZXh3?=
 =?utf-8?B?ZVBZdGoya0JJaEJnOEEzSXB2SFY3Q3hITE43YXV1Y2JzM1IzbnRzV01mTTR2?=
 =?utf-8?B?d3VSS1NxU3VQRWk4QWVUQWY0eE9nd2VNb09qT1hWSER1QTlQL1JuRjV3TE0v?=
 =?utf-8?B?djgyRWVENi9SaXR3VEwzclpsWEhWeVk4R0JkYUpjWFVmTWcwQnBRWDloWUFx?=
 =?utf-8?B?VE1pNEdSOUNsR05FQXRUK1UzZjVNaUw2aFB1MlRVTDNsUTRVcUZGaDkvS2Ny?=
 =?utf-8?B?VHNmb1N3NDNqUGl1Qzhad3ptZGJ4R3lucWdjeTU5SCtGb0w4V242b0lNelR2?=
 =?utf-8?B?cXNGbzROUGZoYkhrYnpRSUt1VE1KMDZpeEtzelc2bGIvaGtHWEV0RjlSS2dv?=
 =?utf-8?B?anFYaGM5dmFZdlBxSXVBVHdzb3U4STVURDZzR3FIdVhRcHJxcUVYVThmSU9O?=
 =?utf-8?B?VFZadjNpOFNrSkZQMTlWMFV6elN0US8zR0dQY245c1U5UjlSdEYzOWRqaWRT?=
 =?utf-8?B?R0EwS0U3QmxKc242QVppVFZwMXBIaWRqbG8zUmVuMTVLVTJLb01NWkc2bUhm?=
 =?utf-8?B?Nyt2aDRXdk9CZFA2YWhYWEVrOHVlQmdicTEwZW1KM3lSdzNXbEFET2tUNjBD?=
 =?utf-8?B?ZEZEUVg2Zzh5dVlaYWhlRGxWNGJXeTNCN1pwcHc2bWJzS052dkxoblVSRUpp?=
 =?utf-8?B?SDFNTkdRTmIxR0svSGhuMW9sYytLbHZra1I3aEhRcXRkSHc4bkhGaDQyS2x0?=
 =?utf-8?B?NFpxeHliOU1JNDRDdWNqazNQZUNRNlVUcHpHUW4yWXBxODR6ZlNpZDR6T3Rt?=
 =?utf-8?B?NVFkclZodlpKRmN2WHNPZXNQUldrZmM0Q1hFTGRkMVZncVdUckdGK1ZMMHZz?=
 =?utf-8?B?R0JXWVN5YWVvN01IYTFwS0d6cm43WWM3ZUpzZkdkQWxma0xOVGltekRlMGdm?=
 =?utf-8?B?cEt3MWdlNVJxaENsd3dHRjNvbnorUHBqdkZzbmw3bFRDclZ4aFZjUkp6a0h6?=
 =?utf-8?B?UGZZU2xtb0tETkZoa1QzSDhkaFZvM0d1MFlVV2VNeUN4VEZBNXh1eEErQWZk?=
 =?utf-8?B?TnhoczdWSnpyT3I2aDBrUC9rSFc1UklQRjJqYTgzNGczYnNjYkZQR3VTSVps?=
 =?utf-8?B?VU9pbGZOV0pwN05DbGJoWEVVbGZKQVBySEorSjZpU2JYdjBBUElyV0ZnMFVL?=
 =?utf-8?B?SDhpU214MU8rekhKRlVmNjJ4K2QvY1FvVnpkTzQvWU1lK2ExZC9nTVhBOVFi?=
 =?utf-8?B?ekJJVzczWGV5SmRnMHBrZjhuMjNOU2UyUzhXQXdJL3JPRnNxVzArdCtqUzBQ?=
 =?utf-8?B?YlVUdE5GakhzS09iSW1wSmQxMWVzY2V6b3lCejdOVFBrTEJvdTVnaWorTXFp?=
 =?utf-8?B?ZUxOQVVqNmhHOG5Qcy9MZzJnN3VWZThPZ0hrYnNvc2JKeTFRY0FmN21VYXg4?=
 =?utf-8?Q?ldsuw0nj81FGtYFSPi6pOYg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7e43902f-3c8d-4be0-7f2c-08db0f803a20
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 18:12:41.0527
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1fXNwm5AHy8QmuT6Ej/5wgbeEyZlnleigeiea2/xZA7fTxiGKXGjS6mxKBKUdaxhmbbU5Pi6E8bkJk3V3AoaEuOLUzoDdz5NN9NQbD7xJf8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5792
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Martin Kafai Lau <martin.lau@linux.dev>
Date: Wed, 15 Feb 2023 10:04:51 -0800

> On 2/15/23 7:21 AM, Alexander Lobakin wrote:
>>   /* The maximum permissible size is: PAGE_SIZE - sizeof(struct
>> xdp_page_head) -
>> - * sizeof(struct skb_shared_info) - XDP_PACKET_HEADROOM = 3368 bytes
>> + * sizeof(struct skb_shared_info) - XDP_PACKET_HEADROOM = 3408 bytes
>>    */
>> -#define MAX_PKT_SIZE 3368
>> +#define MAX_PKT_SIZE 3408
> 
> s390 has a different cache line size:
> 
> https://lore.kernel.org/all/20230128000650.1516334-11-iii@linux.ibm.com/
> 
> The above s390 fix is in bpf-next. It is better to target this patch for
> bpf-next also such that the CI can test it in s390.
> 

Oh, thanks for letting me know! Will do in a bit.

Thanks,
Olek