Message-ID: <c810373e-9fa5-9b2f-9425-af557c6dcbae@linux.dev>
Date:   Wed, 15 Feb 2023 10:21:44 -0800
MIME-Version: 1.0
Subject: Re: [PATCH v2] fixed typos on selftests/bpf
Content-Language: en-US
To:     Taichi Nishimura <awkrail01@gmail.com>
Cc:     andrii@kernel.org, ast@kernel.org, daniel@iogearbox.net,
        davem@davemloft.net, deso@posteo.net, haoluo@google.com,
        hawk@kernel.org, joannelkoong@gmail.com, john.fastabend@gmail.com,
        jolsa@kernel.org, kpsingh@kernel.org, kuba@kernel.org,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        llvm@lists.linux.dev, mykolal@fb.com, nathan@kernel.org,
        ndesaulniers@google.com, netdev@vger.kernel.org, sdf@google.com,
        shuah@kernel.org, song@kernel.org, trix@redhat.com, yhs@fb.com,
        ytcoode@gmail.com, rdunlap@infradead.org
References: <f8f3e8df-f707-28f3-ab0f-eec21686c940@infradead.org>
 <20230215032122.417515-1-awkrail01@gmail.com>
From:   Martin KaFai Lau <martin.lau@linux.dev>
In-Reply-To: <20230215032122.417515-1-awkrail01@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/14/23 7:21 PM, Taichi Nishimura wrote:
> Hi Randy,
> 
> Thank you for your reviewing.
> I fixed costant and it's to constant and its, respectively.
> 
> Best regards,
> Taichi Nishimura
> 
> Signed-off-by: Taichi Nishimura <awkrail01@gmail.com>
> ---
>   tools/testing/selftests/bpf/progs/test_cls_redirect.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/bpf/progs/test_cls_redirect.c b/tools/testing/selftests/bpf/progs/test_cls_redirect.c
> index a8ba39848bbf..66b304982245 100644
> --- a/tools/testing/selftests/bpf/progs/test_cls_redirect.c
> +++ b/tools/testing/selftests/bpf/progs/test_cls_redirect.c
> @@ -610,8 +610,8 @@ static INLINING ret_t get_next_hop(buf_t *pkt, encap_headers_t *encap,
>    *
>    *    fill_tuple(&t, foo, sizeof(struct iphdr), 123, 321)
>    *
> - * clang will substitute a costant for sizeof, which allows the verifier
> - * to track it's value. Based on this, it can figure out the constant
> + * clang will substitute a constant for sizeof, which allows the verifier
> + * to track its value. Based on this, it can figure out the constant

This does not apply. Ensure the diff is generated by git, and against the 
bpf-next tree. Please include everything in v1 also, resubmit and tag for 
bpf-next in the subject.