Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965199AbXIGKVs (ORCPT ); Fri, 7 Sep 2007 06:21:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757424AbXIGKVj (ORCPT ); Fri, 7 Sep 2007 06:21:39 -0400 Received: from mail.suse.de ([195.135.220.2]:51432 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757409AbXIGKVi (ORCPT ); Fri, 7 Sep 2007 06:21:38 -0400 Date: Fri, 07 Sep 2007 12:21:36 +0200 Message-ID: From: Takashi Iwai To: Romano Giannetti Cc: Andrew Morton , roger@computer-surgery.co.uk, linux-kernel@vger.kernel.org, perex@suse.cz Subject: Re: hda_intel : Patch + Regression in 2.6.18 -> 2.6.22 In-Reply-To: <1189153347.15955.5.camel@rukbat> References: <20070822222902.GA28563@computer-surgery.co.uk> <20070905083844.6637da1e.akpm@linux-foundation.org> <20070905091633.87cfaa81.akpm@linux-foundation.org> <1189091390.3212.3.camel@rukbat> <1189115313.7275.5.camel@rukbat> <1189153347.15955.5.camel@rukbat> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (+CVS-20070806) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2337 Lines: 56 At Fri, 07 Sep 2007 10:22:27 +0200, Romano Giannetti wrote: > > Takashi: good news! > > On Thu, 2007-09-06 at 23:48 +0200, Romano Giannetti wrote: > > On Thu, 2007-09-06 at 17:25 +0200, Takashi Iwai wrote: > > > At Thu, 06 Sep 2007 17:09:50 +0200, > > > Romano Giannetti wrote: > > > > > > > > > > > > Just one hand up: I haven't tested the patch pointed to by Andrew, will > > > > do asap, but it seems that contains the changes from > > > > > > > > https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3104 > > > > > > > > which are needed to have sound at all on my toshiba (although with some > > > > remaining problems). > > > > > > No, it's a different one. This Toshiba model is still not supported > > > well. The patch in mm tree is basically equivalent with the latest > > > ALSA HG tree, so if you tested ALSA HG version (or daily snapshot), > > > it should be same. > > > > Unfortunately you're right. The patch I posted to the alsa bugtrack, > > extracted from the pshou files, works for me. The alsa-git patch gives > > me a system without sound. > > I stand corrected: by loading snd-hda-intel with model=toshiba sound > works (output and input) with my toshiba A305. So, I think that the only > patch needed to make it works out of the box on top of current alsa-git > is: > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 3557865..496d119 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -9044,6 +9044,7 @@ static const char *alc268_models[ALC268_MODEL_LAST] = { > static struct snd_pci_quirk alc268_cfg_tbl[] = { > SND_PCI_QUIRK(0x1043, 0x1205, "ASUS W7J", ALC268_3ST), > SND_PCI_QUIRK(0x1179, 0xff10, "TOSHIBA A205", ALC268_TOSHIBA), > + SND_PCI_QUIRK(0x1179, 0xff50, "TOSHIBA A305", ALC268_TOSHIBA), > SND_PCI_QUIRK(0x103c, 0x30cc, "TOSHIBA", ALC268_TOSHIBA), > SND_PCI_QUIRK(0x1025, 0x0126, "Acer", ALC268_ACER), > SND_PCI_QUIRK(0x1025, 0x0130, "Acer Extensa 5210", ALC268_ACER), Ah good. I added it to ALSA HG tree now. Thanks! Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/