MIME-Version: 1.0
References: <20230214224735.264894-1-davidgow@google.com>
In-Reply-To: <20230214224735.264894-1-davidgow@google.com>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Wed, 15 Feb 2023 20:17:47 +0100
Message-ID: <CANiq72meQeJU62P-_kzwobPS1tA5vTBnk5CnAWoiiK4GbPn4ag@mail.gmail.com>
Subject: Re: [PATCH] rust: kernel: Mark rust_fmt_argument as extern "C"
To:     David Gow <davidgow@google.com>
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
        =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Feb 14, 2023 at 11:47 PM David Gow <davidgow@google.com> wrote:
>
> The rust_fmt_argument function is called from printk() to handle the %pA
> format specifier.
>
> Since it's called from C, we should mark it extern "C" to make sure it's
> ABI compatible.
>
> Cc: stable@vger.kernel.org
> Fixes: 247b365dc8dc ("rust: add `kernel` crate")
> Signed-off-by: David Gow <davidgow@google.com>

Thanks David -- I will apply `rustfmt` on my side.

Cheers,
Miguel