Date:   Wed, 15 Feb 2023 11:22:11 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Baolin Wang <baolin.wang@linux.alibaba.com>
Cc:     akpm@linux-foundation.org, torvalds@linux-foundation.org,
        sj@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org,
        roman.gushchin@linux.dev, shakeelb@google.com,
        muchun.song@linux.dev, naoya.horiguchi@nec.com,
        linmiaohe@huawei.com, david@redhat.com, osalvador@suse.de,
        willy@infradead.org, damon@lists.linux.dev,
        cgroups@vger.kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/4] mm: hugetlb: change to return bool for
 isolate_hugetlb()
Message-ID: <Y+0w45eacPb8mgvh@monkey>
References: <cover.1676424378.git.baolin.wang@linux.alibaba.com>
 <12a287c5bebc13df304387087bbecc6421510849.1676424378.git.baolin.wang@linux.alibaba.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <12a287c5bebc13df304387087bbecc6421510849.1676424378.git.baolin.wang@linux.alibaba.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?d2CCJKAaNlgh85OEvwnRC9BOM2PYnMr8YHWikYSt0DS+g+BBglF9RWhWM3Xt?=
 =?us-ascii?Q?sSpKOMGd1Wu1uSrOV0MaDQjrz8EczBOPzj8adIOHkFi/xxEfZ3PJOJYYdTEg?=
 =?us-ascii?Q?CnhAQPPsIs2rI8K/YfnolrXKnVYJRh5Ye8ghTddQ6xnbng8ADTU8OTIY08BZ?=
 =?us-ascii?Q?72piaTgDfhAU2Os4MQ6SdZXMwyaBh9r8r5+2iRnQJwvt8rvkplPse2ichBg2?=
 =?us-ascii?Q?yaNylYOd2Ba7z9RTE7v8T/4990COO3YJ+0KV1lRSINlPYbIm0EibLi5+Mmgx?=
 =?us-ascii?Q?lSesb01AFg04RCxnsFsW5bih48s7mLF+RnY7lbH0KXFmlCqwPwpFZD6Ct2s+?=
 =?us-ascii?Q?kz55GqHmZlR74WzzNg9H/tfQcNzl2cj0AlUuuJ++QGuiup06GCIrbwbMGb1o?=
 =?us-ascii?Q?JjkI+rgSZdkULG9RSCGKvPSmzaQGOcpP7y3phNNRCTjgr4Oip90fS68C05vP?=
 =?us-ascii?Q?pK1zRoZZERjYes8DEcYJh10OG9blNfQML+jKPRfs8+CmsqimX+9mRAn1/Kti?=
 =?us-ascii?Q?0SJU7Iv7u59N0dM2HMb5ZlSTEiULD7ui7MV8YPgLqQX73FN++y7+axB/YZb/?=
 =?us-ascii?Q?Lla/cPl4KDAtybgHwlsgp1URBD11Y+xoCg17uaP0BuKfPZOd+AIpPCRQMIWr?=
 =?us-ascii?Q?PNpbjgw6Rex2AZmIzoxXiWKfm7ybcxknKXCsVMddrEZ/dsJvf/g+SfmDeD/r?=
 =?us-ascii?Q?Jj1UyhGt9EOpGzImr8kx7yDd7UfCDEj2vutfbN3l68vkhB6gV5XBxvgDRTaW?=
 =?us-ascii?Q?/ukYESR0Xnvh3ZoR+jSmXcgKl1s+sc6VnjYSv+MXDUighWFJYVyoX6itq0zr?=
 =?us-ascii?Q?0bF1CC1xSzkWYztRrN7KTnuObbArgu3XNzdB/5895T7A8qO9iSC/fv6LXFLA?=
 =?us-ascii?Q?asgMgW8n4kJFo0oZ8mUNoRe7JK4UKwgWBOxF9nkzJ37aIffEHlSpBM9qcbkR?=
 =?us-ascii?Q?E7HwpXxMQh3tW+cYJ1b3gleoD0rVnsCSLEBNP5s3UqXz8LRK2U0xrRnjMHJI?=
 =?us-ascii?Q?xXpSD0JQqmNZyp8TN5cF6vF3FyQyScRaz+bztIy9sh0FB/IDifUnnqMpRQHd?=
 =?us-ascii?Q?mCYw/eaQ0BuiKWPbqYtHl318iL4JvJMPAN2mQnih3s8KU4+tdplr6/ZNudos?=
 =?us-ascii?Q?dqomBjsjBnmJwj37KzN8zpl77erWgAoI5NmzwI2gHWEqzrx5ba4U2YMa3uzP?=
 =?us-ascii?Q?G8gLFtaUQgSuSRdOZh2eZy0Cthy0vW64XDQWFYXzxvyQVnSW4K2O2xtLbbs7?=
 =?us-ascii?Q?01zewAPzjrycjPLuTLzhQbO9njletZ36nFVBdiI+tueefQk3t0a0sIoRlh8E?=
 =?us-ascii?Q?Ik8MNdgwVBflolpoPQEZR4b4Twd8+vh8zWgt4X+Fmfn/xFkj5H2gsaTf1F0r?=
 =?us-ascii?Q?S4uJFNtr8ahKzmUgb98rQZRyjemVJaanIzgU/kAsyi5PRP2QMNJHnbGZVpWy?=
 =?us-ascii?Q?iwqAIkP7hdvHab/DV2IuqIWmDPYCcKE5Q2D2A7LjMAtVEXvoWcT7vDcm47sD?=
 =?us-ascii?Q?UnIJv01b2lws2jPw6FdJxB98sMgvkXUyquJbkU8RM3SbqmFoqrnYgknqsuLZ?=
 =?us-ascii?Q?3GfTNR63FpE0vZIfURffsbb89yzApQBo/vjD/UiSzfWTAc0ID6THJ1fv4x/L?=
 =?us-ascii?Q?2Q=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?EXkuPBNSoVdGh/iYPDmInPla7XjXImCTzh3i9LXNW6WGgZWJVbdflMTY3C4d?=
 =?us-ascii?Q?TLsmUSouCS6XU5OZYlRAxBS1pDo0D+mUWQe7KZa0T4NzNXXevWLGd0LWNzxa?=
 =?us-ascii?Q?NcU/d7t/Svrf9ptOUS1kIPt40M4n0ojOg+F0hGYCGjJJ6u1+ws7AXVHWkQtq?=
 =?us-ascii?Q?2p0uvuvuxIoDstNjkTsTvY1ojSYp4gyQ2oEKWYRDmbobFpY+haU6XuvRtZ9W?=
 =?us-ascii?Q?IVUFurGxc4jQiQxQRsFAxeWYcPWTUckYWBoQd4awZB/XvXW+ueIY6Mdmuuw0?=
 =?us-ascii?Q?0KFc5GJDztZVDAAnfpB9PvL+QttR44uKlV6Az2dla8FNUc2ew/lESw5HGov5?=
 =?us-ascii?Q?wTkQZgV8Qcr4sQGdsVXh/bBxP0UCk30kZcEvbA2jBM/OOPZNYeJKsVc9xSow?=
 =?us-ascii?Q?+PFE1lBLQZK7rzBLGzVxRN4STzoP1xEPeAcoIjEeOz/iUUDSYYJaqksk/5XQ?=
 =?us-ascii?Q?O1HoThi2LdhQTJiuQJ/75ixeLFqKA4fi7DSizOZR92hcNMftm5HPLzKyrDQn?=
 =?us-ascii?Q?izLHl5mtTC2gNqIvDg98Elq7hll6eycAnOIOWVR9Hoh8/HT0a4Cb5Z4EyJSA?=
 =?us-ascii?Q?2rgNmdq35ztk+cn1FWS6Y95onJqr9di3lozDrtfTDsAh+bqEXgDVns9cVwdx?=
 =?us-ascii?Q?tfzHAFqiUPT88sfOylhoUSXfZJ6KPA88/fANJ4uygZrBlT80j5XLF1bzYvBM?=
 =?us-ascii?Q?GxUZAxhjhrQSUOFEgNwTAMw2dm9Ve8REvbrAZlErBVvGoPcC8ctAKlmZ4K9x?=
 =?us-ascii?Q?jUYafULXMeWSYHJfvv44Vnp4snCEDBrf2ACHTzxj0liePbYbzxkDMDDB7FA5?=
 =?us-ascii?Q?bJLLiolPQJD5ZeabzGJZvhTFtWyiupnfq/FUyg0YR1n7+WaHnIzk75tGabUe?=
 =?us-ascii?Q?gLuulD6S4amegIa3C4UHWrneVN8kkiimoMHN52HDikyP9TqGlDk9WKQAYmyn?=
 =?us-ascii?Q?zLiXXKmNzxSaaMPkhMpT5xJ0FzmSHoprXoE1pnN38g3ADAD6T6FKj8oFX1iD?=
 =?us-ascii?Q?PcS4rwNPDXkJXrF0Or7SEXm2whAeI9YHnbJ3u/o1/kJYKrxC4BvtUKG6Y78M?=
 =?us-ascii?Q?rsdR/RB2cUXSJ/chPWrLZrKLWxTHjYYm0Cb/Lpe90IG2Vva1fZE0fx0EO/XY?=
 =?us-ascii?Q?rt3gkWBpgELWUCT6E1vGeDWwfVvRIhcqiAKAO72RLRY2atlRP/8iBatfLyk6?=
 =?us-ascii?Q?fDWtAG3v5W5CfZyO?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ceffa215-fdae-471c-ead4-08db0f89f191
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 19:22:14.3121
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 36OyGTLOX1q8saBDYJjDfpnAdpa1790LZIQg1VEryrWBL4HYzcL/eIyWO8CPSJdmBUmXdFZPBDcD2JvMuYNkug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB7030
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-15_10,2023-02-15_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0
 suspectscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 adultscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2302150171
X-Proofpoint-GUID: dXyAGSgFGGaJOXtwmN_W4GayKuySB0oO
X-Proofpoint-ORIG-GUID: dXyAGSgFGGaJOXtwmN_W4GayKuySB0oO
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 02/15/23 18:39, Baolin Wang wrote:
> Now the isolate_hugetlb() only returns 0 or -EBUSY, and most users did not
> care about the negative value, thus we can convert the isolate_hugetlb()
> to return a boolean value to make code more clear when checking the
> hugetlb isolation state. Moreover converts 2 users which will consider
> the negative value returned by isolate_hugetlb().
> 
> No functional changes intended.
> 
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> Acked-by: David Hildenbrand <david@redhat.com>
> ---
>  include/linux/hugetlb.h |  6 +++---
>  mm/hugetlb.c            | 13 ++++++++-----
>  mm/memory-failure.c     |  2 +-
>  mm/mempolicy.c          |  2 +-
>  mm/migrate.c            |  7 +++----
>  5 files changed, 16 insertions(+), 14 deletions(-)

Thanks,

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>

-- 
Mike Kravetz