Message-ID: <c3b6efc8-4f47-449f-d3f0-1f16ae756bee@amd.com>
Date:   Thu, 16 Feb 2023 03:21:15 +0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v2 0/3] KVM: SVM: Fix GATag bug for >256 vCPUs
Content-Language: en-US
To:     Sean Christopherson <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Alejandro Jimenez <alejandro.j.jimenez@oracle.com>
References: <20230207002156.521736-1-seanjc@google.com>
From:   "Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>
In-Reply-To: <20230207002156.521736-1-seanjc@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHoxMG5hTnNmQUp0cWFzL1c0bUswam1OZ0UxdThGNFh1RHBLWndvV25TV01F?=
 =?utf-8?B?UjJoMWhiNDgvTjYzTjEzaDI3a1FlUGlyc0N4YWlZdWNGaEd4dDVnQlZsV0hP?=
 =?utf-8?B?R2VVTU9MeG94bEFRT09iS1orcUY3MW5lY0lPT1dQamhGcmw0YmFCaHJFUmdE?=
 =?utf-8?B?TFR6UUlkb0hENDZqOHE1ZjFHU0FTWVVvQlVhS3BVcE9yNEp2R2lkV0xVMjRC?=
 =?utf-8?B?SVlTVTZ1Qmh6NUZoOTZzZHhsRXozZDJEYWRTVHZQM2ZsM0cxMmZReVlJUzFO?=
 =?utf-8?B?b2k3SENjbXc4a1VONUkvcnRYYTRjQzlIeGt2ZFBKV2ozRnYvcjh2ZWVlUFJD?=
 =?utf-8?B?Z0FqK3Q3NzFmMTdWZEFlMzBId0ZRUTRaanNSUmtGNXNpNlMwZVlZS0Z3R0xP?=
 =?utf-8?B?ZTE3VW9NK2ViNXF4NEdaRVh5ZVp0U1JBelBIdDJZRlVwdG5tWWpodFJIeXZh?=
 =?utf-8?B?WDBldm5iNEZnRlA5MDVmOE03d3REWi8rN1FZSk81UHBaQ2FhQnJveDd4b2VG?=
 =?utf-8?B?QUhBL1M4NVNWRGFiS29FdGhQSEdBNFdqL1FOeXIrQy9uUm0wektpUzMxUW5Y?=
 =?utf-8?B?SVpiaHZla2JJU0VxNVdXOGtNcTVzWWlGeUI2L1lId3ZrdmxoWSt1Q0oxT0sx?=
 =?utf-8?B?SWxSUUxnQ2IzZmZoTUhsSmFhai82UEdQeVU2c2VaRk1RMnBDaEc5SHVPSEdU?=
 =?utf-8?B?VjljakcvOGMzSjZBaWFGaThSem9mVFlhYWx4QmNnUlFua1dHbStvWkxJQ3p2?=
 =?utf-8?B?dmJnam5ObWZsNHB1a1BWdXYzNkljMmxmakNsWFhVbVVUOTdNL0ZVc0ZoWUNG?=
 =?utf-8?B?MzdYcUloRWtEaHBVUUNRdUlnOE1KRFpEOW4weG1jZ2xXUnRkS1Z2dUpiT0hj?=
 =?utf-8?B?SlIxTitNNUo4TU5JQnZnT2FUQUNZdks2Q1Z4bWlTUXViTE5IM0NmbXBxU3lJ?=
 =?utf-8?B?QWV6eGFhN25Xc0tibi94ekgzb2hOcHE5Z3Y1bDJuMkZBcmhUQXA1VWlDaGZp?=
 =?utf-8?B?Q2NzNmh6R3pjZ1QxdzNsZG1jeG1tZVczOEVlUGtiZnNUQzJuSHFKSXdTN0tT?=
 =?utf-8?B?aWdkYzgvVnlyNHVYaVNtUmZZbjJCRWVPcWJha2phSFpackZvOUdoZjQxcWlT?=
 =?utf-8?B?MGlDRkFIVUNTRmRiZ3N3SWE2Q3hLcW1VaDY3NHptUU5BWDdJK2NCN1V2cnFV?=
 =?utf-8?B?Y29RbGU3ZFNHZHFON3A3dlcyTjNaVUtJOGZtSUc0STFobkpaOHMvRGpEclVJ?=
 =?utf-8?B?WDNZeCtZeFBOMW8zcXAvbmNtQ1JqOHdqbTFxa2dzajZEYkIzMEZmempwNjBi?=
 =?utf-8?B?UWxwQ0ZLZXZLeFU4clIxOUtKa0I0SUNPZUs1MVRRNzJNN21rS2NneXdlb3Jy?=
 =?utf-8?B?UHE5Q05qS1hwL1dvSys2QmVvT2VkYXhNOHB5M0lZU2l1VDVQSHJnM1YvTXF1?=
 =?utf-8?B?TXIvaXZGTkJHK3dkaTVtSk1WY1VNTktQOWhvQjdmT2loZDBmWFkzeXkyV2g0?=
 =?utf-8?B?aFI1cDdZVFJVdGZvMFliOXJOLzY4MUh1OGUzbDUyL2pPMGhBRGR2L1ZYTHJp?=
 =?utf-8?B?MVZLS3NkaHdCK0tnTDlHb1JOTUNxMUN1dVFsWmZNLzlvNy9ETjczZ1pCNlZr?=
 =?utf-8?B?WFliTnZ3ZGlEVGZDd2E0eUd1NlNCa1ZWdWdMcERSUDl0WVpod1dZa2pUS3lq?=
 =?utf-8?B?dG1GQTBaeG1LN1oyRElSVitJMkxjdURMK2ZJa0RObmdSQ2VrMmVDRHhYc0ps?=
 =?utf-8?B?Rk8wSXIxY2Y2NTVsblBncTdYZWpjZ2ZlTzhBUER5cXozUTZFbkdoekU3MHRS?=
 =?utf-8?B?SlhhOThhT1hlTGdTR2MwQzUwTldjM2djTi9IdmFJZXNaTStWUHl2ei9jZTF1?=
 =?utf-8?B?UVU2N3lLK2pSY1RPUDdjcytvQ1l5MGxYeUp1Mi83eWlJeXJlVi9JVU1LN01D?=
 =?utf-8?B?VEJzOGRmeSt1NUdaS0NZSEhHclo1ZlVkcnVwa1FyYUFQU01kNlN6L0JMb2xt?=
 =?utf-8?B?SUNFRVY1TUZ4eDExcXdtTDBsSGpUaC9QL3h5VmpEdWJZSGZ6RHg5VlJMR2tJ?=
 =?utf-8?B?bFc5MnpLc1Y1WGNyYTdkS0RTVytDZk5NSCtqRXRtaVdUQXhubXFha01WNGYy?=
 =?utf-8?Q?MEV6jrxlD3HJharwfm6dCO/O5?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f6c19db3-ae3e-4310-0c28-08db0f92357e
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5445.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 20:21:24.3587
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: E+nxzpyF+MoAn2HMqfsY6QVlS2UZb9ayx/RnK/zeC1kO5iKM4NPuEAVCNdDx4UwFadxqERPn0qKrZnWU2/BkAw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4370
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/7/2023 7:21 AM, Sean Christopherson wrote:
> Fix a bug in KVM's use of the GATag where it unintentionally drops a bit
> from vCPU IDs greater than 255 and as a result wakes the wrong vCPU.
> 
> Suravee and/or Alejandro, can you give this proper testing?  It's compile
> tested only at this point.  I'll do basic testing before officially
> applying, but AFAIK I don't have access to x2AVIC hardware, nor do I have
> a ready-to-go configuration to properly exercise this code.
> 
> Thanks!
> 
> Sean Christopherson (2):
>    KVM: SVM: Fix a benign off-by-one bug in AVIC physical table mask
>    KVM: SVM: WARN if GATag generation drops VM or vCPU ID information
> 
> Suravee Suthikulpanit (1):
>    KVM: SVM: Modify AVIC GATag to support max number of 512 vCPUs
> 
>   arch/x86/include/asm/svm.h | 12 +++++++-----
>   arch/x86/kvm/svm/avic.c    | 37 ++++++++++++++++++++++++++++---------
>   2 files changed, 35 insertions(+), 14 deletions(-)
> 
> 
> base-commit: 32e69f232db4ca11f26e5961daeff93906ce232f

For the series:

Tested-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>

Thanks,
Suravee