Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965489AbXIGMCt (ORCPT ); Fri, 7 Sep 2007 08:02:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965275AbXIGMCl (ORCPT ); Fri, 7 Sep 2007 08:02:41 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:4494 "EHLO spitz.ucw.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965251AbXIGMCl (ORCPT ); Fri, 7 Sep 2007 08:02:41 -0400 Date: Fri, 7 Sep 2007 12:02:20 +0000 From: Pavel Machek To: Stephen Hemminger Cc: Dmitry Torokhov , Len Brown , Andrew Morton , linux-input@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fujtisu application panel driver Message-ID: <20070907120220.GB3901@ucw.cz> References: <20070702111724.43ee5b43@freepuppy.localdomain.hemminger.net> <20070903095847.72245af4@oldman> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070903095847.72245af4@oldman> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 896 Lines: 23 Hi! > > Thank you very much for updating the patch. I have a couple of requests though: > > > > 1. LEDs shoud use the generic led subsystem instead of input layer. I > > do not have plans of adding any more LED_XXX constants and I think > > that adding any LEDs not directly relating to keyboard state was a > > mistake. > > No, way to much work for one stinking LED. 'Lets do it wrong way because right way is too much work'? Come on... doing let driver is 30 minutes and 100-or-so lines of code. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/