Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1390EC636CC for ; Wed, 15 Feb 2023 21:10:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230236AbjBOVKz (ORCPT ); Wed, 15 Feb 2023 16:10:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230320AbjBOVKi (ORCPT ); Wed, 15 Feb 2023 16:10:38 -0500 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1C1B86BA for ; Wed, 15 Feb 2023 13:10:27 -0800 (PST) Received: by mail-pj1-x102b.google.com with SMTP id d13-20020a17090ad3cd00b0023127b2d602so97363pjw.2 for ; Wed, 15 Feb 2023 13:10:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EDdD3my77qn6wRP3Aeb9AHJZUp49fzjL8qhk4LFtnT0=; b=NOIj+y/SIW5EXhl+5s2A0AZIelMW/4+L8sfKFwWlO/qN3ZZvPGSSSJgqvAfMXsq3Gi wcz5SerJ87A88bAAfMHLnM2k8MNtV+n6uSzaiGL5+9scPr6JnX9mIQ3SvLgMQTQ0wnSa x1J7IqoRfWj7XcYPoW+sfHCnjDsHa//AF21di/ry0nJD9QU+Ji36g5827uJii9n7RGlV wTV23PuMQJS/2ni4eaYD+veAnzIyscwobsgK9WpLMVqwiOJQzbLEfrpn2fBAD4o0xSPa zrD+/m+h1XYhDsoqqd1I+uGMgXsND0tsjutBUu5jjoK3S/vs61BIgI/Odg5VSZhEnsk1 BBTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EDdD3my77qn6wRP3Aeb9AHJZUp49fzjL8qhk4LFtnT0=; b=p4XvT8eipI4pNvHWL06OetiAP793ElhtXrJcbYlFHDkhc2q4eJXFlTW9HMust8ttjM 29UgFHtrIJVRwV8hxQUnT6DAnqU53z/uCApanYeDwn1QDD7ZonjvNTBTgQLNbgx3eU8f 9oKuHMWoAI5gX2i5nVhl8nkdbsQtRzqKfJf3mHE6/xrf+ftjzRj7JAI1gwM5ub/ThBN1 4YPBIQvKSafVC8FAv4M2cdL1/sITQDogixs9eUB4tXec5m1Gfppb+4T5jNvlh+Ojaa7F BzvVoKdIXyA4kIri8WbWq4/CneWwuZH4EuZky448ku572knOx+lM6cJCI5d9DIiu3M+p cygw== X-Gm-Message-State: AO0yUKVvafYt2Q6Y4eYhDe7DjodD1u0uwVijnA+HjgZapeLGslt6c82U Fmv7apqXQKljsqm4TbajsdlDYg== X-Google-Smtp-Source: AK7set+GQyo0HVPK9m8l+R8hijG5IMSYZv2I8dqxXXJmjdHRJ3q+g1hr7ogYcfpSDJaPpdz0uIKAyw== X-Received: by 2002:a17:902:da90:b0:199:38a:afd8 with SMTP id j16-20020a170902da9000b00199038aafd8mr4656597plx.19.1676495427064; Wed, 15 Feb 2023 13:10:27 -0800 (PST) Received: from google.com (223.103.125.34.bc.googleusercontent.com. [34.125.103.223]) by smtp.gmail.com with ESMTPSA id e5-20020a170902784500b00189e7cb8b89sm12486546pln.127.2023.02.15.13.10.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Feb 2023 13:10:26 -0800 (PST) Date: Wed, 15 Feb 2023 13:10:22 -0800 From: David Matlack To: Vipin Sharma Cc: seanjc@google.com, pbonzini@redhat.com, bgardon@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v3 3/7] KVM: x86/mmu: Remove "record_dirty_log" in __tdp_mmu_set_spte() Message-ID: References: <20230211014626.3659152-1-vipinsh@google.com> <20230211014626.3659152-4-vipinsh@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230211014626.3659152-4-vipinsh@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 10, 2023 at 05:46:22PM -0800, Vipin Sharma wrote: > Remove bool parameter "record_dirty_log" from __tdp_mmu_set_spte() and > refactor the code as this variable is always set to true by its caller. > > Signed-off-by: Vipin Sharma > --- Reviewed-by: David Matlack