Message-ID: <5d57f42a-1bfc-5e6a-bb49-556ecb7402af@intel.com>
Date:   Wed, 15 Feb 2023 13:13:40 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: [PATCH v2 4/7] platform/x86/intel/ifs: Implement Array BIST test
Content-Language: en-US
To:     Dave Hansen <dave.hansen@intel.com>, <hdegoede@redhat.com>,
        <markgross@kernel.org>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <rostedt@goodmis.org>,
        <ashok.raj@intel.com>, <tony.luck@intel.com>,
        <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>, <sohil.mehta@intel.com>
References: <20230131234302.3997223-1-jithu.joseph@intel.com>
 <20230214234426.344960-1-jithu.joseph@intel.com>
 <20230214234426.344960-5-jithu.joseph@intel.com>
 <a24c65f8-978d-8968-7874-6b83e14b01ba@intel.com>
 <d9d18954-8434-4c85-88b8-8e1d99cd6a4b@intel.com>
 <dd501d6a-e7e9-be82-24fb-33b18fb6192b@intel.com>
 <b67d2125-4075-4eac-4cad-8e315b866144@intel.com>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <b67d2125-4075-4eac-4cad-8e315b866144@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUdwM1hMZmpnTkNHV3FHdWtKTHp6cUtvYVBJYUlhWTY4WU40L0pEcE5qTlFC?=
 =?utf-8?B?d1JlNmtxOVhEdzdxYVBiSVIvU1Y1RElwTkZROVI1Z082eEtORkRQR0E2bTVB?=
 =?utf-8?B?K1VrU1JRUlY4TU1VdFFvZ1VXYitaY1hySnlnTGw5TFJVM0JkWG90aFgvdEJw?=
 =?utf-8?B?NHlXYzNzMERROTVBaEFOZ01RaURxU2NHOHhCaGMxdEZVYktadklRbnU0OHZ1?=
 =?utf-8?B?b3N2cmNLQisvNWtsRnU1NkxINlR0M09PUVVCOUQ5U1JXdDB6TE5hc0FiVmEy?=
 =?utf-8?B?TkZUMDIxTlNpZ1JvdFQxYU1POGZxc1lBQlV0UEdpak8ySGsrSXNRUm56SXFo?=
 =?utf-8?B?L1NJeHdVL29DMXNuM1h0QTQ0TDYxblV2Sm9ZMVdRS0lMd1R2eXp5T1EvK3l4?=
 =?utf-8?B?SU1MT3YybzVLbXpMb2NFSkpTalV2WDNRLzJ0WnVaZVRjNmFnTVNMTUZ4V0Mr?=
 =?utf-8?B?azJ0OHZNdkR4cGN1YzZXNjBjYnRkUUliWkcxM3l0RWVLVVh5N0dEVkZ2NFhR?=
 =?utf-8?B?Um5yMS9iZ2VueDhUNVB1dHZIZkNudHFNVnBuM0QyRkNyWVM3RUg1VGEyZGsr?=
 =?utf-8?B?OVNBNjV2ZjVtOEtqc3dTbVQvSTFiYnR3TTRpbG5SL1B4ejRXTVlKK3dtSnV1?=
 =?utf-8?B?YW5uUUgrY1Q3TG42amJiUncxQjBRazE5TDRVMmlOWkpzVk9TYmpqampURU1m?=
 =?utf-8?B?MWhmeldmU3BRMHhnd3RaVGJqSGhkOHhtSk1OdU5TS2xCRzk3cHE0QVNmNUxC?=
 =?utf-8?B?cUQxd1dWbk1tajBoa1ExMFhmWXhkMVVWNjVHWk9tWUVCN0RXWDFoYWh4UTFI?=
 =?utf-8?B?Q3FqZHV5VFFENk1sbXduTzNUSjFkNHVSd0lLLytMRGFnQjlTT05XNG1yeldH?=
 =?utf-8?B?d3JucWdrZ1BlbGJIT0FQTU5laURiZ3J6NXRLd292UnByRTFyQ1NJOFhETEtu?=
 =?utf-8?B?UXRiZHljcC81R1ZVQkZxN2UrUTlXdHlwaU5Rb0d4clQ3ajlZcUNpcXNWZnZm?=
 =?utf-8?B?K1NiSStTNndVZURibnl2WDdjYUsxS20yajcrL2VaQ3lUNitncE81K2phSWMr?=
 =?utf-8?B?c0JGTmY5cVpNQXJhS2U0aHFoOHNrODdVdGRrVU5DaG5renZlU3FoNnZ4THJh?=
 =?utf-8?B?M0poSlBNdmpXZkFZbk9WN092SWh1a2tFbUZad0QyTUxxbGk2S3RzWHl2WjRR?=
 =?utf-8?B?L3gyekMxRDk3MGVJZWlvRjJ1aGpWN3pRdS9NSE1zYmpWelZzQXhiUnQ0cnIy?=
 =?utf-8?B?MGxOWVF3K3JmekdVL2FTSy9xalFGL1htazlGN2gyVkdnQlRJaEJIUVBINFBv?=
 =?utf-8?B?MWNPMjBIUFU5S3N1d2FPRi9TMGNVd2pTVnpSUVh4T1JjS0RVTUlJMkFheXpW?=
 =?utf-8?B?L0RXcDRlWS9GNEhVcG1rejgxbjZWQkNacG5BWm1aeGhPVlgwVWFDRmpMWm9W?=
 =?utf-8?B?OVc0dnVoMVRVdFRjRktnK0lOa3kwYWd5VkxUOUsvQzlySytqYzBpcCswa3Zk?=
 =?utf-8?B?dkducWUyM1htb1JlMklMQjVVc3B4cjJsbWxWOUNkOXdneFhpRHA3YzVmenVu?=
 =?utf-8?B?RHI1NkpqU2lHWUxhc25MMUY3K2JhZWdzZFhMSUtaSmJUcVV0OGYveFFxbW04?=
 =?utf-8?B?UlRvTTd1RmdLRmlzQm4vUXQ0cXFvWGVlZ3VFWE9VV2FPU2VidzNIV3NRL1ZO?=
 =?utf-8?B?eWhtMnpzMUpOei9JYVErekI5Mm5BaHhmMlNkemtESU9MNVRlWi9KVUNsUVFv?=
 =?utf-8?B?Q0dHN0REN1kzQ281L2dLMmVpQ3d5NjkydTdYZzNVOElmdlJLT256UzJpWTBO?=
 =?utf-8?B?ekI4K3NCV0FsQXpvWWpHbG9WcjJiY3E2TzJXei9QeXQ3cnFZTHFnbWJkbTlJ?=
 =?utf-8?B?UHl0L0FZcG5KMVZFUWVXWlF6d3hxZnpiQzhPVXR5eFRLak5UV2VUcGxYeVpp?=
 =?utf-8?B?V1pKd0o0VHJ1MEpKTUxWRlJ0N0RtRzB5VEVHMXRtWGc1cXVVdnVlVjAyQkNy?=
 =?utf-8?B?QldOalJ2bG51VkpLbk9McEFQbEVVRHordFBrbi9uMXJ5VGNESkhqVnZRSFlJ?=
 =?utf-8?B?eGNpQVBXd1MvOFdGcTZ1NWM5eklqNXFZWDJoaGQwRU5YNld2VnAza3pvRkox?=
 =?utf-8?B?eDV6VUlIQWQ5ZEpZTFJKdWZHS1JIVk84SHNEYnl6QUlnMFhVcUZkd2VxaVNG?=
 =?utf-8?B?OXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ef4948a9-f757-4e0a-195d-08db0f998443
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 21:13:42.8647
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a8xcjCScl/nA9Qq0GbFKnLRpcSS5As4LHgSdCbI6AccFY6TzElKeN5dO+IFD+6vT4DC+KBpvqy6TAPdDbHeeog==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5239
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/15/2023 12:26 PM, Dave Hansen wrote:
> On 2/15/23 12:22, Joseph, Jithu wrote:
>> 		trace_ifs_array(cpu, *((u64 *)&before), *((u64 *)&command));
> 
> Uhh, you control the types in the tracepoint.  Just make them compatible
> so you don't need casts.

will change it to:
trace_ifs_array(cpu, before.array_bitmask, before.array_bank,  *((u64 *)&command));

i.e will pass compatible types for array_list and array_bank. And for the last argument, we need to dump the whole 64 bits within "command"
into trace output . Since the suggested change replaced the union with a struct, it is simplest to cast it to u64 needed by traceoutput.
So I would prefer to keep the cast for the last argument alone.

sample trace output ... 

<snip>
  bash-4562    [001] .....   761.563749: ifs_array: cpu: 10, array_list: 00007fe0, array_bank: 0101, status: 0000000200007fe0
  bash-4562    [001] .....   761.563772: ifs_array: cpu: 10, array_list: 00007fe0, array_bank: 0002, status: 0000010200007fe0
</snip>