Message-ID: <a0934601-3a7c-dcb5-8d23-81a3cdfc2c4d@amd.com>
Date:   Wed, 15 Feb 2023 16:34:48 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: [PATCH] drm/amd/display: only warn once in
 dce110_edp_wait_for_hpd_ready()
Content-Language: en-US
To:     Hamza Mahfooz <hamza.mahfooz@amd.com>,
        amd-gfx@lists.freedesktop.org
Cc:     Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Wenjing Liu <wenjing.liu@amd.com>, Jun Lei <Jun.Lei@amd.com>,
        Charlene Liu <Charlene.Liu@amd.com>,
        Alvin Lee <Alvin.Lee2@amd.com>,
        "Nagulendran, Iswara" <Iswara.Nagulendran@amd.com>,
        Tony Tascioglu <tony.tascioglu@amd.com>,
        zhikzhai <zhikai.zhai@amd.com>,
        Wesley Chalmers <Wesley.Chalmers@amd.com>,
        "Leung, Martin" <Martin.Leung@amd.com>,
        Mario Limonciello <mario.limonciello@amd.com>,
        "Leo (Hanghong) Ma" <hanghong.ma@amd.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20230214211254.233468-1-hamza.mahfooz@amd.com>
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <20230214211254.233468-1-hamza.mahfooz@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUFMdGlRdTBqeUdMMVVseUF5WVYzdWsyVGpPN1pQOHRNd0s3ZHlYZzVNZjg4?=
 =?utf-8?B?TlVOZElZdll4bHlZdzR0cUl3aVZZdlJsWC9ENzJFZVNoSmF2WnhjTi9BTExp?=
 =?utf-8?B?VGcybzBzWmJodjdtT1Mwd2JRZEluZXAzMm9XeXNlbXRmYjJDalJHaWhvOERG?=
 =?utf-8?B?Nm9LWlNHODZOcWJOaG9OVkVJb2Vub3YwNW9LaHY1QTYwbzJqT2xYRXczS0VP?=
 =?utf-8?B?L0RnMzhJVENRK1VOYVhXSTAzNDNoNVZ6bHpCN0w2Ty91SWdYeitOOTlKcmxD?=
 =?utf-8?B?ajJ6QkZFa2wrbkVla2FYbTBRbzBPdXYxQUJ2OWt3M0FvV2pXOGVUQUlxdFQr?=
 =?utf-8?B?Wm41YktldFF6MVI4bG42aWdMUWpDYXcwUjBTY1RKTytiNGd5QStXclBsVHNU?=
 =?utf-8?B?eWtkZ210amIrbi9KdmM1WmFaejNLK2RtM2FzNVRNNS9TeXM4TDVpUlRGVTJt?=
 =?utf-8?B?ZFVHWW5QenJnUEYydUVLeWxXcFhqTEMyQTIyMHFsMVF0N25La1BEdCswck5L?=
 =?utf-8?B?RVRtQ0h4M0tXY0ROOXh6Q05OVjBzbGRlVkZHUno2RlB0bzhvajFZWnFtOXpm?=
 =?utf-8?B?ZjA2OFNKS2ZhTFQzMUlsWXo1VFFibDhYVkhxdDBzOGR6SFU0YmJWL2l3WlZv?=
 =?utf-8?B?b3NDZXVrSUh6S1VEK1h3SVVzdzhoOE42NFg0NUk2M2lrQXpqZGdSS3VWamVa?=
 =?utf-8?B?YnltRFJYZDhCNnhLODBGeGVDOGwrU0RuNEh3cDh1T3A0MndxYzE5cHc5eXZS?=
 =?utf-8?B?bVRzcTBKUmxLQXJGelJ4ckVZUHRyL0tXeHRBMVh1c2xzRU9xeWp1MUNzTldk?=
 =?utf-8?B?UDRicm1XWlBPWm05ZHliaHgrU2JDM2c1MzlIUE83QlQvQ3hUYVhrbzhNQzFz?=
 =?utf-8?B?RDltczRwS3REbkJzZzJURHVvcnQ1M3F3QW5IMlQ1YWV3YkVCRlluRW9YWFJE?=
 =?utf-8?B?QmdnZWhKaW96b2U5bzJDWjNpZnlLQTlueUN4WGhnUEd5dU4vMk9PS0tCVU96?=
 =?utf-8?B?RjhLNyswa1RHV2FETWl1elRRWnZVUjN2SGxSVG5RZ3BRSGg2VG05WTJYcWJ2?=
 =?utf-8?B?NSsvSU9HSnFDZWtFTTJwZHoxRGc2L3k0QVViRlBCNmkrajBqTldzZVI3WVRJ?=
 =?utf-8?B?VHRhQVF0ckpQbHMwZGZHdzA3NzNMT0RyVkV0NVMvKytNdGQzUVNwTEhBZFdK?=
 =?utf-8?B?Rk5Ed2hZZStCbVdTSU9vNGltOWNUSGwrVlVsMDQ1RVlCanAyR1JEZ3dnYmY0?=
 =?utf-8?B?akJpejVSZk1zMC94bnI1VTdIdnB3dFhSMjR3RXNxc2RkakVCbldPSUZjR1d4?=
 =?utf-8?B?ZFZnQ1dwRk5oUnRrM2lTQnE1dElleXV4N29sTjRkRS9BaFdFT0VBbnIwaTFr?=
 =?utf-8?B?S2djWWVhNXRkeExQTUFXUUM0SkZKaVlMOFlvcGlWcE96RHFlUDYzL2hlZHRs?=
 =?utf-8?B?OXExcThMd25IenQyRkJYL0dIeW1oQThDdXhXSlMvN1cyN01QbXI0ZVdTaXh6?=
 =?utf-8?B?QUlodk9pbmVTTVRXdjY3b1JWaHlrRWFod25ETGxtL0xsTUswQjhoZStiZk9z?=
 =?utf-8?B?U0E1dkNGVDhDU0pWT3czbllUMTgxc2V0YzZhYWVYT3FqUzdvQ255c2FTWHIy?=
 =?utf-8?B?YnhHdnZ0TGhxZlRrK2hiZ1pJRUljaGtGbG4zUUIybm1oR09jVGlENlpYSTFH?=
 =?utf-8?B?ZkpEa2VUZVlrRmxaMGhMMzVQOHhvNjB3NnRQSFhSaXhQYmlVWXRKV25XVmsx?=
 =?utf-8?B?T3VLaXlCVWEyTXc1OHFJUkFjVlF5MlR5VU1tUDQwL3U4RVo2VUFqWGJ1VkxH?=
 =?utf-8?B?Tnhlb3dmSjhFblZ5S0FqY2JYNkZ1SW9GcTM2NzQxMHBGRlZQSW5XMEoxOEE5?=
 =?utf-8?B?R2FhL3JhTG5IcEJ0NTdTbTZjZDdqbTdKWmwrOXNKeEhkay95N2VaajZ4djEx?=
 =?utf-8?B?MWl4KzQ0RVJEYVc1NWZ0RTh4Z2dBSjVlU1JFc0lubGwzL2JlalZlUVVsSGEw?=
 =?utf-8?B?QUptcnNuNVRoT3NqUUNlRm04T2VJMEdMN1BFTC9ybEdHY2F6T2ZkQ1FWNnRV?=
 =?utf-8?B?OFY1bmtpZU1aTmFsNHlPWVNDd3JXSEZlRWJ3djJBOFVRNENkakRVWVd5TFVY?=
 =?utf-8?Q?L16Jbd0CMjY55rEPsgjebvgEp?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e3f602e9-758f-44fd-073e-08db0f9c7bac
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 21:34:57.0999
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ty7RB9oJfqBEQ193o/0EUyDcXgH+UrC0NCqTQdSWCi0feasySkU5klGXKrgEtbeJ0a78oRkx5WUTmAb4dODETw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4119
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/14/23 16:12, Hamza Mahfooz wrote:
> Since, hot plugging eDP displays isn't supported, it is sufficient for
> us to warn about the lack of a connected display once. So, use ASSERT()
> in dce110_edp_wait_for_hpd_ready() instead of DC_LOG_WARNING().
> 
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>   drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> index fb3fd5b7c78b..0d4d3d586166 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> @@ -779,10 +779,8 @@ void dce110_edp_wait_for_hpd_ready(
>   
>   	dal_gpio_destroy_irq(&hpd);
>   
> -	if (false == edp_hpd_high) {
> -		DC_LOG_WARNING(
> -				"%s: wait timed out!\n", __func__);
> -	}
> +	/* ensure that the panel is detected */
> +	ASSERT(edp_hpd_high >   }
>   
>   void dce110_edp_power_control(