Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE1D5C636D4 for ; Wed, 15 Feb 2023 21:58:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229964AbjBOV6o (ORCPT ); Wed, 15 Feb 2023 16:58:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229537AbjBOV6n (ORCPT ); Wed, 15 Feb 2023 16:58:43 -0500 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A4DD7A81 for ; Wed, 15 Feb 2023 13:58:41 -0800 (PST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4PHBmJ4JzKz4x4n; Thu, 16 Feb 2023 08:58:40 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1676498320; bh=66RYPVgMpz94tBHchX7oiuUA6G3IDTuSBU9OW1M8NeY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=pKqCwJljTt4SGKmbz+G4Yk1mAMdnLK4MLIleTw2C8g8lB+dmvGgsx9dgI11EarFab BoJf8gOMSeG3XTGzG2k0JeJQ6Gpj7rb881NYX+mRrBm+n13jEfiqkCEn280RXYS78I EU32BxU1ArVbJJHmrqFgWLkqWhvmOCBm9TrGox3ec50VLDMjQxrcc1E6PBYuiCwwB9 bhi2+y8QOI3ncfNmNAghVA9I/8qhjje5ub5e27MRis44edHg/jyfHWajHmgTas1Y6z iAbN0Gfxu7C8L6LC9rMuvfEZ9YAfnng7i7HV9x8GjNuSR/fa4iNLdmHk/xJSe17s2W jvsNxsc0oTLQw== From: Michael Ellerman To: Christophe Leroy , Nicholas Piggin Cc: Christophe Leroy , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v1 3/9] powerpc/47x: Split ppc47x machine in two In-Reply-To: References: <04ed69b4226633ab90983d7efb5bd4791078fe71.1676465585.git.christophe.leroy@csgroup.eu> Date: Thu, 16 Feb 2023 08:58:35 +1100 Message-ID: <87v8k2616c.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christophe Leroy writes: > This machine matches two compatibles and sets .pci_irq_fixup > on one of them. > > Split it into two machines, then the probe function can be dropped. That will break the machine initcalls that look for ppc47x: arch/powerpc/platforms/44x/ppc476.c:machine_device_initcall(ppc47x, ppc47x_device_probe); arch/powerpc/platforms/44x/ppc476.c:machine_arch_initcall(ppc47x, ppc47x_get_board_rev); It still compiles, because of the weak attribute in machine_is(), but those initcalls will never match and so never run. cheers