Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB73AC64ED8 for ; Wed, 15 Feb 2023 22:23:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229650AbjBOWXC (ORCPT ); Wed, 15 Feb 2023 17:23:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229493AbjBOWXA (ORCPT ); Wed, 15 Feb 2023 17:23:00 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73ACC28D00; Wed, 15 Feb 2023 14:22:55 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E5470B82425; Wed, 15 Feb 2023 22:22:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FAD0C433D2; Wed, 15 Feb 2023 22:22:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676499772; bh=3/B+NZRwzEkNo04hOsRXt8MwWSjpYxIfsEH4O0Y0Iy0=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=lgMebc9/PyCNI2WQWQFGhJ6pEjvuGS4FIDV8Hndf+NKrHLS1WG/DGBpNgqf8fOyYC y8+V3Q2tj+S2zmKUBdMwoObfAcO+heEDDn/va0AU2ijfCtQ4tDaxjdOoA+qCu96qJu tkWdqqKZlqO1cHNQGCQ3kzUKY7M1SSh9fmDTqH1qGb+lN/kKUpvSTLbTM6FeL2JzDg 3qeqvtZTigjAwCmsYZOm8DYFJHs+rNCQMwz1iolZjE/BUncjAH+Fit4Bh2Gox6pFxx 1CSx3J/q9TyNq1z7sg7E7kSGGeSWuf8YWJVgL80Qlbz1kmmdtCqghuKDCBxMa4nZ97 KwdXvAMHmGl/A== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id D10DF5C0F9D; Wed, 15 Feb 2023 14:22:49 -0800 (PST) Date: Wed, 15 Feb 2023 14:22:49 -0800 From: "Paul E. McKenney" To: Josh Poimboeuf Cc: linux-kernel@vger.kernel.org, jgross@suse.com, richard.henderson@linaro.org, ink@jurassic.park.msu.ru, mattst88@gmail.com, linux-alpha@vger.kernel.org, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, chenhuacai@kernel.org, kernel@xen0n.name, loongarch@lists.linux.dev, f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, tsbogend@alpha.franken.de, linux-mips@vger.kernel.org, jiaxun.yang@flygoat.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, linuxppc-dev@lists.ozlabs.org, ysato@users.sourceforge.jp, dalias@libc.org, linux-sh@vger.kernel.org, davem@davemloft.net, sparclinux@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, chris@zankel.net, jcmvbkbc@gmail.com, linux-xtensa@linux-xtensa.org, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com Subject: Re: [PATCH v2 00/24] cpu,sched: Mark arch_cpu_idle_dead() __noreturn Message-ID: <20230215222249.GM2948950@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 13, 2023 at 11:05:34PM -0800, Josh Poimboeuf wrote: > v2: > - make arch_call_rest_init() and rest_init() __noreturn > - make objtool 'global_returns' work for weak functions > - rebase on tip/objtool/core with dependencies merged in (mingo) > - add acks > > v1.1: > - add __noreturn to all arch_cpu_idle_dead() implementations (mpe) With this, rcutorture no longer gets objtool complaints on x86, thank you! Tested-by: Paul E. McKenney > Josh Poimboeuf (24): > alpha/cpu: Expose arch_cpu_idle_dead()'s prototype declaration > alpha/cpu: Make sure arch_cpu_idle_dead() doesn't return > arm/cpu: Make sure arch_cpu_idle_dead() doesn't return > arm64/cpu: Mark cpu_die() __noreturn > csky/cpu: Make sure arch_cpu_idle_dead() doesn't return > ia64/cpu: Mark play_dead() __noreturn > loongarch/cpu: Make sure play_dead() doesn't return > loongarch/cpu: Mark play_dead() __noreturn > mips/cpu: Expose play_dead()'s prototype definition > mips/cpu: Make sure play_dead() doesn't return > mips/cpu: Mark play_dead() __noreturn > powerpc/cpu: Mark start_secondary_resume() __noreturn > sh/cpu: Make sure play_dead() doesn't return > sh/cpu: Mark play_dead() __noreturn > sh/cpu: Expose arch_cpu_idle_dead()'s prototype definition > sparc/cpu: Mark cpu_play_dead() __noreturn > x86/cpu: Make sure play_dead() doesn't return > x86/cpu: Mark play_dead() __noreturn > xtensa/cpu: Make sure cpu_die() doesn't return > xtensa/cpu: Mark cpu_die() __noreturn > sched/idle: Make sure weak version of arch_cpu_idle_dead() doesn't > return > objtool: Include weak functions in 'global_noreturns' check > init: Make arch_call_rest_init() and rest_init() __noreturn > sched/idle: Mark arch_cpu_idle_dead() __noreturn > > arch/alpha/kernel/process.c | 4 +++- > arch/arm/kernel/smp.c | 4 +++- > arch/arm64/include/asm/smp.h | 2 +- > arch/arm64/kernel/process.c | 2 +- > arch/csky/kernel/smp.c | 4 +++- > arch/ia64/kernel/process.c | 6 +++--- > arch/loongarch/include/asm/smp.h | 2 +- > arch/loongarch/kernel/process.c | 2 +- > arch/loongarch/kernel/smp.c | 2 +- > arch/mips/include/asm/smp.h | 2 +- > arch/mips/kernel/process.c | 2 +- > arch/mips/kernel/smp-bmips.c | 3 +++ > arch/mips/loongson64/smp.c | 1 + > arch/parisc/kernel/process.c | 2 +- > arch/powerpc/include/asm/smp.h | 2 +- > arch/powerpc/kernel/smp.c | 2 +- > arch/riscv/kernel/cpu-hotplug.c | 2 +- > arch/s390/kernel/idle.c | 2 +- > arch/s390/kernel/setup.c | 2 +- > arch/sh/include/asm/smp-ops.h | 5 +++-- > arch/sh/kernel/idle.c | 3 ++- > arch/sparc/include/asm/smp_64.h | 2 +- > arch/sparc/kernel/process_64.c | 2 +- > arch/x86/include/asm/smp.h | 3 ++- > arch/x86/kernel/process.c | 4 ++-- > arch/xtensa/include/asm/smp.h | 2 +- > arch/xtensa/kernel/smp.c | 4 +++- > include/linux/cpu.h | 2 +- > include/linux/start_kernel.h | 4 ++-- > init/main.c | 4 ++-- > kernel/sched/idle.c | 2 +- > tools/objtool/check.c | 11 +++++++---- > 32 files changed, 57 insertions(+), 39 deletions(-) > > -- > 2.39.1 >