Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F2F8C636D6 for ; Wed, 15 Feb 2023 23:11:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229595AbjBOXLs (ORCPT ); Wed, 15 Feb 2023 18:11:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbjBOXLq (ORCPT ); Wed, 15 Feb 2023 18:11:46 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 82E2638B5B; Wed, 15 Feb 2023 15:11:45 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F11131042; Wed, 15 Feb 2023 15:12:27 -0800 (PST) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6A9FB3F881; Wed, 15 Feb 2023 15:11:43 -0800 (PST) Date: Wed, 15 Feb 2023 23:09:43 +0000 From: Andre Przywara To: Bastian Germann Cc: Wilken Gottwalt , Ohad Ben-Cohen , Bjorn Andersson , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Samuel Holland , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org Subject: Re: [PATCH v2 2/5] dt-bindings: hwlock: sun6i: Add #hwlock-cells to example Message-ID: <20230215223813.0a578985@slackpad.lan> In-Reply-To: References: <20230215203711.6293-1-bage@debian.org> <20230215203711.6293-3-bage@debian.org> <20230215204026.318d4b2d@slackpad.lan> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Feb 2023 21:43:50 +0100 Bastian Germann wrote: > Am 15.02.23 um 21:40 schrieb Andre Przywara: > > On Wed, 15 Feb 2023 21:37:07 +0100 > > Bastian Germann wrote: > > > > Hi, > > > >> The dt-bindings tools will compile the yaml dt examples > >> and this prevents an error about this node not existing. > > > > This needs to be part of patch 1/5, otherwise it will break > > bisecting. Just squash the two patches together. > > Is this also okay with 1/5 already being applied in linux-next? The idea of -next is to spot those things before they cause problems. I don't know if it's already too late, let's see what Bjorn says (see the other mail). You could either send a totally separate fix patch (outside of a series), or a new series with the correct patch. But for now let's wait how this ends up. Cheers, Andre > > > > > Cheers, > > Andre > > > >> Signed-off-by: Bastian Germann > >> --- > >> .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml > >> index 01b1bbb3061f..38478dad8b25 100644 > >> --- a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml > >> +++ b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml > >> @@ -48,5 +48,6 @@ examples: > >> reg = <0x01c18000 0x1000>; > >> clocks = <&ccu CLK_BUS_SPINLOCK>; > >> resets = <&ccu RST_BUS_SPINLOCK>; > >> + #hwlock-cells = <1>; > >> }; > >> ... > > >