MIME-Version: 1.0
References: <20230216014120.3110-1-k1rh4.lee@gmail.com>
In-Reply-To: <20230216014120.3110-1-k1rh4.lee@gmail.com>
From:   sangsup lee <k1rh4.lee@gmail.com>
Date:   Thu, 16 Feb 2023 10:53:41 +0900
Message-ID: <CAJkuJRjzS6LnsvxO2mhmLVje51YEJhC0r-T6NxsuL9BaiW1hSQ@mail.gmail.com>
Subject: Re: [PATCH] misc: fastrpc: Fix a Use after-free-bug by race condition
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc:     Amol Maheshwari <amahesh@qti.qualcomm.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

As I'm not an expert for the fastrpc driver, I'm not sure about the patch c=
ode.
But I think the bug should be patched.
Please suggest a proper patch.

Best regards,

2023=EB=85=84 2=EC=9B=94 16=EC=9D=BC (=EB=AA=A9) =EC=98=A4=EC=A0=84 10:41, =
Sangsup Lee <k1rh4.lee@gmail.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> This patch adds mutex_lock for fixing an Use-after-free bug.
> fastrpc_req_munmap_impl can be called concurrently in multi-threded envir=
onments.
> The buf which is allocated by list_for_each_safe can be used after anothe=
r thread frees it.
>
> Signed-off-by: Sangsup Lee <k1rh4.lee@gmail.com>
> ---
>  drivers/misc/fastrpc.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
> index 5310606113fe..c4b5fa4a50a6 100644
> --- a/drivers/misc/fastrpc.c
> +++ b/drivers/misc/fastrpc.c
> @@ -1806,10 +1806,12 @@ static int fastrpc_req_munmap(struct fastrpc_user=
 *fl, char __user *argp)
>         struct fastrpc_buf *buf =3D NULL, *iter, *b;
>         struct fastrpc_req_munmap req;
>         struct device *dev =3D fl->sctx->dev;
> +       int err;
>
>         if (copy_from_user(&req, argp, sizeof(req)))
>                 return -EFAULT;
>
> +       mutex_lock(&fl->mutex);
>         spin_lock(&fl->lock);
>         list_for_each_entry_safe(iter, b, &fl->mmaps, node) {
>                 if ((iter->raddr =3D=3D req.vaddrout) && (iter->size =3D=
=3D req.size)) {
> @@ -1822,10 +1824,13 @@ static int fastrpc_req_munmap(struct fastrpc_user=
 *fl, char __user *argp)
>         if (!buf) {
>                 dev_err(dev, "mmap\t\tpt 0x%09llx [len 0x%08llx] not in l=
ist\n",
>                         req.vaddrout, req.size);
> +               mutex_unlock(&fl->mutex);
>                 return -EINVAL;
>         }
>
> -       return fastrpc_req_munmap_impl(fl, buf);
> +       err =3D fastrpc_req_munmap_impl(fl, buf);
> +       mutex_unlock(&fl->mutex);
> +       return err;
>  }
>
>  static int fastrpc_req_mmap(struct fastrpc_user *fl, char __user *argp)
> --
> 2.25.1
>