Date:   Thu, 16 Feb 2023 14:12:26 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Karny, Wyes" <Wyes.Karny@amd.com>
Cc:     Rafael J Wysocki <rafael@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Yuan, Perry" <Perry.Yuan@amd.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        Bagas Sanjaya <bagasdotme@gmail.com>,
        "Shukla, Santosh" <Santosh.Shukla@amd.com>,
        Len Brown <lenb@kernel.org>,
        Robert Moore <robert.moore@intel.com>,
        Borislav Petkov <bp@alien8.de>,
        "Narayan, Ananth" <Ananth.Narayan@amd.com>,
        "Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
        Tor Vic <torvic9@mailbox.org>
Subject: Re: [PATCH v6 4/6] Documentation: amd_pstate: Move amd_pstate param
 to alphabetical order
Message-ID: <Y+3JSn5uVCxMShV/@amd.com>
References: <20230206172157.49887-1-wyes.karny@amd.com>
 <20230206172157.49887-5-wyes.karny@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230206172157.49887-5-wyes.karny@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8/QUPrkjqrAnFsfPeBByDDjU4a/SZGnN3HzuIlA9oFAKdOrJMo1Tvfd7ASc/?=
 =?us-ascii?Q?vtYRQpTNek9ugPTx4ykoM1U35QDfHzJosmDECGrecRYw14aUe43WOAIooTQH?=
 =?us-ascii?Q?sPbYrHotgIf/mbAEtMkHBoL7wMLDqEGUFG9pApxKhnUks8A6APDD12rVYLuG?=
 =?us-ascii?Q?pKJ25hpXruxS9Xkd2h700MGRtdHvyJgKz4873ii9qZu3gVUnmd2YJj668BA7?=
 =?us-ascii?Q?C/CItUG+YEQ64vkJmFKjAfxcs4GEm0Px3OzkcWedrkJJtX1CoFstlQ052Id/?=
 =?us-ascii?Q?svgnKS9mY4O3MMfKNrm4sH/h4ntX4ubUjhHGRYWqBJSHoBdkHuQFxeXKl0F3?=
 =?us-ascii?Q?z39blwb8RejY9tuXD4mxjWBAwkYhZy4Ckkd27qKxqdIOqaIu0JM4RYOGaQZJ?=
 =?us-ascii?Q?4JT+zvyr9lXOfK6pmaB3+THebgkKdxbTKlhBY3Hu3Qgk8fN+B39msA/HJq8X?=
 =?us-ascii?Q?6a3EH3EbZ9AZYIv0iG5S141ojkfJNIutfEX/DowXMWPsIa556pfB7nar3M9x?=
 =?us-ascii?Q?24ZGa7Mw2kHK/GH6w/LOj9XXL/pAoJnT8utEx3nIxp/DloZ8lj15GwH9JIyR?=
 =?us-ascii?Q?3XajLahfaE4Rg58DL41LTacBu+Kgv/IeYYsBS/mGmgFK/QzFtsI7FUdkcau/?=
 =?us-ascii?Q?UxIrcCbEdsJZ2P1+ToTT7TEUO6mbknpxPH9GOICYcPClpfmhJuXGCJp6Y+YB?=
 =?us-ascii?Q?33tUATSLAjUsbIJ6uglp0EAaAJ4WHLDL2LkIy0AdDXsbxC9VDOR/hLg0yp6D?=
 =?us-ascii?Q?99ikIIhAAJrAkerfOKvnzetQ+Phc/5pqm6RK7UO0U7MZiOyg5LrPT7AJBIVH?=
 =?us-ascii?Q?VTLIxRj5DO14gouFHBY2r+FksekSyXxOPzLVJm4E/ZLDBpv2AsyTKEig7xGA?=
 =?us-ascii?Q?sB2yAQWsMZGlm2LiXqC217lbc84zWXVkqomEzSfS7HuKB2MJegzBW7EEY0R4?=
 =?us-ascii?Q?JJUsXKxDhD5rF/0sI5gVgzKtuG+vdBz/7CBriblbdfS8MgWVmRbcT6EKU4C7?=
 =?us-ascii?Q?aP+xBnSw7ys0uggaqIgxDIbiBVoFQfuF33CgLyluIdpT9PTLe7SSjGAVCg38?=
 =?us-ascii?Q?aKV0zpbrUqrQEgM9OOMTx7LRbI5gtjnEJGTwHo/+mDnX7+9jQC8N6fGHS6At?=
 =?us-ascii?Q?ulhGR5bNqJ7Eb9xlp8ZhWOyu1DbXpN+RIM84GolTaTzSi7WK4MJlAREW14oy?=
 =?us-ascii?Q?lpVyRpDyBx/O27rnFk6A6eM/ezCD6GbIpdhAT/KujE4tlgHwaB2X6xPEp98K?=
 =?us-ascii?Q?YnsrXTF57+KgrQmj6McLdJj/e3eHBEUshVP2ttT3i2GKfFsIElHCAA0o6Q6/?=
 =?us-ascii?Q?gDL0XX0hYG31DSUGHHmM+9AAaJ3SO5afBpnscVYi6+fGpclgYcWUEooqaWrl?=
 =?us-ascii?Q?9Jz/d/89TbiHdPGgRnJQETrKmtI0vdfwRbZJBSt0W9RYGe0xV3RvBzXb/7p7?=
 =?us-ascii?Q?NItWHm/Hp7Ih7+dsA9nWpNapge+fwCA5nYntBz6Vy0pYYwIqV05vmFIWX7a0?=
 =?us-ascii?Q?K7AgVrNuEof6+A+1DFDzHgKWS7ir1DHcq4FQw6yXMToIMrnvzR+i+qzlbk3q?=
 =?us-ascii?Q?zR5RoASEpjOVIO0GgWEHjmULp1Mi8peL6ynQtMsh?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fb1ebbd3-0217-44d3-abab-08db0fe4d666
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 06:12:52.9101
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LSI7260xdMDQvn3N1olF88vVftmB+46yXZucNoTblDHQQ51Ps9lw7uVEHQhI1d3fNftU4u34Pv+p3VGZq2Evag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR12MB5598
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 07, 2023 at 01:21:55AM +0800, Karny, Wyes wrote:
> Move amd_pstate command line param description to correct alphabetical
> order.
> 
> Signed-off-by: Wyes Karny <wyes.karny@amd.com>
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

Wyes, could you squeeze this minor patch to patch 3? I think we won't need
an additional patch to fix alphabetical order in the documentation.

Thanks,
Ray

> ---
>  .../admin-guide/kernel-parameters.txt         | 46 +++++++++----------
>  1 file changed, 23 insertions(+), 23 deletions(-)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 56d5c189e458..d7685b4268ba 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -339,6 +339,29 @@
>  			             This mode requires kvm-amd.avic=1.
>  			             (Default when IOMMU HW support is present.)
>  
> +	amd_pstate=	[X86]
> +			disable
> +			  Do not enable amd_pstate as the default
> +			  scaling driver for the supported processors
> +			passive
> +			  Use amd_pstate with passive mode as a scaling driver.
> +			  In this mode autonomous selection is disabled.
> +			  Driver requests a desired performance level and platform
> +			  tries to match the same performance level if it is
> +			  satisfied by guaranteed performance level.
> +			active
> +			  Use amd_pstate_epp driver instance as the scaling driver,
> +			  driver provides a hint to the hardware if software wants
> +			  to bias toward performance (0x0) or energy efficiency (0xff)
> +			  to the CPPC firmware. then CPPC power algorithm will
> +			  calculate the runtime workload and adjust the realtime cores
> +			  frequency.
> +			guided
> +			  Activate guided autonomous mode. Driver requests minimum and
> +			  maximum performance level and the platform autonomously
> +			  selects a performance level in this range and appropriate
> +			  to the current workload.
> +
>  	amijoy.map=	[HW,JOY] Amiga joystick support
>  			Map of devices attached to JOY0DAT and JOY1DAT
>  			Format: <a>,<b>
> @@ -7009,26 +7032,3 @@
>  				memory, and other data can't be written using
>  				xmon commands.
>  			off	xmon is disabled.
> -
> -	amd_pstate=	[X86]
> -			disable
> -			  Do not enable amd_pstate as the default
> -			  scaling driver for the supported processors
> -			passive
> -			  Use amd_pstate with passive mode as a scaling driver.
> -			  In this mode autonomous selection is disabled.
> -			  Driver requests a desired performance level and platform
> -			  tries to match the same performance level if it is
> -			  satisfied by guaranteed performance level.
> -			active
> -			  Use amd_pstate_epp driver instance as the scaling driver,
> -			  driver provides a hint to the hardware if software wants
> -			  to bias toward performance (0x0) or energy efficiency (0xff)
> -			  to the CPPC firmware. then CPPC power algorithm will
> -			  calculate the runtime workload and adjust the realtime cores
> -			  frequency.
> -			guided
> -			  Activate guided autonomous mode. Driver requests minimum and
> -			  maximum performance level and the platform autonomously
> -			  selects a performance level in this range and appropriate
> -			  to the current workload.
> -- 
> 2.34.1
>