Date:   Thu, 16 Feb 2023 14:17:16 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Karny, Wyes" <Wyes.Karny@amd.com>
Cc:     Rafael J Wysocki <rafael@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Yuan, Perry" <Perry.Yuan@amd.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        Bagas Sanjaya <bagasdotme@gmail.com>,
        "Shukla, Santosh" <Santosh.Shukla@amd.com>,
        Len Brown <lenb@kernel.org>,
        Robert Moore <robert.moore@intel.com>,
        Borislav Petkov <bp@alien8.de>,
        "Narayan, Ananth" <Ananth.Narayan@amd.com>,
        "Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
        Tor Vic <torvic9@mailbox.org>
Subject: Re: [PATCH v6 6/6] Documentation: amd_pstate: Update amd_pstate
 status sysfs for guided
Message-ID: <Y+3KbMV5u2GUPnUe@amd.com>
References: <20230206172157.49887-1-wyes.karny@amd.com>
 <20230206172157.49887-7-wyes.karny@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230206172157.49887-7-wyes.karny@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Niq8Me8KnNRcMHiwEg9jwfzGKl8xi1FyebAgsnussZSQxbMAYlHZokXARnj+?=
 =?us-ascii?Q?1OjE6LB7L6Kc5prnNxSiayU9Pt7K5PkkOpWuqjUHxeO+iuK3L50FcABH0LVk?=
 =?us-ascii?Q?ryboF+qCwe4AIUHoTj0MBhZMXOY1/v7vqJoHbymTh8S97of1QJx/ffGE1qCJ?=
 =?us-ascii?Q?3gIVHQlJo+5djNRNZJs4RazJUt2ke0xhCoBDWmnJWOue7q4MqvfRE/Hv3MKC?=
 =?us-ascii?Q?uiD5cIiyApkGWeaL2zw38wPo9fnG4c6yCmtYmq9Mr910WMCq24nkR3QfpY4l?=
 =?us-ascii?Q?JqCnzJN6GbU7UDXi5hoVGylQ/llemA/Sdoi+T2Yn8OWPmNl/JCQDbQCa/7F2?=
 =?us-ascii?Q?mZHwQkStf5ZW+wDQS+ZZvjdfvHhn+sc4+z9GmTYkjhhciKOBjHwYafrNYFzb?=
 =?us-ascii?Q?wAkt3m/1oVMMV2/ghbTIDwHLXf1umv6DOTLwWY3i8IrMx97qa9korGLiidUi?=
 =?us-ascii?Q?O6jPgfUtlQzJuEWulFaGh+qJIuglTp78k19bqHoHKa5R/yzeGpt5CNfHMkWV?=
 =?us-ascii?Q?UjSdS1gS6TTXgxBbbr0S0o5XS9aRO5UPlHAEwYmKayo7Qv9Ne9Ffkl8o4Spn?=
 =?us-ascii?Q?gdEfwPZhfp4CSoUM/Eo0IqW7m+kzBWBYjZS9ceuI4s22YyYNCHZJ2LlJfCw7?=
 =?us-ascii?Q?HzbW9QvLgxBcZYengSzhrhdKnjLdMAvbX2do9AA7J7P6DKRIZbewDQb77UqJ?=
 =?us-ascii?Q?7ePnDDFT7TA5fSKZsdyIQdV86/PNwNcgf9RhRULriDt01yE/d1rRkeP8FKNU?=
 =?us-ascii?Q?Xnq57ZMkIIjgm2h7s6yL79JTeS5Kq8DNFQy34tHDhhrIySzBgutALaak4WSy?=
 =?us-ascii?Q?ME3HcJVY00aYA6HsK0VJWaZiHAEsGZeZ7gaQBYqE1kzhKeMWDAWwQvPJTarq?=
 =?us-ascii?Q?04LeHl2+z1VEtjeaRG56xOQovvj+eIq92khFwcxeWdoL7LSfzY8G5ghSIuh6?=
 =?us-ascii?Q?sAZucRJNsFCW3+lGCqglnJxvcWmh4sLSW3cI3fHWsMn+OpZ/ObeHzglxiueI?=
 =?us-ascii?Q?2+iXyme2M7tXANpEtZJjK48mNVoc6OwSxP59hQtk2fB3Va6nSPB2pnz4tWvH?=
 =?us-ascii?Q?m2YGdtoTBfxUA7+hP32MRXfyeyf/cHokKwMQ00JET9FGD54vmsXBWghfCR8H?=
 =?us-ascii?Q?y7TNI2N2o/r06DuX1Ap0yNTzIc39AcalznmvIzEbVJNVQ4ZI9HsmnD+vm2O4?=
 =?us-ascii?Q?9Oc4Hfs2dQxb6C1quJlBMQ5reVz0tD5+fn8Yia6KH9ZmNKsrpCCN4O2BvbA0?=
 =?us-ascii?Q?oOlWWfCIUVsFG4EIJfGI/7qYinO3i0NFB3rqM8OG6+RmyX6bvzu8JjcYKSNM?=
 =?us-ascii?Q?oZPK5c89pnnakAEaFFxkoOxaEMwVCWcUHtOSYMcKp7ExeBgGWXj2l90Dteh8?=
 =?us-ascii?Q?7DyFmzsiRXFqoJ0orq+i6GwMzeaoaLXLKEtxff7ASuwoZksRPFKDbSSl+hd9?=
 =?us-ascii?Q?3gGOSJeFx3Wq8sUT7gihcujAWFCDZqto9NJnqoEUZzB4yCoOKcipoKHSSfAT?=
 =?us-ascii?Q?9s+S65myfl/RGDoPsk5cy20r6G9QCyPbgJQQ/uc7wJQGo1GmF68pEzBs0ysv?=
 =?us-ascii?Q?mCUBGcLtGYGXaNzSFn6hc9kd2elJG7fCFGTdw7qn?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df51a0c5-dbb1-495b-3be1-08db0fe5873d
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 06:17:49.5952
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G/CcJLXEcwiULz1t0d4bZCi65T+blnz1PFC5qmvnYFTDmaPC+TrKklK48PqdYWlPaUJwMAP/XKV57RRUA58Z5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR12MB5598
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 07, 2023 at 01:21:57AM +0800, Karny, Wyes wrote:
> Update amd_pstate status sysfs for guided mode.
> 
> Signed-off-by: Wyes Karny <wyes.karny@amd.com>
> Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

Acked-by: Huang Rui <ray.huang@amd.com>

> ---
>  Documentation/admin-guide/pm/amd-pstate.rst | 31 ++++++++++++++++-----
>  1 file changed, 24 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst
> index 5304adf2fc2f..95d2d0a803fe 100644
> --- a/Documentation/admin-guide/pm/amd-pstate.rst
> +++ b/Documentation/admin-guide/pm/amd-pstate.rst
> @@ -303,13 +303,18 @@ efficiency frequency management method on AMD processors.
>  AMD Pstate Driver Operation Modes
>  =================================
>  
> -``amd_pstate`` CPPC has two operation modes: CPPC Autonomous(active) mode and
> -CPPC non-autonomous(passive) mode.
> -active mode and passive mode can be chosen by different kernel parameters.
> -When in Autonomous mode, CPPC ignores requests done in the Desired Performance
> -Target register and takes into account only the values set to the Minimum requested
> -performance, Maximum requested performance, and Energy Performance Preference
> -registers. When Autonomous is disabled, it only considers the Desired Performance Target.
> +``amd_pstate`` CPPC has 3 operation modes: autonomous (active) mode,
> +non-autonomous (passive) mode and guided autonomous (guided) mode.
> +Active/passive/guided mode can be chosen by different kernel parameters.
> +
> +- In autonomous mode, platform ignores the desired performance level request
> +  and takes into account only the values set to the minimum, maximum and energy
> +  performance preference registers.
> +- In non-autonomous mode, platform gets desired performance level
> +  from OS directly through Desired Performance Register.
> +- In guided-autonomous mode, platform sets operating performance level
> +  autonomously according to the current workload and within the limits set by
> +  OS through min and max performance registers.
>  
>  Active Mode
>  ------------
> @@ -338,6 +343,15 @@ to the Performance Reduction Tolerance register. Above the nominal performance l
>  processor must provide at least nominal performance requested and go higher if current
>  operating conditions allow.
>  
> +Guided Mode
> +-----------
> +
> +``amd_pstate=guided``
> +
> +If ``amd_pstate=guided`` is passed to kernel command line option then this mode
> +is activated.  In this mode, driver requests minimum and maximum performance
> +level and the platform autonomously selects a performance level in this range
> +and appropriate to the current workload.
>  
>  User Space Interface in ``sysfs``
>  =================================
> @@ -358,6 +372,9 @@ control its functionality at the system level.  They are located in the
>  	"passive"
>  		The driver is functional and in the ``passive mode``
>  
> +	"guided"
> +		The driver is functional and in the ``guided mode``
> +
>  	"disable"
>  		The driver is unregistered and not functional now.
>  
> -- 
> 2.34.1
>