Date:   Thu, 16 Feb 2023 14:33:27 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Karny, Wyes" <Wyes.Karny@amd.com>
Cc:     Rafael J Wysocki <rafael@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Yuan, Perry" <Perry.Yuan@amd.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        Bagas Sanjaya <bagasdotme@gmail.com>,
        "Shukla, Santosh" <Santosh.Shukla@amd.com>,
        Len Brown <lenb@kernel.org>,
        Robert Moore <robert.moore@intel.com>,
        Borislav Petkov <bp@alien8.de>,
        "Narayan, Ananth" <Ananth.Narayan@amd.com>,
        "Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
        Tor Vic <torvic9@mailbox.org>
Subject: Re: [PATCH v6 4/6] Documentation: amd_pstate: Move amd_pstate param
 to alphabetical order
Message-ID: <Y+3ON855qAWNcuYE@amd.com>
References: <20230206172157.49887-1-wyes.karny@amd.com>
 <20230206172157.49887-5-wyes.karny@amd.com>
 <Y+3JSn5uVCxMShV/@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y+3JSn5uVCxMShV/@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?inSx6EC7247UgoPi5itPlSXnh8FCrbT7HdXT0Jz1qCJej8pRDxFD1vLM15po?=
 =?us-ascii?Q?b/Iccr2eXidExUM7EBWEzGazWDJRVtOUOlZ6bBY+jIEQ4HBf+nOhnlk/aBmO?=
 =?us-ascii?Q?Z4ikV9ikst24vd55K14175gxu8lvWy16wl47ouWp/D/owNuoL7UcWijtvQiq?=
 =?us-ascii?Q?mZc4A0IaoBXEejMBSqPOZmk7UOUs5qltdbN6lJqD0oG6s+YSZMvTSN5LxQRb?=
 =?us-ascii?Q?TzAsOMPzCltqIiPPm42iwI//WOvH2it5FWi4iVyWWv16JJpYMRIQ+6jMcgwC?=
 =?us-ascii?Q?N7o+AxrXZBL7S6jANPDQ8H1LcvM+ChgyQV6LoKsf4L+N0J26l39ryXkJVe8K?=
 =?us-ascii?Q?daWgfwGP+YCG2mRZ6fl2Nb1eYPUqiVpEeY2AtBBkRLtNN8FMTB1gzMp3j4hO?=
 =?us-ascii?Q?/XE93yAnYWd0RUAVpMF+aQ0PSwROuRsHIGmNcRNHerP59b8il1UPz+2QixVb?=
 =?us-ascii?Q?My+F484t+kLZgPhZeQT37153ToCQbRIQuxu5mZz4bI36Q9CkR+a3pw/fNdqP?=
 =?us-ascii?Q?P0IhN5y+bE4OAzi+urhYfLkSNXC9QHcr5RxjO4GaXxil3CFqOUSNMqcFTdkz?=
 =?us-ascii?Q?aZ3gSCA5XvcbQcacg+GEdNqKs5X/qnMWvoRYTE0uahR7HPmtOIdB4S/Co2Fe?=
 =?us-ascii?Q?/CpjzGsPSpuJkermBcsM3xhck7ZOZYfTV49XBA874NKFOV7Z9YQovGHGDSIM?=
 =?us-ascii?Q?qrst2NPFtN1MxH1yjJBps3VbF+soc8+OefND8t8vLXeDF0dcubYMJ7jk6XcY?=
 =?us-ascii?Q?d09yqSMqvEFdpm4T4Ap4WdW+vVLjQO6SaOUUjHU27OxHP8VRBVo06MYa2FdU?=
 =?us-ascii?Q?I2FeUug7Vx+bKOtNFUwYgMoiRCMjy8mN9s9EeSCkPxB7IEwY8p6GpUuEL/pj?=
 =?us-ascii?Q?jrBUlGT8WUwlqNVn/wSKSHhtQscQTq47ExoSRanF6FP0+5mcz2VHq98q0eWb?=
 =?us-ascii?Q?SJa+4I8sYSv51cJoEPM2zZUZy649hKUHmaUVlyVbdDaB1010+if6DN4wES+h?=
 =?us-ascii?Q?Yo3hnZ4/ctYVW5xj+WBZvBTI4ir2kZsjQuVeMahHk4PAV9HcMH6x9odvLVBI?=
 =?us-ascii?Q?0nHfPy4mPMkwhox0rvxnK8JwfmVM4/Mtf+EsJtMl3Ly00yr4tUp/B+k4qAWq?=
 =?us-ascii?Q?RA5+g8PjPrXHxCgElKoOz/9R0bKlw5sMOvx0hCLyqmnIUoZdzgiUb83J/4YO?=
 =?us-ascii?Q?Zct6vVmwGNCWd8HPV0cWuBWjFDxTnA5BeauHxfZ94SZ4BRe9jCi83pdDNiim?=
 =?us-ascii?Q?lkG7QIiK0MhhHJo+zhThbVHxMuN4l1fpxzSYQcr9bUOJtwsNcDC9cOZk8b93?=
 =?us-ascii?Q?lxj1PooyNusYYSdlf/IqtK6HBlhV6D71kjXwZAtM8+nlVwBYbzS018nZugsp?=
 =?us-ascii?Q?2fF56YjLbrFBCf1NvFnIsc4RvH+eJFOW9BegfzYv0W2ebH5TlThC2vrI07rL?=
 =?us-ascii?Q?e5Ph4skPtKyl/C7w2wQyAAY0WNNT1A4U4xELvQxdsSkSD91tzukE5Px2fFw8?=
 =?us-ascii?Q?jA+NbuoMoCl4XfPiItxCBS6gJmiuZGBJ7/reTidDWTNvkzzyNBRXZh4KGjhK?=
 =?us-ascii?Q?J+2uwFx/uDVS0U2ig9eiguHUcjTPU77bk3urEde7?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 30c8f474-ae65-4677-921b-08db0fe7c5d4
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 06:33:53.5836
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NmgEi6IPZw9vq2QyW6vEqk59owtxChK8f3HHdRRkkZJWbY6/Hdj/zujetqd0PKIWzskp7iC7mrA32C2ebRFTYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8295
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 16, 2023 at 02:12:53PM +0800, Huang Rui wrote:
> On Tue, Feb 07, 2023 at 01:21:55AM +0800, Karny, Wyes wrote:
> > Move amd_pstate command line param description to correct alphabetical
> > order.
> > 
> > Signed-off-by: Wyes Karny <wyes.karny@amd.com>
> > Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> 
> Wyes, could you squeeze this minor patch to patch 3? I think we won't need
> an additional patch to fix alphabetical order in the documentation.

Alternative, you can move this patch prior patch3, then patch3 (guided
autonomous" can add the documentation in correct order.

Thanks,
Ray

> 
> Thanks,
> Ray
> 
> > ---
> >  .../admin-guide/kernel-parameters.txt         | 46 +++++++++----------
> >  1 file changed, 23 insertions(+), 23 deletions(-)
> > 
> > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> > index 56d5c189e458..d7685b4268ba 100644
> > --- a/Documentation/admin-guide/kernel-parameters.txt
> > +++ b/Documentation/admin-guide/kernel-parameters.txt
> > @@ -339,6 +339,29 @@
> >  			             This mode requires kvm-amd.avic=1.
> >  			             (Default when IOMMU HW support is present.)
> >  
> > +	amd_pstate=	[X86]
> > +			disable
> > +			  Do not enable amd_pstate as the default
> > +			  scaling driver for the supported processors
> > +			passive
> > +			  Use amd_pstate with passive mode as a scaling driver.
> > +			  In this mode autonomous selection is disabled.
> > +			  Driver requests a desired performance level and platform
> > +			  tries to match the same performance level if it is
> > +			  satisfied by guaranteed performance level.
> > +			active
> > +			  Use amd_pstate_epp driver instance as the scaling driver,
> > +			  driver provides a hint to the hardware if software wants
> > +			  to bias toward performance (0x0) or energy efficiency (0xff)
> > +			  to the CPPC firmware. then CPPC power algorithm will
> > +			  calculate the runtime workload and adjust the realtime cores
> > +			  frequency.
> > +			guided
> > +			  Activate guided autonomous mode. Driver requests minimum and
> > +			  maximum performance level and the platform autonomously
> > +			  selects a performance level in this range and appropriate
> > +			  to the current workload.
> > +
> >  	amijoy.map=	[HW,JOY] Amiga joystick support
> >  			Map of devices attached to JOY0DAT and JOY1DAT
> >  			Format: <a>,<b>
> > @@ -7009,26 +7032,3 @@
> >  				memory, and other data can't be written using
> >  				xmon commands.
> >  			off	xmon is disabled.
> > -
> > -	amd_pstate=	[X86]
> > -			disable
> > -			  Do not enable amd_pstate as the default
> > -			  scaling driver for the supported processors
> > -			passive
> > -			  Use amd_pstate with passive mode as a scaling driver.
> > -			  In this mode autonomous selection is disabled.
> > -			  Driver requests a desired performance level and platform
> > -			  tries to match the same performance level if it is
> > -			  satisfied by guaranteed performance level.
> > -			active
> > -			  Use amd_pstate_epp driver instance as the scaling driver,
> > -			  driver provides a hint to the hardware if software wants
> > -			  to bias toward performance (0x0) or energy efficiency (0xff)
> > -			  to the CPPC firmware. then CPPC power algorithm will
> > -			  calculate the runtime workload and adjust the realtime cores
> > -			  frequency.
> > -			guided
> > -			  Activate guided autonomous mode. Driver requests minimum and
> > -			  maximum performance level and the platform autonomously
> > -			  selects a performance level in this range and appropriate
> > -			  to the current workload.
> > -- 
> > 2.34.1
> >