Date:   Thu, 16 Feb 2023 06:44:22 +0000
From:   Wyes Karny <wyes.karny@amd.com>
To:     Huang Rui <ray.huang@amd.com>
Cc:     Rafael J Wysocki <rafael@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Yuan, Perry" <Perry.Yuan@amd.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        Bagas Sanjaya <bagasdotme@gmail.com>,
        "Shukla, Santosh" <Santosh.Shukla@amd.com>,
        Len Brown <lenb@kernel.org>,
        Robert Moore <robert.moore@intel.com>,
        Borislav Petkov <bp@alien8.de>,
        "Narayan, Ananth" <Ananth.Narayan@amd.com>,
        "Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
        Tor Vic <torvic9@mailbox.org>
Subject: Re: [PATCH v6 4/6] Documentation: amd_pstate: Move amd_pstate param
 to alphabetical order
Message-ID: <Y+3QxifmInvLA076@beas>
References: <20230206172157.49887-1-wyes.karny@amd.com>
 <20230206172157.49887-5-wyes.karny@amd.com>
 <Y+3JSn5uVCxMShV/@amd.com>
 <Y+3ON855qAWNcuYE@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y+3ON855qAWNcuYE@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9tuYcfsSyI0thjeYmGCJoX15ydKPoVUy5AR1FpqqiGk9Kx4B3hKsqTnMqnZW?=
 =?us-ascii?Q?+UKg8QyCxe2OuuHpUVs1VtkwKHAgsCb3Npqo4Or2m1xBCjTxyA975G7hpWTU?=
 =?us-ascii?Q?Jyubpep42d3kj1BOh+2V1s8BkffWQrQRA0RLJVb1m5rZhbs1VSOKxx+MtPy0?=
 =?us-ascii?Q?S0vbR2ykqiLzlXkd6qZox00DNzJcVF1zJ9Q5z6SiZ3gKbgFpPp+KMruVKmye?=
 =?us-ascii?Q?qnQxEH5PX7QxzC1LLlXqCQPW2KMfWZmMEFgacIjVzEv++1r/gtcEpH0TGtnv?=
 =?us-ascii?Q?sMWQvKZWb+BVyt2LJd65OtN5W688arzhKjNiJrmVBTiFNuHFIZXsV5pcftw9?=
 =?us-ascii?Q?zH7hDVH4H2+UCNt5i+4gx7vjaGoICpOfm2xqhB2Db/bAq6rbCAgF2lfowY0Z?=
 =?us-ascii?Q?wCGLFShwSMZmZbQCxezfym4frUGi7MPTczkYof9DuKQGuJBjuLqgDG+38Wrh?=
 =?us-ascii?Q?wSFCvuLtq4mq3v2NWEdG++vO6G5WqPkED9wO7DM5Wb0h1NJoq68bscqeU4zP?=
 =?us-ascii?Q?uGOfZnq/hFKIjXYJCwfrLMaLUQY8ee4k7hoGim8cdlzPts6Jt5qbGsTecnrN?=
 =?us-ascii?Q?KQO5txvPIEz7PyMtuorCuYXhfoDo4RdAZVkOFOq5HtyCrAUFBJ9Zkq+ZZXPW?=
 =?us-ascii?Q?pM/Y5hChVAJ+t6CnBNRGbRCtysdH2rTttXunwdIYjoInj/d1YIdR2MNXGLLB?=
 =?us-ascii?Q?Gret4gNkFl4OYqKm4KI5Su2gCJKCX9d2y1DFInQyU+Lcd4Z51Dc/x2bLa1OW?=
 =?us-ascii?Q?LKCvKdT5ADLSrSLJDSmJSfrW3DXjEWGRYeIskH31hZaWa0CF+rVqOuz6FW9A?=
 =?us-ascii?Q?QDpKJdkba189BudiSl5NfwNI6yCzfmnfF1+F7m9x7paeMDItFASnEqtwOy7W?=
 =?us-ascii?Q?lVh7G0p38t2pkSbIWT8bhCCiLQUxXB5f7yMwA7pJztqKRrZBq/GvskIU2JvW?=
 =?us-ascii?Q?lrYX8095WCKBScVQwRkRHfoo2yZBOXWiSXydGYFo4hmKQHurhfX+fzFq9kzl?=
 =?us-ascii?Q?6YgbsKGoKP+mhQZuTMl/xzJ8Ro+NDHV6IS2+eOsyrhXrTKNpV5Fq93UKbLhG?=
 =?us-ascii?Q?mCT9V3Now/XOlepvCiBFQ3EZvMTOm6vzId9XOdboHSTAcSoPTfWdqXyBnQqU?=
 =?us-ascii?Q?R4MNeLly0jKpnjOTo0TSOmSGd3oa4HEsuY1KJTCIn8rfETQRZo3bgjZ4Ho6M?=
 =?us-ascii?Q?vRcva6o5pQeRnhdCbq70L/2hlBnF+98ikLB7F96+mA2upAiphUHTfi8Trws/?=
 =?us-ascii?Q?RK/qdh9HK0L3xQUogv7EHbNhY17f6zwgomWRgQPqkJXXcCL8XpxN9rH+/eGI?=
 =?us-ascii?Q?WX8fUJtraZsSlyY8CWUH+92EzWrpailZDD4NXSawt6f0ep1ve8oi5TMmGMBe?=
 =?us-ascii?Q?jpLg9Y+NcFxNg2rtwCzYLF/Vbqmfg9YP83IuQJJpWAhuptBLmUz7dn4VGj2M?=
 =?us-ascii?Q?SU0xq51Zu9ExG6G3mghe7AJcCpxvNnuEiJ+xwsJA4uC8bXlXxUpn8XhjFmnK?=
 =?us-ascii?Q?OgEP3Nv56IMdsfkSYuhSNnDpn8QVRv5st86Obro3jYKr8N9D8L35+WXVXG8q?=
 =?us-ascii?Q?WKd1DHpotS2Ziaa1ATuozDmbCnnmmjK61VauEr8Z?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f8fac58e-dc46-4bbb-6abd-08db0fe944a6
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3876.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 06:44:35.9110
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DOebsvncAuu/pOCatXntR25tb00+DBr/CQFBNc+fqlXxj3bDe+BHdV+xkB5fcQly9iZHlit18rA5K0Peul0Fsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6291
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 16 Feb 14:33, Huang Rui wrote:
> On Thu, Feb 16, 2023 at 02:12:53PM +0800, Huang Rui wrote:
> > On Tue, Feb 07, 2023 at 01:21:55AM +0800, Karny, Wyes wrote:
> > > Move amd_pstate command line param description to correct alphabetical
> > > order.
> > > 
> > > Signed-off-by: Wyes Karny <wyes.karny@amd.com>
> > > Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> > 
> > Wyes, could you squeeze this minor patch to patch 3? I think we won't need
> > an additional patch to fix alphabetical order in the documentation.
> 
> Alternative, you can move this patch prior patch3, then patch3 (guided
> autonomous" can add the documentation in correct order.

Sure, will reorder this.

Thanks,
Wyes
> 
> Thanks,
> Ray
> 
> > 
> > Thanks,
> > Ray
> > 
> > > ---
> > >  .../admin-guide/kernel-parameters.txt         | 46 +++++++++----------
> > >  1 file changed, 23 insertions(+), 23 deletions(-)
> > > 
> > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> > > index 56d5c189e458..d7685b4268ba 100644
> > > --- a/Documentation/admin-guide/kernel-parameters.txt
> > > +++ b/Documentation/admin-guide/kernel-parameters.txt
> > > @@ -339,6 +339,29 @@
> > >  			             This mode requires kvm-amd.avic=1.
> > >  			             (Default when IOMMU HW support is present.)
> > >  
> > > +	amd_pstate=	[X86]
> > > +			disable
> > > +			  Do not enable amd_pstate as the default
> > > +			  scaling driver for the supported processors
> > > +			passive
> > > +			  Use amd_pstate with passive mode as a scaling driver.
> > > +			  In this mode autonomous selection is disabled.
> > > +			  Driver requests a desired performance level and platform
> > > +			  tries to match the same performance level if it is
> > > +			  satisfied by guaranteed performance level.
> > > +			active
> > > +			  Use amd_pstate_epp driver instance as the scaling driver,
> > > +			  driver provides a hint to the hardware if software wants
> > > +			  to bias toward performance (0x0) or energy efficiency (0xff)
> > > +			  to the CPPC firmware. then CPPC power algorithm will
> > > +			  calculate the runtime workload and adjust the realtime cores
> > > +			  frequency.
> > > +			guided
> > > +			  Activate guided autonomous mode. Driver requests minimum and
> > > +			  maximum performance level and the platform autonomously
> > > +			  selects a performance level in this range and appropriate
> > > +			  to the current workload.
> > > +
> > >  	amijoy.map=	[HW,JOY] Amiga joystick support
> > >  			Map of devices attached to JOY0DAT and JOY1DAT
> > >  			Format: <a>,<b>
> > > @@ -7009,26 +7032,3 @@
> > >  				memory, and other data can't be written using
> > >  				xmon commands.
> > >  			off	xmon is disabled.
> > > -
> > > -	amd_pstate=	[X86]
> > > -			disable
> > > -			  Do not enable amd_pstate as the default
> > > -			  scaling driver for the supported processors
> > > -			passive
> > > -			  Use amd_pstate with passive mode as a scaling driver.
> > > -			  In this mode autonomous selection is disabled.
> > > -			  Driver requests a desired performance level and platform
> > > -			  tries to match the same performance level if it is
> > > -			  satisfied by guaranteed performance level.
> > > -			active
> > > -			  Use amd_pstate_epp driver instance as the scaling driver,
> > > -			  driver provides a hint to the hardware if software wants
> > > -			  to bias toward performance (0x0) or energy efficiency (0xff)
> > > -			  to the CPPC firmware. then CPPC power algorithm will
> > > -			  calculate the runtime workload and adjust the realtime cores
> > > -			  frequency.
> > > -			guided
> > > -			  Activate guided autonomous mode. Driver requests minimum and
> > > -			  maximum performance level and the platform autonomously
> > > -			  selects a performance level in this range and appropriate
> > > -			  to the current workload.
> > > -- 
> > > 2.34.1
> > >