Date:   Thu, 16 Feb 2023 07:58:35 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>
Cc:     "# v4 . 16+" <stable@vger.kernel.org>,
        Xiu Jianfeng <xiujianfeng@huawei.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Dan Williams <dan.j.williams@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH stable v5.15.y 1/1] crypto: add __init/__exit annotations
 to init/exit funcs
Message-ID: <Y+3UGwHNMbTQq7bF@kroah.com>
References: <20230214195300.2432989-1-saeed.mirzamohammadi@oracle.com>
 <20230214195300.2432989-2-saeed.mirzamohammadi@oracle.com>
 <Y+yBxXNjBLuonPKP@kroah.com>
 <281CF1A3-C16D-4598-B741-B1128DA97B5B@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <281CF1A3-C16D-4598-B741-B1128DA97B5B@oracle.com>
Precedence: bulk

On Wed, Feb 15, 2023 at 11:10:14PM +0000, Saeed Mirzamohammadi wrote:
> Hi,
> 
> > On Feb 14, 2023, at 10:55 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > 
> > On Tue, Feb 14, 2023 at 11:53:00AM -0800, Saeed Mirzamohammadi wrote:
> >> From: Xiu Jianfeng <xiujianfeng@huawei.com>
> >> 
> >> Add missing __init/__exit annotations to init/exit funcs.
> >> 
> >> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
> >> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> >> (cherry picked from commit 33837be33367172d66d1f2bd6964cc41448e6e7c)
> >> Cc: stable@vger.kernel.org # 5.15+
> >> Signed-off-by: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>
> >> ---
> >> crypto/async_tx/raid6test.c | 4 ++--
> >> crypto/curve25519-generic.c | 4 ++--
> >> crypto/dh.c                 | 4 ++--
> >> crypto/ecdh.c               | 4 ++--
> >> crypto/ecdsa.c              | 4 ++--
> >> crypto/rsa.c                | 4 ++--
> >> crypto/sm2.c                | 4 ++--
> >> 7 files changed, 14 insertions(+), 14 deletions(-)
> > 
> > What bug/problem does this resolve?  Why is this needed in stable
> > kernels?
> 
> I don’t have any specific bug to discuss for this fix. It would help freeing up some memory after initialization for these crypto modules since the init function is only called once but not addressing any major issue. Feel free to disregard if this is trivial for stable.

Exactly how much memory is actually freed here and why is that required
for a stable kernel?

Please read the kernel documentation for what is considered a valid
stable kernel change:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

thanks,

greg k-h