Date:   Thu, 16 Feb 2023 08:19:47 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Qi Feng <fengqi706@gmail.com>
Cc:     jikos@kernel.org, benjamin.tissoires@redhat.com,
        rydberg@bitmath.org, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org, fengqi <fengqi@xiaomi.com>
Subject: Re: [PATCH v2] HID: add KEY_CAMERA_FOCUS event in HID
Message-ID: <Y+3ZE7Pv1JaMmh+E@kroah.com>
References: <20230131114632.14078-1-fengqi706@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230131114632.14078-1-fengqi706@gmail.com>
Precedence: bulk

On Tue, Jan 31, 2023 at 07:46:32PM +0800, Qi Feng wrote:
> From: fengqi <fengqi@xiaomi.com>
> 
> Our HID device need KEY_CAMERA_FOCUS event to control camera, but this
> event is non-existent in current HID driver.we add this event in hid-input.c

Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/process/submitting-patches.rst for what is
needed in order to properly describe the change.

> We committed this v2 version following your previous suggestion

This line is not needed in a changelog text.

> 
> Signed-off-by: fengqi <fengqi@xiaomi.com>
> ---
>  drivers/hid/hid-input.c | 7 +++++++
>  include/linux/hid.h     | 1 +
>  2 files changed, 8 insertions(+)
> 
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index 9b59e436df0a..05fa3e191574 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -1221,6 +1221,13 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
>  			return;
>  		}
>  		goto unknown;
> +	case HID_UP_CAMERA:
> +		switch (usage->hid & HID_USAGE){
> +		case 0x020: map_key_clear(KEY_CAMERA_FOCUS);	break;
> +		case 0x021: map_key_clear(KEY_CAMERA);		break;
> +		default: 	goto ignore;
> +		}
> +		break;		

Always run checkpatch.pl on your submission before sending it out,
otherwise it obviously can not be accepted.

thanks,

greg k-h