Message-ID: <59c24c3d-eb1e-cdee-3d2e-aa1dda5a96fe@linaro.org>
Date:   Thu, 16 Feb 2023 09:57:43 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Content-Language: en-US
From:   Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: acerhdf thermal question
To:     Peter Kaestle <peter@piie.net>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>
Cc:     "open list:ACER ASPIRE ONE TEMPERATURE AND FAN DRIVER" 
        <platform-driver-x86@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


Hi,

the polling interval is specified and modified via a kernel module 
parameter [1]

The value is used to change the polling interval of the thermal zone, 
implying that is accessing the thermal zone device structure internals 
directly [2]

In real use case, is the interval changed at runtime? Or just when the 
module is loaded? If the latter, the interval can be passed to the 
thermal zone at init time without doing a polling change rate after the 
thermal zone started. In this case, we can remove the 
polling_delay_jiffies change in the code and fix the structure leakage 
in this driver.

Otherwise, I can add accessors to this field but I would like to prevent 
adding them if they are not really necessary.

Thanks
   -- D.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/tree/drivers/platform/x86/acerhdf.c?h=thermal/bleeding-edge#n792

[2] 
https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/tree/drivers/platform/x86/acerhdf.c?h=thermal/bleeding-edge#n359

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog