Message-ID: <e2dd81dc-d146-d7b3-1f59-a80606517e1a@kontron.de>
Date:   Thu, 16 Feb 2023 10:05:49 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: [PATCH 4/6] regulator: Add operation to let drivers select vsel
 register
Content-Language: en-US
To:     Mark Brown <broonie@kernel.org>, Frieder Schrempf <frieder@fris.de>
Cc:     Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org,
        Marek Vasut <marex@denx.de>,
        ChiYuan Huang <cy_huang@richtek.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>
References: <20230213155833.1644366-1-frieder@fris.de>
 <20230213155833.1644366-5-frieder@fris.de> <Y+v31bkMWxPEVqrT@sirena.org.uk>
From:   Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <Y+v31bkMWxPEVqrT@sirena.org.uk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUNNeCtsam00WGsyYmpJQnVYM0NPNUQ0S0tmbENqSkZNamtjUTF6dG44ckRh?=
 =?utf-8?B?TWcyeWIyYnBhV1liVDR3NS9oUDVUckwwVUFvT25EOVpOOEk5clFDWUw0aGVh?=
 =?utf-8?B?Y2Q1WVdPZ0VrWVZlZVl4ZmRDNUlrZmljUWV5cm9NRjdzdDNYK29GMEhaaGZU?=
 =?utf-8?B?VVZvSCs5NkFLbUdJYTZLK2NwMUZOWW15bjl5VitsSEswd3J5ZTNDZXlFQXBk?=
 =?utf-8?B?a25Jd2w3bUlJWEZ5ci9vVTdZOHJ0dEZEcDZWcHdmUUtjU0lWdTRVWTlWRFgw?=
 =?utf-8?B?RTYzcFUyd0RyNm1pRTE1c3c5Q29vb0dPZm9pOXNJZkpZd0NuVTZUczVsaDRR?=
 =?utf-8?B?VlZsUVpkMlJEZFFzY1pvNmduZEx2V2VWa2VQN0t4NzVvRDNoaEtjNXpwTnNh?=
 =?utf-8?B?cHZCUFJ0UHVpMjZVZHR1cjlRSk15RUplQUNvTWJRRjlQQmxoMnBZaFJEQWIy?=
 =?utf-8?B?bDZzd3VBVTJ6ZzF2UjJXcWZYYmFLaTNwZmo4MjMzSFJTV1J0dkxwQmJPenA1?=
 =?utf-8?B?NFJPOS9KanBHaDhySk90SkI0T09nVFd4UzYrVzFTclBWS01UdHJBTENLUDJ5?=
 =?utf-8?B?U0dhckZ3VjFsblErUzdka256Wm1PUlJOQjBGb3ZBbjRmZldMV0wrNWEwcDd3?=
 =?utf-8?B?NXdnd0dtVWxWaDNOeDdMMWpEU1ZIdkxpZlFNMDk5QkVWNTVhM1NTc2xPVlZN?=
 =?utf-8?B?T29TYUIxV1FpZnBFMURNWUlSSGowei9oNHlGRmlkTkI5YzdGOGxDUHBnWFZS?=
 =?utf-8?B?bGd0dFNyc0poRURXMG13NENYY2ZRV2MyK2pndTQ2dGc4alp0Q0dvSkZoa3FY?=
 =?utf-8?B?TE1YRXN2Nkg1dlgveVNkdHdoWFNXMkJDU3FxejVUYVRsT2RHc0s4R0pScXJr?=
 =?utf-8?B?RlNkanp4eDBDYXU2bGR2MnlvT2FmWjRpdkFTdFdzSnp5TFFvM3RSdU5hY3Uv?=
 =?utf-8?B?Qi9xT2NOb25NWDVML1I1VjVwNGgydHQzWHp1ZGNqZzErTk40dkg4ZWxHWUNk?=
 =?utf-8?B?ZHo0RHdrVy9yZTB3b3VXN0lHeXBWQVhla3MyamVXVnVZOWRPR3FGblBiZFBx?=
 =?utf-8?B?dDl3djVrSk1JNDdCM1NHMGx4Um9Fbkg0RTZnd1ZzQmpyTE41S3ozc0dpZzJU?=
 =?utf-8?B?Y0NWSURTdHBRNzBFbXJFdzV3Tk9FRDJHQ2E2YkJ1WE5KNUtnM3oxYWZEOVNN?=
 =?utf-8?B?dk1LdUJNUVdRL3g2bXZ5NXd2OTVldEQweURXQ2lFZzJNU0ZNb0FjN0QvQm4v?=
 =?utf-8?B?TXVGMjNaS1VjbHlzdGRrTDliNThpQTd2ZVBSLzAzWTRnQko5a1dQSStnMWRk?=
 =?utf-8?B?TlBaVlo0M3pWWTFBVmRBdmlTcUN4ZTR0ZHZ1akovUHArb1hvdDk0SVBUSldF?=
 =?utf-8?B?M0ZraSs4a1FSR2QyM1BCVDJleEpyL2VtZ0tiSk1XSkJrSVdYTHBMNFdPQXAz?=
 =?utf-8?B?Qzk4Ty9BR2plWHFRZHd2VDZKbTRYbFNzVnVIS1hpMDE4NWF2SnhsRnlWdDhO?=
 =?utf-8?B?VlRmVTgvNVNTYW4zWHhwZkFRZWVydXZadzVpWURnNEw3bGdOdk1vZDQ0WVl2?=
 =?utf-8?B?UHZTRU0wWlNDM3Y2dW9hNGl4KzFrS1Q4MktXUE5QZWdrWE9DeFZMeVh2ZzUz?=
 =?utf-8?B?WWEyR3g2YVdVUVlBeFl1U2d4cVVoNWMyOGhBUDhEdlRPRjdHaGZaU2c4Zkxm?=
 =?utf-8?B?cm5vdzVQaVRnMEpzZ3oxT0haWUhVSUlMMC8vWmIwbkF3NWdKUk81RVJNTkZ1?=
 =?utf-8?B?by9Fa0hsekw4Y3FUMEZrbFZIY3kwcVFJQjJVRU1NTDhISmxENzl4ZHZud3Jz?=
 =?utf-8?B?ZFdzUVp1VXFGWWJLM3RhOWRlaHB1d3ZFSWVzcFlHMVNkbnJaYlUzeTJkUzZr?=
 =?utf-8?B?L0tMTjUvTnUzQWlBajBIMjc5bUNFTVpjWW0vcUxlQlhidUZLaE43eWdVSEMw?=
 =?utf-8?B?YXJEU3NsTTNUKzhZK3VSQU5ZdGh1cENmMjFVTktCRm5DYlloVXpzWGJKTXNn?=
 =?utf-8?B?TmNqWUZpNkcwVHdDeXloS3pkNTV3SnpHWVJKbTB5RFY1KzVyZmFCN3ZGTDhv?=
 =?utf-8?B?WkJDaHZ0eHU5MGJyN2tobm1QWEdxNStwZXEzZkJ5enZCWmM0endJSVRyWng2?=
 =?utf-8?B?NlluRzNiczA2dXRqdGRuRkRya1ZOQzJLVWJPY2ZVY09CN1EyZ0g3Y21PMzRl?=
 =?utf-8?Q?YzV8DONo6zdeC8i2Z7QHeZcv/AZCj2hTVd5QLkc3m2WC?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: 6aff3b6b-3091-4062-9212-08db0ffd00a3
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 09:05:51.6169
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xGcbVPDAxTiaQKKU0pv2sC+/2MfuzmLPCARPO/blZ2dYzzC+VYCifh8SASnln/6XdWTk1cNw96TVt5p3oXpzdVJVkmiyor5LxKrbj7+1znI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR10MB7761
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Mark,

On 14.02.23 22:06, Mark Brown wrote:
> On Mon, Feb 13, 2023 at 04:58:22PM +0100, Frieder Schrempf wrote:
>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>
>> There are regulators that use multiple registers for storing the
>> voltage. Add a get_reg_voltage_sel member to struct regulator_ops in
>> order to let drivers register a function that returns the currently
>> used register.
>>
>> The pca9450 driver will be a user of this as the LDO5 regulator of
>> that chip uses two different control registers depending on the
>> state of an external signal.
> 
> Aside from the build warnings the bots reported it's not clear to
> me that it's better to do this than it is to just have these
> drivers implement appropriate ops directly - there's probably
> going to be cases when it's a different bitfield in the same
> register, and by the time you've implemented the op so things
> aren't completely data driven I'm not sure how much you win by
> reusing the register read/write.

Thanks for the feedback. Makes sense to me, I can do that.

Just to be sure: you are suggesting to to leave the core untouched, use
the existing [get/set]_voltage() ops in the driver and reimplement the
logic of regulator_[get/set]_voltage_sel_regmap() there, right?

Thanks
Frieder