Message-ID: <f80d506d-3292-bc03-c2e9-b167e1b5e71a@redhat.com>
Date:   Thu, 16 Feb 2023 10:11:19 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: acerhdf thermal question
Content-Language: en-US, nl
From:   Hans de Goede <hdegoede@redhat.com>
To:     Daniel Lezcano <daniel.lezcano@linaro.org>,
        Peter Kaestle <peter@piie.net>,
        Mark Gross <markgross@kernel.org>,
        Paul Gortmaker <paul.gortmaker@windriver.com>
Cc:     "open list:ACER ASPIRE ONE TEMPERATURE AND FAN DRIVER" 
        <platform-driver-x86@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <59c24c3d-eb1e-cdee-3d2e-aa1dda5a96fe@linaro.org>
 <ee826228-3fbb-bf66-b2a1-8e8be2776175@redhat.com>
In-Reply-To: <ee826228-3fbb-bf66-b2a1-8e8be2776175@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 2/16/23 10:08, Hans de Goede wrote:
> Hi Daniel,
> 
> On 2/16/23 09:57, Daniel Lezcano wrote:
>>
>> Hi,
>>
>> the polling interval is specified and modified via a kernel module parameter [1]
>>
>> The value is used to change the polling interval of the thermal zone, implying that is accessing the thermal zone device structure internals directly [2]
>>
>> In real use case, is the interval changed at runtime? Or just when the module is loaded? If the latter, the interval can be passed to the thermal zone at init time without doing a polling change rate after the thermal zone started. In this case, we can remove the polling_delay_jiffies change in the code and fix the structure leakage in this driver.
> 
> I believe this very likely only is used at module load-time.
> So the changes you suggest are fine with me.
> 
> I have added Paul Gortmaker to the Cc, Paul is the last person
> to have done any real (*) work on acerhfd AFAICT.
> 
> Paul any objections against making the acerhdf.interval parameter
> something which only works when set at boot / module load time
> and removing the ability to change it at runtime ?

p.s.

I see now that Peter Kaestle is also still active in acking / reviewing
acerhfd changes. So lets wait for Peter's input on this too.

Regards,

Hans


> *) Real as in not related to keeping it aligned with the thermal
> framework/core