From:   Kurt Kanzenbach <kurt@linutronix.de>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>, netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 3/3] net/sched: taprio: dynamic max_sdu larger
 than the max_mtu is unlimited
In-Reply-To: <20230215224632.2532685-4-vladimir.oltean@nxp.com>
References: <20230215224632.2532685-1-vladimir.oltean@nxp.com>
 <20230215224632.2532685-4-vladimir.oltean@nxp.com>
Date:   Thu, 16 Feb 2023 10:28:48 +0100
Message-ID: <87cz6aot67.fsf@kurt>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk

--=-=-=
Content-Type: text/plain

On Thu Feb 16 2023, Vladimir Oltean wrote:
> It makes no sense to keep randomly large max_sdu values, especially if
> larger than the device's max_mtu. These are visible in "tc qdisc show".
> Such a max_sdu is practically unlimited and will cause no packets for
> that traffic class to be dropped on enqueue.
>
> Just set max_sdu_dynamic to U32_MAX, which in the logic below causes
> taprio to save a max_frm_len of U32_MAX and a max_sdu presented to user
> space of 0 (unlimited).
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Doesn't this deserve a Fixes tag as well?

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJGBAEBCgAxFiEEvLm/ssjDfdPf21mSwZPR8qpGc4IFAmPt91ATHGt1cnRAbGlu
dXRyb25peC5kZQAKCRDBk9HyqkZzgiI0D/dS0l99RBHC9jg05/dIdHm+gH9cIsE2
qJd41XPAx+wuONVvCgzbu6Sm/Bu0d98+A61uYLdWxAyli29MPGN6pF77u/GlRw+e
Q5IPyUsutIMjGXnAxMg1YPJhLKCzLMPyDMc6lCm2riIF3SWxFMTeCjdh2imod/3e
X4+JYOF24ctrMFW3trA50jqQDK5VYosEq3ym9yET5gXWvnb2iSbX4hRkN2ucyuTm
zB/2eMpTSdv7+Nnj0NDFgPjrYDqaM30oGRvhr0qum+wd3Fyg/9jwqJY6iwt38m3A
KqYYCLrRdndkDuST2u2O12uSsM/e6kfyWdPJrxqqSc8UQD7Oa74jH4PQSlSOcmcr
+RsMcRLlKBg5KCMre5n9W6zkRtxxY0y4fiziy7b8KwnKRlU1eoD7rTweMXfRJaAA
WflWA/Hwj/0ZEStKPPFdETy/R9l2GDr1/UUXDvOTMiddfUUYrnzB+uwLxoQkVAVa
N8XAM09pkzIYIXmFuZKocyUA73I4WMBVi0A4civyR0aNBZ+Xzuv+TpIQad8zGu0u
8fYWi1ENj3KuiMwB1Bcve9b6ErZTpejBvr+i1O8UryXrou4HZtbJFlzz8YaQi3ER
wQpVEe+Dh1lWu/WU60Cuty0za7z2z7IK9qfTX00qS0N4xG6ccjCBSRcRYfP75LjB
biXpPf1rLbso
=AmxS
-----END PGP SIGNATURE-----
--=-=-=--