Message-ID: <1a5c9e46457a2c515a5d28895844b523ea8315bc.camel@redhat.com>
Subject: Re: [PATCH net-next v2 06/10] net: microchip: sparx5: Add ES0 VCAP
 model and updated KUNIT VCAP model
From:   Paolo Abeni <pabeni@redhat.com>
To:     Steen Hegelund <steen.hegelund@microchip.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>
Cc:     UNGLinuxDriver@microchip.com, Randy Dunlap <rdunlap@infradead.org>,
        Casper Andersson <casper.casan@gmail.com>,
        Russell King <rmk+kernel@armlinux.org.uk>,
        Wan Jiabing <wanjiabing@vivo.com>,
        Nathan Huckleberry <nhuck@google.com>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Daniel Machon <daniel.machon@microchip.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Dan Carpenter <error27@gmail.com>,
        Michael Walle <michael@walle.cc>
Date:   Thu, 16 Feb 2023 10:38:32 +0100
In-Reply-To: <e3ab2825bcb0ae93fd26a35dcaee91224ecadc0b.camel@microchip.com>
References: <20230214104049.1553059-1-steen.hegelund@microchip.com>
         <20230214104049.1553059-7-steen.hegelund@microchip.com>
         <0b639b4294ffa61776756d33fc345e60a576d0ec.camel@redhat.com>
         <e3ab2825bcb0ae93fd26a35dcaee91224ecadc0b.camel@microchip.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-02-16 at 10:07 +0100, Steen Hegelund wrote:
> On Thu, 2023-02-16 at 09:09 +0100, Paolo Abeni wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know =
the
> > content is safe
> >=20
> > On Tue, 2023-02-14 at 11:40 +0100, Steen Hegelund wrote:
> > > This provides the VCAP model for the Sparx5 ES0 (Egress Stage 0) VCAP=
.
> > >=20
> > > This VCAP provides rewriting functionality in the egress path.
> > >=20
> > > Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com>
> > > ---
> > > =C2=A0.../microchip/sparx5/sparx5_vcap_ag_api.c=C2=A0=C2=A0=C2=A0=C2=
=A0 | 385 +++++++++++++++++-
> > > =C2=A0.../net/ethernet/microchip/vcap/vcap_ag_api.h | 174 +++++++-
> > > =C2=A0.../microchip/vcap/vcap_api_debugfs_kunit.c=C2=A0=C2=A0 |=C2=A0=
=C2=A0 4 +-
> > > =C2=A0.../microchip/vcap/vcap_model_kunit.c=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 | 270 +++++++-----
> > > =C2=A0.../microchip/vcap/vcap_model_kunit.h=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 10 +-
> > > =C2=A05 files changed, 721 insertions(+), 122 deletions(-)
> > >=20
> > > diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api=
.c
> > > b/drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c
> > > index 561001ee0516..556d6ea0acd1 100644
> > > --- a/drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c
> > > +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c
> > > @@ -3,8 +3,8 @@
> > > =C2=A0 * Microchip VCAP API
> > > =C2=A0 */
> > >=20
> > > -/* This file is autogenerated by cml-utils 2023-01-17 16:55:38 +0100=
.
> > > - * Commit ID: cc027a9bd71002aebf074df5ad8584fe1545e05e
> > > +/* This file is autogenerated by cml-utils 2023-02-10 11:15:56 +0100=
.
> > > + * Commit ID: c30fb4bf0281cd4a7133bdab6682f9e43c872ada
> > > =C2=A0 */
> >=20
> > If the following has been already discussed, I'm sorry for the
> > duplicates, I missed the relevant thread.
> >=20
> > Since this drivers contains quite a bit of auto-generated code, I'm
> > wondering if you could share the tool and/or the source file, too. That
> > would make reviews more accurate.
>=20
> So far we have not made the tool (CML-Utils) available online, but it is
> included as zip archive in our quarterly BSP releases which are available=
 on
> AWS.
>=20
> The BSP uses it (via Buildroot) to generate register access header files =
and
> VCAP models as well as compiling various test tools that are added to the
> rootfs.
>=20
> It is not because we want CML-Utils to be secret that it is not online, b=
ut
> rather that we want to be free to update/change/remove features as needed
> without breaking any build processes that might have been relying on thes=
e
> features with our customers.

I guess the above could be addresses with proper releases (and possibly
packetization from main distros)

> I would expect that CML-Utils will eventually have its own public repo, b=
ut it
> is probably a little too early yet.=20

Understood. Looking forward the tool maturity ;)

Cheers,

Paolo