Message-ID: <86d7cc82-8ff9-769b-f80f-ff18fe28f44d@amd.com>
Date:   Thu, 16 Feb 2023 15:21:21 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v10 1/9] mm: Introduce memfd_restricted system call to
 create restricted user memory
Content-Language: en-US
To:     Chao Peng <chao.p.peng@linux.intel.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org,
        linux-api@vger.kernel.org, linux-doc@vger.kernel.org,
        qemu-devel@nongnu.org
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Arnd Bergmann <arnd@arndb.de>,
        Naoya Horiguchi <naoya.horiguchi@nec.com>,
        Miaohe Lin <linmiaohe@huawei.com>, x86@kernel.org,
        "H . Peter Anvin" <hpa@zytor.com>, Hugh Dickins <hughd@google.com>,
        Jeff Layton <jlayton@kernel.org>,
        "J . Bruce Fields" <bfields@fieldses.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Shuah Khan <shuah@kernel.org>, Mike Rapoport <rppt@kernel.org>,
        Steven Price <steven.price@arm.com>,
        "Maciej S . Szmigiero" <mail@maciej.szmigiero.name>,
        Vlastimil Babka <vbabka@suse.cz>,
        Vishal Annapurve <vannapurve@google.com>,
        Yu Zhang <yu.c.zhang@linux.intel.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com,
        ak@linux.intel.com, david@redhat.com, aarcange@redhat.com,
        ddutile@redhat.com, dhildenb@redhat.com,
        Quentin Perret <qperret@google.com>, tabba@google.com,
        Michael Roth <michael.roth@amd.com>, mhocko@suse.com,
        wei.w.wang@intel.com
References: <20221202061347.1070246-1-chao.p.peng@linux.intel.com>
 <20221202061347.1070246-2-chao.p.peng@linux.intel.com>
From:   "Nikunj A. Dadhania" <nikunj@amd.com>
In-Reply-To: <20221202061347.1070246-2-chao.p.peng@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NXVnWG5DT3pBUnlkeEhSWjhxYnFaYTB6ejZhSkhIOFlJdER6T2kwY2NheWZu?=
 =?utf-8?B?ZHZsR1JCbnl5K3E1cWU3TjlyL3UzVmJ1UmJraW91WXlWUUtxNzBFanI3bGQx?=
 =?utf-8?B?WXpRdnROcEpLU2E2bFFIdUJNVHI4dEcxRGI1U1pUYkNmUmtYeXQ3NDRjMHJq?=
 =?utf-8?B?NDdtcm1KVHZrS3FoSEthS3dXeWl1Wm9teTM2RWptRFlVN2N0MGd3eEdYL05p?=
 =?utf-8?B?NHczRHNkZEMzWjVFQW14WkNRM2dJR2U4TU55WFo0UTlEUkxRK2Njdm5YeitJ?=
 =?utf-8?B?c3BuV1Ziblg5K2g3a0RnODdSdkFhRW9McS95b09qUG43bUhMeVduSGZXY1lm?=
 =?utf-8?B?RzR0Zlc2dHF0SG1oWjFkblB3K1BCaWh5STI4YUsyUzVhSFBxTU4zckxkN2dL?=
 =?utf-8?B?cUtKQ0htYXpIZW9UQ054Q2dGMHg0NjI3dUlqYXpZTVlaOXdYdFRqMWhkbVdB?=
 =?utf-8?B?T1RqalFxTVpZK3pidzJwRUVtZkk0QmhpdGZxa1VXYjBhYlZvRkpkLzRLd0wz?=
 =?utf-8?B?RkUrN01xS3hRMXNJOXVZR1k3ZVBTaWQzODZqMjhNeE5GaUh5dlBvRkxPVDEz?=
 =?utf-8?B?Um5qU3FTeDU4b1V3c0pvaldIdHAzYUZ0U2ppTkpKKzlidXhXQUt4RFd4bGwx?=
 =?utf-8?B?Y2ludzQ2NjlLQ2lvMHZJWlVrb0lMNEIrbEVhdmZLWE5zRkFhdUxscEJIQUMy?=
 =?utf-8?B?TVpURVpQTWpJWmE0Y2pmTHJHVERZZU0wRUpRSWtQZTRhc0QvVDRkOWsycGYx?=
 =?utf-8?B?MnFjby9OZjhQMGI3bXpETTl4N09ldVNEb3hTZkNkb3k1S1B4aFdGTkVDUzJP?=
 =?utf-8?B?QnlqQkNrMjRyN0tGeHZaUXYzZkRQVmh4d253SzMwY05vNExVU0YrVmtUb0hj?=
 =?utf-8?B?eldCL1MxSXZLd0hwN3UzSzZwbjhTVUZjZVFhS201Z3VsRVRINVM5RG44aStq?=
 =?utf-8?B?YzRTanFPcERUeEpGVFh4OFJzRERpTjIyRHFESzRaUllxUU9FcGhqZFlyWSs3?=
 =?utf-8?B?czlpQkVBUGVibk84MXJKN2tibHZCV0pRQzBwQktneWZoWGVydjVJQmxJZkZj?=
 =?utf-8?B?Tm5TTjJ3b1dtZC80YWpwZ3ZCMCtWWjNMZVIzTTBoWU9qWGtrRHo5TGVNNStk?=
 =?utf-8?B?T1k1TlRubkNmWmVQMWxCU2hZOUg2SWsrTFZTRlNURTdoNWlLakRUbVdpZVIx?=
 =?utf-8?B?d2JKbzRMTGdHbUh3K0x2Um94dDZKZVVnTjcyZ21JMFBxdHYvVE1HbHNYVzdh?=
 =?utf-8?B?blFISzkyY2VPUGc3RXFDUmxWTmhjdHhxVXlyVHlNY25OWTdFdGQ0cXVSY2ta?=
 =?utf-8?B?eE9QN1dnSkhlcllMcjNRaDBoMkhNSnQyNWNEMWF0Z1Bqc3NjRGpLR296aWI2?=
 =?utf-8?B?bWxpY1RKR2xMbTlNeUNzb1lFcmVVZ2lqWFQyajBDRU94RlYyYkcrRHdqL0wx?=
 =?utf-8?B?N2x1MmtLVUFXcEtGZDl3cDN4Q2xtY25uZGxwRXBTSlR2eFNpQTNMeVBjNUw5?=
 =?utf-8?B?V1NpWGROaktLdDRiTFhLSTl3SXhtMjNWYjdYNThueFJhY2R4U0l6Zit5ekJF?=
 =?utf-8?B?NzFDZkhWSThNaGpKUWRGK1JvbkR2K2RmMGV6VFhpc1RIOWdEQnYyZUxxcFcv?=
 =?utf-8?B?am1QQndtRm5OYXFReDN5YVhMUjJnL1RST3BwUyt4UDRSdUNROXF2emlmd3FQ?=
 =?utf-8?B?aUJnN1hQd3FQb2tDaEpCcEE4U28yTE1NcGZVYnQ1Q2tnc3BKb0M4WnF3K0ps?=
 =?utf-8?B?ZTFIY3BYZ05NZUJUbWNlcC93WWVzK3RNdkpOM1VDNm1Hb3J6SHZjMnFjRUZ0?=
 =?utf-8?B?ckVkaEp2MWU0MWhtMThycmNhaFg1Q0V4ZkhBMWkrdXpkdG04bTQ2ZmY3Qm5B?=
 =?utf-8?B?SG1UTGMvNzZ3ZHkrQldOeS9DOUl1SXdrdlFjeWc5a2R1eE11YlNxYmFZa0lU?=
 =?utf-8?B?QkR4MUE0enRSMEhVbk9rV2dUMFltSlpNejhkTWtONlplWS9IQVU4di9SaVV6?=
 =?utf-8?B?MlJSb3NDN1J3cWE3Y2V1V1dwdm9OQUdaL3ZmUGVGQ1l0K0lFZThlMDJBZU84?=
 =?utf-8?B?cTlOREVrUTZqMmF2T0ZkeEpvMWdlZ21HV0ZWdTNIUjY2SkQ0VGpTazZRUFYx?=
 =?utf-8?Q?rgFgqaG8ZnkJVK4qqBoKR+Hr6?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e96d707f-90aa-4882-dacd-08db10036ed9
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6309.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 09:51:53.8317
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lL4mnVPD9cv0od0rUs88y4Ud1AUMOK2PHaHIvvnI2WhZDRcZQH9xfDWnrUACOSTjR0V+CwDAUnTN4ccPcQTPhg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4057
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> +static struct file *restrictedmem_file_create(struct file *memfd)
> +{
> +	struct restrictedmem_data *data;
> +	struct address_space *mapping;
> +	struct inode *inode;
> +	struct file *file;
> +
> +	data = kzalloc(sizeof(*data), GFP_KERNEL);
> +	if (!data)
> +		return ERR_PTR(-ENOMEM);
> +
> +	data->memfd = memfd;
> +	mutex_init(&data->lock);
> +	INIT_LIST_HEAD(&data->notifiers);
> +
> +	inode = alloc_anon_inode(restrictedmem_mnt->mnt_sb);
> +	if (IS_ERR(inode)) {
> +		kfree(data);
> +		return ERR_CAST(inode);
> +	}

alloc_anon_inode() uses new_pseudo_inode() to get the inode. As per the comment, new inode 
is not added to the superblock s_inodes list.

/**
 *	new_inode_pseudo 	- obtain an inode
 *	@sb: superblock
 *
 *	Allocates a new inode for given superblock.
 *	Inode wont be chained in superblock s_inodes list
 *	This means :
 *	- fs can't be unmount
 *	- quotas, fsnotify, writeback can't work
 */

So the restrictedmem_error_page will not find the inode as it was never added to the s_inodes list.

We might need to add the inode after allocating.

	inode_sb_list_add(inode);

> +void restrictedmem_error_page(struct page *page, struct address_space *mapping)
> +{
> +	struct super_block *sb = restrictedmem_mnt->mnt_sb;
> +	struct inode *inode, *next;
> +
> +	if (!shmem_mapping(mapping))
> +		return;
> +
> +	spin_lock(&sb->s_inode_list_lock);
> +	list_for_each_entry_safe(inode, next, &sb->s_inodes, i_sb_list) {
> +		struct restrictedmem_data *data = inode->i_mapping->private_data;
> +		struct file *memfd = data->memfd;
> +
> +		if (memfd->f_mapping == mapping) {
> +			pgoff_t start, end;
> +
> +			spin_unlock(&sb->s_inode_list_lock);
> +
> +			start = page->index;
> +			end = start + thp_nr_pages(page);
> +			restrictedmem_notifier_error(data, start, end);
> +			return;
> +		}
> +	}
> +	spin_unlock(&sb->s_inode_list_lock);
> +}

Regards
Nikunj