Date:   Thu, 16 Feb 2023 12:29:14 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Kurt Kanzenbach <kurt@linutronix.de>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 3/3] net/sched: taprio: dynamic max_sdu larger
 than the max_mtu is unlimited
Message-ID: <20230216102914.wat37qsih5xx3wk4@skbuf>
References: <20230215224632.2532685-1-vladimir.oltean@nxp.com>
 <20230215224632.2532685-4-vladimir.oltean@nxp.com>
 <87cz6aot67.fsf@kurt>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87cz6aot67.fsf@kurt>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZnjQmDFtW6uVzUYzV4jo+oKKUiskpNXYiszkQnLWbtvTzKGJjnMPOhLLIdoT?=
 =?us-ascii?Q?hBWh29/X0bLtHHwD7XpguczW7nBWsZJ6gdLy29mbOrV7e5YNKri11/CWCoAN?=
 =?us-ascii?Q?7avYLYs0UByfrnjrYjr4y7ZjlA3x12Z9OD3cDUKXxghyM0UPfodKHlOyEqia?=
 =?us-ascii?Q?g6ZGZwnHix6J4Ecm+kI+NyWIQqMXx/EYJrXJ0MVd4PUlQebKBN9a8meRU6JK?=
 =?us-ascii?Q?3vF0kX/Ze9SheoWdgW549p0N7M5K1MBcbFebur+gGa222fQLE87xLbvCr6sx?=
 =?us-ascii?Q?VLpoeu1U+pLYwyPRRAAGn0UP+y/RvPOAuTPdw/6M+2XfIEKYPF13QojyVbpI?=
 =?us-ascii?Q?2U/PNkoEhy3Qp+A2iiBGCmM/Hgfy9BRADV38zbep6xsma3thnJ3BwApJuoCX?=
 =?us-ascii?Q?0e09Y+L0J+FrlL/0BRfkQeZ/MBGNh98jjHVHw9W8Mc5hq4qm1ku5q6YyPt9o?=
 =?us-ascii?Q?0LfxMhQKRUc9hoyBTYd8AFfJ11kr6sSdvWw50E9ksqbC0MyI26U3BEyLLB/y?=
 =?us-ascii?Q?Ol2/lDgpTrnKy6+njYi0++lIDf0Dt5YYfEFvIFheqlvQ5aiCqza8OCNsd8Gi?=
 =?us-ascii?Q?cP57ZvtlUTF1EHn2ziWM9htYVQQsgX8H8AIYtIQjZ+mMQQN0XtFUWME30PgD?=
 =?us-ascii?Q?o5mFmrt8hJJPq+W/820IIgW/1ddYEQPIK7BMm+6hM23IpZpIw7aBEDDfdKXA?=
 =?us-ascii?Q?tpcXmcIDu9jRCufEHkxukbyuW6UKqlXtqSvFE78VIoT6VOst50ot2/Hx++ox?=
 =?us-ascii?Q?HbZD57hDh/QHDpuN710VoZShLlS1s+TmziWhHzOqaCiVNZbxTB0+UEsH2FpA?=
 =?us-ascii?Q?fpDxkgaRCRmwEcRre2Y5syfF9ShiGBOked8zxr6n396yhf+c4agi3iYpPA45?=
 =?us-ascii?Q?4v5FP/frmvgL6CbI5xKV7Fvd/wNEIuYAOEu3GpIlp16FVzbEqvDtqci7e/wq?=
 =?us-ascii?Q?OaxNdp1L4+/Nx0s9avifdoIqzufyd2pfvXh/xuIrXcvUWp/O9+Jk/ZPtpPCH?=
 =?us-ascii?Q?pEr1d7GfG5mnHStflXPfFF/Dvc5f1F6zU3+knXJLvyM/c/IvcziuSBcJT2pj?=
 =?us-ascii?Q?pbo64B0GWI1U4nf1T+7qE9BWE27YESVzb1NJozHcBgQRst3yxoIDSPcXGuU5?=
 =?us-ascii?Q?tgkXMhG7f3qLuALC/msqSRgq72H4vGthnzxoQCtvGHMjpoenOUT2h4Y9Wih4?=
 =?us-ascii?Q?WeKuupWXkN2NUlabNOlQC2YyEbcDSlyHWpsLJGyCZ1WhwzHn8NoVDvJy9ahj?=
 =?us-ascii?Q?59GEgUFEzOOZk8bGF+sI5RBahmWv5sdS/Ll4bzS5L489mAwY4VgQu0bjrhmm?=
 =?us-ascii?Q?XTAeqeHyCW/AmIKG0Mw0d8a25J3TWjBKixdcoE1ore804ggFZ5LgUJ2Xi107?=
 =?us-ascii?Q?WSCTJmTITslvrd4rcaBCZIduzveyq5jdlmehQ/xyGZn//SoFYAL+bXKDInr9?=
 =?us-ascii?Q?fHfHRX1Jwc3ekYuIvEbdTcwP3DaWO66un2I5V4HvCqWi+WOIVSnVje7gNmLT?=
 =?us-ascii?Q?dMclSVgbAtvwU+7XS5vZMiiXUhRH2djK642u+EJ9n28ZYAaxKFGa8lTlOvec?=
 =?us-ascii?Q?ocBGn7DYCO45o1cw3WfSuvZMqx0mw+e1I5rQWcF2q0DYApkRdzTNAX0hrFNo?=
 =?us-ascii?Q?+A=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fea21f7f-c2fd-44f7-a3b4-08db1008a8ce
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 10:29:18.2516
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KRKFJrOea/vmdVmsuUG/0TiEUgGHYI7Oe+sGU+r9q2RXO6qRPyMagMptijDiNQ6oTaYbuIkWNk5ibVMtrFAYsw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7095
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 16, 2023 at 10:28:48AM +0100, Kurt Kanzenbach wrote:
> On Thu Feb 16 2023, Vladimir Oltean wrote:
> > It makes no sense to keep randomly large max_sdu values, especially if
> > larger than the device's max_mtu. These are visible in "tc qdisc show".
> > Such a max_sdu is practically unlimited and will cause no packets for
> > that traffic class to be dropped on enqueue.
> >
> > Just set max_sdu_dynamic to U32_MAX, which in the logic below causes
> > taprio to save a max_frm_len of U32_MAX and a max_sdu presented to user
> > space of 0 (unlimited).
> >
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> 
> Doesn't this deserve a Fixes tag as well?

No, I don't think so. It's just so that the user (and later, the offloading
driver) doesn't see arbitrarily large values, just a simplifying 0. I guess
it could potentially make a difference to the software taprio data path with
TSO, if the max MTU is comparable with the segment sizes.

Anyway, with or without the Fixes tag, the patch lands in the same place.