Date:   Thu, 16 Feb 2023 11:37:03 +0100
From:   Horatiu Vultur <horatiu.vultur@microchip.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
        <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next] net: lan966x: Use automatic selection of VCAP
 rule actionset
Message-ID: <20230216103703.vutn5bba3ovtpiei@soft-dev3-1>
References: <20230214084206.1412423-1-horatiu.vultur@microchip.com>
 <20230215213052.6ecea372@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <20230215213052.6ecea372@kernel.org>
Precedence: bulk

The 02/15/2023 21:30, Jakub Kicinski wrote:

Hi Jakub,

> 
> On Tue, 14 Feb 2023 09:42:06 +0100 Horatiu Vultur wrote:
> > Now the VCAP API automatically selects the action set, therefore is
> > not needed to be hardcoded anymore to hardcode the action in the
> > lan966x. Therefore remove this.
> 
> The commit message needs some attention here.
> While at it - instead of saying "now" could you provide the commit
> reference? E.g. "Since commit $hash ("$title") the VCAP API...".

I will update this in the next version. Thanks for the feedback!

-- 
/Horatiu