Message-ID: <2fecab8a-26ae-c62d-bf47-7319e11bbe51@linaro.org>
Date:   Thu, 16 Feb 2023 11:45:05 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH 1/2] dt-bindings: regulator: Add bindings for Richtek
 RT5739
Content-Language: en-US
To:     ChiYuan Huang <cy_huang@richtek.com>
Cc:     broonie@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, lgirdwood@gmail.com,
        u0084500@gmail.com, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
References: <1676426457-1389-1-git-send-email-cy_huang@richtek.com>
 <1676426457-1389-2-git-send-email-cy_huang@richtek.com>
 <9c1f4d0e-83c9-014e-bdb1-38b4b0fb2bbf@linaro.org>
 <20230216095714.GA14578@linuxcarl2.richtek.com>
 <38824a96-804d-84a2-2750-be1325b2e1d2@linaro.org>
 <20230216103530.GA17387@linuxcarl2.richtek.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230216103530.GA17387@linuxcarl2.richtek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 16/02/2023 11:35, ChiYuan Huang wrote:

> https://elixir.bootlin.com/linux/v6.2-rc8/source/drivers/regulator/of_regulator.c#L198
> It seems no need to limit the maxItems. Regulator core will call 'of_map_mode' to check the value.
> Even the value is repeat.
> 
> And for minItems, 'regulator.yaml' already said it's uint32-array. Must be lager than zero, right?
> 
> So how about just keep 'items' and remove the 'maxItems'?

Yeah, go ahead, with that enum, it should be correct..

Best regards,
Krzysztof